From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 03/28] drm: Reorganize helper vtables and their docs Date: Mon, 7 Dec 2015 13:26:46 +0100 Message-ID: <20151207122646.GX13177@ulmo> References: <1449218769-16577-1-git-send-email-daniel.vetter@ffwll.ch> <1449218769-16577-4-git-send-email-daniel.vetter@ffwll.ch> <20151207110009.GE13177@ulmo> <20151207115933.GE10243@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0684209060==" Return-path: In-Reply-To: <20151207115933.GE10243@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , DRI Development , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org --===============0684209060== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qZTZQd/MRfnLEAAX" Content-Disposition: inline --qZTZQd/MRfnLEAAX Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 07, 2015 at 12:59:33PM +0100, Daniel Vetter wrote: > On Mon, Dec 07, 2015 at 12:00:09PM +0100, Thierry Reding wrote: > > On Fri, Dec 04, 2015 at 09:45:44AM +0100, Daniel Vetter wrote: > > [...] > > > diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_= crtc_helper.c > > > index 10d0989db273..077e48d3cac2 100644 > > > --- a/drivers/gpu/drm/drm_crtc_helper.c > > > +++ b/drivers/gpu/drm/drm_crtc_helper.c > > > @@ -62,6 +62,11 @@ > > > * converting to the plane helpers). New drivers must not use these = functions > > > * but need to implement the atomic interface instead, potentially u= sing the > > > * atomic helpers for that. > > > + * > > > + * The these legacy modeset helpers use the same function table stru= ctures as > >=20 > > s/The these/The/ > >=20 > > > diff --git a/include/drm/drm_modeset_helper_vtables.h b/include/drm/d= rm_modeset_helper_vtables.h > > > new file mode 100644 > > > index 000000000000..35c5a1c4e7ba > > > --- /dev/null > > > +++ b/include/drm/drm_modeset_helper_vtables.h > > > @@ -0,0 +1,252 @@ > > > +/* > > > + * Copyright =C2=A9 2015 Intel Corporation > > > + * Daniel Vetter > >=20 > > Perhaps inherit the copyright statements from the includes that you > > extracted these from? >=20 > Done for the above two - all the stuff below is just moved and would > conflict massively with later patches. So left that as per our irc > discussion. For the record, I'm fine with leave the below as-is and fix it up in a follow-up patch. Thierry --qZTZQd/MRfnLEAAX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWZXsGAAoJEN0jrNd/PrOhEaUQAIJjtJE4rgEF8JXjKTklQk9c FzrcN9A/KxZXuihzbxKfcKCusJsCHP/SjD+ENyFq+2e9B5/p9NWxcjCQyRh7I+Ee iCyQ1uS11T28ZiEQtEuZVBhdNd6//OeiQyi6zCpWO4sr2sgrb3mG9AHfiDpWGSpG 6+nY9w/Hll3DuVS/LTdOMLx1U4oe9cL/opSRrpvoqt/2u3lBbsUHrgE3e8/cnBbN /ROKdPJGQRxMCRJ4iyflmAx+eReQRgWBegczOW4iKAQxaqmtQZxGv0Q/j3tYMpNK aC1UkYZt6ZRtI0Iqiq/Ieo+9jmhQ6cCgt/aTdMSfr+oJfG8PzSN8XyYjD120hydk Nd4QyZnjSk2TOmmAD5FyP5xLa49jHIRTEAfx5DIAd7Qm/yf/QMjlkunhrd1ja36k aa3IUW17VlRyWNxWSFdIMQ2LnHxzQFTE3QpUFLQbMbaNId/N573XR7vIJMdiXmGr SzZX+Cs7l+bXHnPGBaS+6sBjOdesp/DmtvnzYn8tF/0dqpoEZY+sv0cDrYsIKjMR 47OXDAE6BsGqzBSZGeUzyLAXdTQbt9dRX01fs1sydvcrp0a/+5oqkpnKlorL+GRi iH+l0OxacbCB67BI+vwZpRkA2Uf8I/+3/vbuxCsYMfW2e5b5cqehafPXTCPaY1Re i8/RvvTtJSwplENXK+LN =aqob -----END PGP SIGNATURE----- --qZTZQd/MRfnLEAAX-- --===============0684209060== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============0684209060==--