From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v3 2/2] eal/linux: Add support for handling built-in kernel modules Date: Mon, 7 Dec 2015 12:55:24 -0800 Message-ID: <20151207125524.1095237c@xeon-e3> References: <1449507460-32038-1-git-send-email-Kamil.Rytarowski@caviumnetworks.com> <1449513365-22282-1-git-send-email-Kamil.Rytarowski@caviumnetworks.com> <1449513365-22282-2-git-send-email-Kamil.Rytarowski@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Kamil Rytarowski Return-path: Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com [209.85.220.45]) by dpdk.org (Postfix) with ESMTP id 334C92A1A for ; Mon, 7 Dec 2015 21:55:16 +0100 (CET) Received: by pacej9 with SMTP id ej9so130677973pac.2 for ; Mon, 07 Dec 2015 12:55:15 -0800 (PST) In-Reply-To: <1449513365-22282-2-git-send-email-Kamil.Rytarowski@caviumnetworks.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 7 Dec 2015 19:36:05 +0100 Kamil Rytarowski wrote: > + /* Check if there is sysfs mounted */ > + if (stat("/sys/module", &st) != 0) { > + RTE_LOG(DEBUG, EAL, "Open /sys/module failed: %s\n", > + strerror(errno)); > return -1; > } This check is useless. If /sys/module does not exist then /sys/module/XXX won't exist either.