From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932729AbbLGTwI (ORCPT ); Mon, 7 Dec 2015 14:52:08 -0500 Received: from mail.savoirfairelinux.com ([208.88.110.44]:56618 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932359AbbLGTwG convert rfc822-to-8bit (ORCPT ); Mon, 7 Dec 2015 14:52:06 -0500 Date: Mon, 7 Dec 2015 14:42:18 -0500 From: Damien Riegel To: Lee Jones Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Shawn Guo , Sascha Hauer , Arnd Bergmann , Samuel Ortiz , Wim Van Sebroeck , Guenter Roeck , kernel@savoirfairelinux.com Subject: Re: [PATCH v7 2/6] mfd: syscon: add a DT property to set value width Message-ID: <20151207194218.GB6030@localhost> Mail-Followup-To: Damien Riegel , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Shawn Guo , Sascha Hauer , Arnd Bergmann , Samuel Ortiz , Wim Van Sebroeck , Guenter Roeck , kernel@savoirfairelinux.com References: <1448899191-13891-1-git-send-email-damien.riegel@savoirfairelinux.com> <1448899191-13891-3-git-send-email-damien.riegel@savoirfairelinux.com> <20151207094020.GF3384@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20151207094020.GF3384@x1> User-Agent: Mutt/1.5.23 (2014-03-12) Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 07, 2015 at 09:40:20AM +0000, Lee Jones wrote: > On Mon, 30 Nov 2015, Damien Riegel wrote: > > > Currently syscon has a fixed configuration of 32 bits for register and > > values widths. In some cases, it would be desirable to be able to > > customize the value width. > > > > For example, certain boards (like the ones manufactured by Technologic > > Systems) have a FPGA that is memory-mapped, but its registers are only > > 16-bit wide. > > > > This patch adds an optional "reg-io-width" DT binding for syscon that > > allows to change the width for the data bus (i.e. val_bits). If this > > property is provided, it will also set the register stride to > > reg-io-width's value. If not provided, the default configuration is > > used. > > > > Signed-off-by: Damien Riegel > > --- > > Documentation/devicetree/bindings/mfd/syscon.txt | 4 ++++ > > drivers/mfd/syscon.c | 13 +++++++++++++ > > 2 files changed, 17 insertions(+) > > Applied, thanks. > Hi Lee, Good to see this patch applied. What's going on now with the other patches of this serie ? How should I handle them ? Thanks, Damien > > diff --git a/Documentation/devicetree/bindings/mfd/syscon.txt b/Documentation/devicetree/bindings/mfd/syscon.txt > > index fe8150b..408f768 100644 > > --- a/Documentation/devicetree/bindings/mfd/syscon.txt > > +++ b/Documentation/devicetree/bindings/mfd/syscon.txt > > @@ -13,6 +13,10 @@ Required properties: > > - compatible: Should contain "syscon". > > - reg: the register region can be accessed from syscon > > > > +Optional property: > > +- reg-io-width: the size (in bytes) of the IO accesses that should be > > + performed on the device. > > + > > Examples: > > gpr: iomuxc-gpr@020e0000 { > > compatible = "fsl,imx6q-iomuxc-gpr", "syscon"; > > diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c > > index 176bf0f..b7aabee 100644 > > --- a/drivers/mfd/syscon.c > > +++ b/drivers/mfd/syscon.c > > @@ -47,6 +47,7 @@ static struct syscon *of_syscon_register(struct device_node *np) > > struct syscon *syscon; > > struct regmap *regmap; > > void __iomem *base; > > + u32 reg_io_width; > > int ret; > > struct regmap_config syscon_config = syscon_regmap_config; > > > > @@ -69,6 +70,18 @@ static struct syscon *of_syscon_register(struct device_node *np) > > else if (of_property_read_bool(np, "little-endian")) > > syscon_config.val_format_endian = REGMAP_ENDIAN_LITTLE; > > > > + /* > > + * search for reg-io-width property in DT. If it is not provided, > > + * default to 4 bytes. regmap_init_mmio will return an error if values > > + * are invalid so there is no need to check them here. > > + */ > > + ret = of_property_read_u32(np, "reg-io-width", ®_io_width); > > + if (ret) > > + reg_io_width = 4; > > + > > + syscon_config.reg_stride = reg_io_width; > > + syscon_config.val_bits = reg_io_width * 8; > > + > > regmap = regmap_init_mmio(NULL, base, &syscon_config); > > if (IS_ERR(regmap)) { > > pr_err("regmap init failed\n"); > > -- > Lee Jones > Linaro STMicroelectronics Landing Team Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Riegel Subject: Re: [PATCH v7 2/6] mfd: syscon: add a DT property to set value width Date: Mon, 7 Dec 2015 14:42:18 -0500 Message-ID: <20151207194218.GB6030@localhost> References: <1448899191-13891-1-git-send-email-damien.riegel@savoirfairelinux.com> <1448899191-13891-3-git-send-email-damien.riegel@savoirfairelinux.com> <20151207094020.GF3384@x1> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20151207094020.GF3384@x1> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Lee Jones Cc: Mark Rutland , devicetree@vger.kernel.org, Russell King , linux-watchdog@vger.kernel.org, Pawel Moll , Ian Campbell , linux-kernel@vger.kernel.org, Wim Van Sebroeck , Rob Herring , Arnd Bergmann , Guenter Roeck , Sascha Hauer , Kumar Gala , kernel@savoirfairelinux.com, Shawn Guo , linux-arm-kernel@lists.infradead.org, Samuel Ortiz List-Id: devicetree@vger.kernel.org T24gTW9uLCBEZWMgMDcsIDIwMTUgYXQgMDk6NDA6MjBBTSArMDAwMCwgTGVlIEpvbmVzIHdyb3Rl Ogo+IE9uIE1vbiwgMzAgTm92IDIwMTUsIERhbWllbiBSaWVnZWwgd3JvdGU6Cj4gCj4gPiBDdXJy ZW50bHkgc3lzY29uIGhhcyBhIGZpeGVkIGNvbmZpZ3VyYXRpb24gb2YgMzIgYml0cyBmb3IgcmVn aXN0ZXIgYW5kCj4gPiB2YWx1ZXMgd2lkdGhzLiBJbiBzb21lIGNhc2VzLCBpdCB3b3VsZCBiZSBk ZXNpcmFibGUgdG8gYmUgYWJsZSB0bwo+ID4gY3VzdG9taXplIHRoZSB2YWx1ZSB3aWR0aC4KPiA+ IAo+ID4gRm9yIGV4YW1wbGUsIGNlcnRhaW4gYm9hcmRzIChsaWtlIHRoZSBvbmVzIG1hbnVmYWN0 dXJlZCBieSBUZWNobm9sb2dpYwo+ID4gU3lzdGVtcykgaGF2ZSBhIEZQR0EgdGhhdCBpcyBtZW1v cnktbWFwcGVkLCBidXQgaXRzIHJlZ2lzdGVycyBhcmUgb25seQo+ID4gMTYtYml0IHdpZGUuCj4g PiAKPiA+IFRoaXMgcGF0Y2ggYWRkcyBhbiBvcHRpb25hbCAicmVnLWlvLXdpZHRoIiBEVCBiaW5k aW5nIGZvciBzeXNjb24gdGhhdAo+ID4gYWxsb3dzIHRvIGNoYW5nZSB0aGUgd2lkdGggZm9yIHRo ZSBkYXRhIGJ1cyAoaS5lLiB2YWxfYml0cykuIElmIHRoaXMKPiA+IHByb3BlcnR5IGlzIHByb3Zp ZGVkLCBpdCB3aWxsIGFsc28gc2V0IHRoZSByZWdpc3RlciBzdHJpZGUgdG8KPiA+IHJlZy1pby13 aWR0aCdzIHZhbHVlLiBJZiBub3QgcHJvdmlkZWQsIHRoZSBkZWZhdWx0IGNvbmZpZ3VyYXRpb24g aXMKPiA+IHVzZWQuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IERhbWllbiBSaWVnZWwgPGRhbWll bi5yaWVnZWxAc2F2b2lyZmFpcmVsaW51eC5jb20+Cj4gPiAtLS0KPiA+ICBEb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvbWZkL3N5c2Nvbi50eHQgfCAgNCArKysrCj4gPiAgZHJpdmVy cy9tZmQvc3lzY29uLmMgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTMgKysrKysrKysr KysrKwo+ID4gIDIgZmlsZXMgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKQo+IAo+IEFwcGxpZWQs IHRoYW5rcy4KPiAKSGkgTGVlLAoKR29vZCB0byBzZWUgdGhpcyBwYXRjaCBhcHBsaWVkLiBXaGF0 J3MgZ29pbmcgb24gbm93IHdpdGggdGhlIG90aGVyCnBhdGNoZXMgb2YgdGhpcyBzZXJpZSA/IEhv dyBzaG91bGQgSSBoYW5kbGUgdGhlbSA/CgpUaGFua3MsCkRhbWllbgoKPiA+IGRpZmYgLS1naXQg YS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWZkL3N5c2Nvbi50eHQgYi9Eb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWZkL3N5c2Nvbi50eHQKPiA+IGluZGV4IGZl ODE1MGIuLjQwOGY3NjggMTAwNjQ0Cj4gPiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUv YmluZGluZ3MvbWZkL3N5c2Nvbi50eHQKPiA+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy9tZmQvc3lzY29uLnR4dAo+ID4gQEAgLTEzLDYgKzEzLDEwIEBAIFJlcXVpcmVk IHByb3BlcnRpZXM6Cj4gPiAgLSBjb21wYXRpYmxlOiBTaG91bGQgY29udGFpbiAic3lzY29uIi4K PiA+ICAtIHJlZzogdGhlIHJlZ2lzdGVyIHJlZ2lvbiBjYW4gYmUgYWNjZXNzZWQgZnJvbSBzeXNj b24KPiA+ICAKPiA+ICtPcHRpb25hbCBwcm9wZXJ0eToKPiA+ICstIHJlZy1pby13aWR0aDogdGhl IHNpemUgKGluIGJ5dGVzKSBvZiB0aGUgSU8gYWNjZXNzZXMgdGhhdCBzaG91bGQgYmUKPiA+ICsg IHBlcmZvcm1lZCBvbiB0aGUgZGV2aWNlLgo+ID4gKwo+ID4gIEV4YW1wbGVzOgo+ID4gIGdwcjog aW9tdXhjLWdwckAwMjBlMDAwMCB7Cj4gPiAgCWNvbXBhdGlibGUgPSAiZnNsLGlteDZxLWlvbXV4 Yy1ncHIiLCAic3lzY29uIjsKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21mZC9zeXNjb24uYyBi L2RyaXZlcnMvbWZkL3N5c2Nvbi5jCj4gPiBpbmRleCAxNzZiZjBmLi5iN2FhYmVlIDEwMDY0NAo+ ID4gLS0tIGEvZHJpdmVycy9tZmQvc3lzY29uLmMKPiA+ICsrKyBiL2RyaXZlcnMvbWZkL3N5c2Nv bi5jCj4gPiBAQCAtNDcsNiArNDcsNyBAQCBzdGF0aWMgc3RydWN0IHN5c2NvbiAqb2Zfc3lzY29u X3JlZ2lzdGVyKHN0cnVjdCBkZXZpY2Vfbm9kZSAqbnApCj4gPiAgCXN0cnVjdCBzeXNjb24gKnN5 c2NvbjsKPiA+ICAJc3RydWN0IHJlZ21hcCAqcmVnbWFwOwo+ID4gIAl2b2lkIF9faW9tZW0gKmJh c2U7Cj4gPiArCXUzMiByZWdfaW9fd2lkdGg7Cj4gPiAgCWludCByZXQ7Cj4gPiAgCXN0cnVjdCBy ZWdtYXBfY29uZmlnIHN5c2Nvbl9jb25maWcgPSBzeXNjb25fcmVnbWFwX2NvbmZpZzsKPiA+ICAK PiA+IEBAIC02OSw2ICs3MCwxOCBAQCBzdGF0aWMgc3RydWN0IHN5c2NvbiAqb2Zfc3lzY29uX3Jl Z2lzdGVyKHN0cnVjdCBkZXZpY2Vfbm9kZSAqbnApCj4gPiAgCSBlbHNlIGlmIChvZl9wcm9wZXJ0 eV9yZWFkX2Jvb2wobnAsICJsaXR0bGUtZW5kaWFuIikpCj4gPiAgCQlzeXNjb25fY29uZmlnLnZh bF9mb3JtYXRfZW5kaWFuID0gUkVHTUFQX0VORElBTl9MSVRUTEU7Cj4gPiAgCj4gPiArCS8qCj4g PiArCSAqIHNlYXJjaCBmb3IgcmVnLWlvLXdpZHRoIHByb3BlcnR5IGluIERULiBJZiBpdCBpcyBu b3QgcHJvdmlkZWQsCj4gPiArCSAqIGRlZmF1bHQgdG8gNCBieXRlcy4gcmVnbWFwX2luaXRfbW1p byB3aWxsIHJldHVybiBhbiBlcnJvciBpZiB2YWx1ZXMKPiA+ICsJICogYXJlIGludmFsaWQgc28g dGhlcmUgaXMgbm8gbmVlZCB0byBjaGVjayB0aGVtIGhlcmUuCj4gPiArCSAqLwo+ID4gKwlyZXQg PSBvZl9wcm9wZXJ0eV9yZWFkX3UzMihucCwgInJlZy1pby13aWR0aCIsICZyZWdfaW9fd2lkdGgp Owo+ID4gKwlpZiAocmV0KQo+ID4gKwkJcmVnX2lvX3dpZHRoID0gNDsKPiA+ICsKPiA+ICsJc3lz Y29uX2NvbmZpZy5yZWdfc3RyaWRlID0gcmVnX2lvX3dpZHRoOwo+ID4gKwlzeXNjb25fY29uZmln LnZhbF9iaXRzID0gcmVnX2lvX3dpZHRoICogODsKPiA+ICsKPiA+ICAJcmVnbWFwID0gcmVnbWFw X2luaXRfbW1pbyhOVUxMLCBiYXNlLCAmc3lzY29uX2NvbmZpZyk7Cj4gPiAgCWlmIChJU19FUlIo cmVnbWFwKSkgewo+ID4gIAkJcHJfZXJyKCJyZWdtYXAgaW5pdCBmYWlsZWRcbiIpOwo+IAo+IC0t IAo+IExlZSBKb25lcwo+IExpbmFybyBTVE1pY3JvZWxlY3Ryb25pY3MgTGFuZGluZyBUZWFtIExl YWQKPiBMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MKPiBG b2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.savoirfairelinux.com ([208.88.110.44]:56618 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932359AbbLGTwG convert rfc822-to-8bit (ORCPT ); Mon, 7 Dec 2015 14:52:06 -0500 Date: Mon, 7 Dec 2015 14:42:18 -0500 From: Damien Riegel To: Lee Jones Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Shawn Guo , Sascha Hauer , Arnd Bergmann , Samuel Ortiz , Wim Van Sebroeck , Guenter Roeck , kernel@savoirfairelinux.com Subject: Re: [PATCH v7 2/6] mfd: syscon: add a DT property to set value width Message-ID: <20151207194218.GB6030@localhost> References: <1448899191-13891-1-git-send-email-damien.riegel@savoirfairelinux.com> <1448899191-13891-3-git-send-email-damien.riegel@savoirfairelinux.com> <20151207094020.GF3384@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20151207094020.GF3384@x1> Content-Transfer-Encoding: QUOTED-PRINTABLE Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On Mon, Dec 07, 2015 at 09:40:20AM +0000, Lee Jones wrote: > On Mon, 30 Nov 2015, Damien Riegel wrote: >=20 > > Currently syscon has a fixed configuration of 32 bits for register = and > > values widths. In some cases, it would be desirable to be able to > > customize the value width. > >=20 > > For example, certain boards (like the ones manufactured by Technolo= gic > > Systems) have a FPGA that is memory-mapped, but its registers are o= nly > > 16-bit wide. > >=20 > > This patch adds an optional "reg-io-width" DT binding for syscon th= at > > allows to change the width for the data bus (i.e. val_bits). If thi= s > > property is provided, it will also set the register stride to > > reg-io-width's value. If not provided, the default configuration is > > used. > >=20 > > Signed-off-by: Damien Riegel > > --- > > Documentation/devicetree/bindings/mfd/syscon.txt | 4 ++++ > > drivers/mfd/syscon.c | 13 ++++++++++++= + > > 2 files changed, 17 insertions(+) >=20 > Applied, thanks. >=20 Hi Lee, Good to see this patch applied. What's going on now with the other patches of this serie ? How should I handle them ? Thanks, Damien > > diff --git a/Documentation/devicetree/bindings/mfd/syscon.txt b/Doc= umentation/devicetree/bindings/mfd/syscon.txt > > index fe8150b..408f768 100644 > > --- a/Documentation/devicetree/bindings/mfd/syscon.txt > > +++ b/Documentation/devicetree/bindings/mfd/syscon.txt > > @@ -13,6 +13,10 @@ Required properties: > > - compatible: Should contain "syscon". > > - reg: the register region can be accessed from syscon > > =20 > > +Optional property: > > +- reg-io-width: the size (in bytes) of the IO accesses that should= be > > + performed on the device. > > + > > Examples: > > gpr: iomuxc-gpr@020e0000 { > > compatible =3D "fsl,imx6q-iomuxc-gpr", "syscon"; > > diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c > > index 176bf0f..b7aabee 100644 > > --- a/drivers/mfd/syscon.c > > +++ b/drivers/mfd/syscon.c > > @@ -47,6 +47,7 @@ static struct syscon *of_syscon_register(struct d= evice_node *np) > > struct syscon *syscon; > > struct regmap *regmap; > > void __iomem *base; > > + u32 reg_io_width; > > int ret; > > struct regmap_config syscon_config =3D syscon_regmap_config; > > =20 > > @@ -69,6 +70,18 @@ static struct syscon *of_syscon_register(struct = device_node *np) > > else if (of_property_read_bool(np, "little-endian")) > > syscon_config.val_format_endian =3D REGMAP_ENDIAN_LITTLE; > > =20 > > + /* > > + * search for reg-io-width property in DT. If it is not provided, > > + * default to 4 bytes. regmap_init_mmio will return an error if v= alues > > + * are invalid so there is no need to check them here. > > + */ > > + ret =3D of_property_read_u32(np, "reg-io-width", ®_io_width); > > + if (ret) > > + reg_io_width =3D 4; > > + > > + syscon_config.reg_stride =3D reg_io_width; > > + syscon_config.val_bits =3D reg_io_width * 8; > > + > > regmap =3D regmap_init_mmio(NULL, base, &syscon_config); > > if (IS_ERR(regmap)) { > > pr_err("regmap init failed\n"); >=20 > --=20 > Lee Jones > Linaro STMicroelectronics Landing Team Lead > Linaro.org =E2=94=82 Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-watchdo= g" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: damien.riegel@savoirfairelinux.com (Damien Riegel) Date: Mon, 7 Dec 2015 14:42:18 -0500 Subject: [PATCH v7 2/6] mfd: syscon: add a DT property to set value width In-Reply-To: <20151207094020.GF3384@x1> References: <1448899191-13891-1-git-send-email-damien.riegel@savoirfairelinux.com> <1448899191-13891-3-git-send-email-damien.riegel@savoirfairelinux.com> <20151207094020.GF3384@x1> Message-ID: <20151207194218.GB6030@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Dec 07, 2015 at 09:40:20AM +0000, Lee Jones wrote: > On Mon, 30 Nov 2015, Damien Riegel wrote: > > > Currently syscon has a fixed configuration of 32 bits for register and > > values widths. In some cases, it would be desirable to be able to > > customize the value width. > > > > For example, certain boards (like the ones manufactured by Technologic > > Systems) have a FPGA that is memory-mapped, but its registers are only > > 16-bit wide. > > > > This patch adds an optional "reg-io-width" DT binding for syscon that > > allows to change the width for the data bus (i.e. val_bits). If this > > property is provided, it will also set the register stride to > > reg-io-width's value. If not provided, the default configuration is > > used. > > > > Signed-off-by: Damien Riegel > > --- > > Documentation/devicetree/bindings/mfd/syscon.txt | 4 ++++ > > drivers/mfd/syscon.c | 13 +++++++++++++ > > 2 files changed, 17 insertions(+) > > Applied, thanks. > Hi Lee, Good to see this patch applied. What's going on now with the other patches of this serie ? How should I handle them ? Thanks, Damien > > diff --git a/Documentation/devicetree/bindings/mfd/syscon.txt b/Documentation/devicetree/bindings/mfd/syscon.txt > > index fe8150b..408f768 100644 > > --- a/Documentation/devicetree/bindings/mfd/syscon.txt > > +++ b/Documentation/devicetree/bindings/mfd/syscon.txt > > @@ -13,6 +13,10 @@ Required properties: > > - compatible: Should contain "syscon". > > - reg: the register region can be accessed from syscon > > > > +Optional property: > > +- reg-io-width: the size (in bytes) of the IO accesses that should be > > + performed on the device. > > + > > Examples: > > gpr: iomuxc-gpr at 020e0000 { > > compatible = "fsl,imx6q-iomuxc-gpr", "syscon"; > > diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c > > index 176bf0f..b7aabee 100644 > > --- a/drivers/mfd/syscon.c > > +++ b/drivers/mfd/syscon.c > > @@ -47,6 +47,7 @@ static struct syscon *of_syscon_register(struct device_node *np) > > struct syscon *syscon; > > struct regmap *regmap; > > void __iomem *base; > > + u32 reg_io_width; > > int ret; > > struct regmap_config syscon_config = syscon_regmap_config; > > > > @@ -69,6 +70,18 @@ static struct syscon *of_syscon_register(struct device_node *np) > > else if (of_property_read_bool(np, "little-endian")) > > syscon_config.val_format_endian = REGMAP_ENDIAN_LITTLE; > > > > + /* > > + * search for reg-io-width property in DT. If it is not provided, > > + * default to 4 bytes. regmap_init_mmio will return an error if values > > + * are invalid so there is no need to check them here. > > + */ > > + ret = of_property_read_u32(np, "reg-io-width", ®_io_width); > > + if (ret) > > + reg_io_width = 4; > > + > > + syscon_config.reg_stride = reg_io_width; > > + syscon_config.val_bits = reg_io_width * 8; > > + > > regmap = regmap_init_mmio(NULL, base, &syscon_config); > > if (IS_ERR(regmap)) { > > pr_err("regmap init failed\n"); > > -- > Lee Jones > Linaro STMicroelectronics Landing Team Lead > Linaro.org ? Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog