From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: [PATCH] qla2xxx: fix ifnullfree.cocci warnings Date: Tue, 8 Dec 2015 10:10:42 +0800 Message-ID: <20151208021042.GA70165@lkp-ib04> References: <201512081044.PEibFacT%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1449535747-2850-6-git-send-email-himanshu.madhani@qlogic.com> Sender: target-devel-owner@vger.kernel.org Cc: kbuild-all@01.org, target-devel@vger.kernel.org, nab@linux-iscsi.org, giridhar.malavali@qlogic.com, linux-scsi@vger.kernel.org, himanshu.madhani@qlogic.com List-Id: linux-scsi@vger.kernel.org drivers/scsi/qla2xxx/qla_iocb.c:2022:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci CC: Himanshu Madhani Signed-off-by: Fengguang Wu --- qla_iocb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/scsi/qla2xxx/qla_iocb.c +++ b/drivers/scsi/qla2xxx/qla_iocb.c @@ -2018,8 +2018,7 @@ qla2x00_els_dcmd_sp_free(void *ptr, void srb_t *sp = (srb_t *)data; struct srb_iocb *elsio = &sp->u.iocb_cmd; - if (sp->fcport) - kfree(sp->fcport); + kfree(sp->fcport); if (elsio->u.els_logo.els_logo_pyld) dma_free_coherent(&ha->pdev->dev, DMA_POOL_SIZE,