From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54056) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6EDl-0001Hk-2Q for qemu-devel@nongnu.org; Tue, 08 Dec 2015 04:06:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a6EDg-0006wm-Uv for qemu-devel@nongnu.org; Tue, 08 Dec 2015 04:06:05 -0500 Date: Tue, 8 Dec 2015 15:40:09 +1100 From: David Gibson Message-ID: <20151208044009.GK20139@voom.fritz.box> References: <1449546921-6378-1-git-send-email-eblake@redhat.com> <1449546921-6378-14-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VSVNCtZB1QZ8vhj+" Content-Disposition: inline In-Reply-To: <1449546921-6378-14-git-send-email-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH v7 13/31] qapi: Drop unused 'kind' for struct/enum visit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, armbru@redhat.com, Michael Roth , Alexander Graf , "open list:sPAPR (pseries)" , Paolo Bonzini , Luiz Capitulino , Andreas =?iso-8859-1?Q?F=E4rber?= --VSVNCtZB1QZ8vhj+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 07, 2015 at 08:55:03PM -0700, Eric Blake wrote: > visit_start_struct() and visit_type_enum() had a 'kind' argument > that was usually set to either the stringized version of the > corresponding qapi type name, or to NULL (although some clients > didn't even get that right). But nothing ever used the argument. > It's even hard to argue that it would be useful in a debugger, > as a stack backtrace also tells which type is being visited. >=20 > Therefore, drop the 'kind' argument as dead. While at it, change > the signature of visit_start_struct() to place the 'name' > argument at the end (other than 'errp'), and the 'size' argument > next to 'obj'; this placement of 'name' matches matches how all > other functions in visit.h do it (visit_type_enum() places > 'strings' between 'obj' and 'name'; visit_get_next_type() places > 'promote_int' between 'type' and 'name'). This also avoids the > confusion caused by splitting related pieces of information, > where the old signature an unrelated parameter in between the > "typename" and sizeof(typename) arguments. >=20 > Signed-off-by: Eric Blake For spapr parts: Acked-by: David Gibson --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --VSVNCtZB1QZ8vhj+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWZl8pAAoJEGw4ysog2bOSrNgQANBImXbIH/x1B0NzfC5OjHZn FIiQpTzHUhmB3Q53mawmjwCyNn+bX+UkYajbaHa/TNEq5hrpGpOvzHw8UYTOVAKI ahYfjfol5ldZ9CYgejHTQl0nVBl13RgZAaDNpaOhQnJVlK3B3ddWjCHZ5eTnAhOq nq7PP0s4MpmoXKcEYkgK8dfawkmwf4mnqtVDnbmAmplb6TYC2j669el2dA36Gm5T hWBW6TkWKLBxaBJggyLiTQ6whThnjAqbr+lEV4xLmY0DfDK9K4fl1WIQ3ontq3or F15jgwsZHe2tgpRduej1IeZz4WHbrGwDVffzPM42ftPVdbUJswDPibOoJsWC7CxM pVesmf54gobcNERE5q/U0rF6AIwbhL4ksO46Vg4hykGF4m7KJqDQzFF8IJUgo5N7 IP+ksZRApk+Wspphqg8uk9QYmU+qQcY6qX7WwfOuxs5iR4LQ38NCfZwFktN1DvV9 93PJvyJMtjhMqm+hFt1DHklPsAhaXL6BMX8uwtv/gZXVcnR664DoxpVBsCjEIaPr OX0BK5jchcUjCKzo3kgc8uJuriJULRv+pvDVVV3Zk8if2Xijt5yrhPYHQVEa9Dgy HEf9QjUHzSGeRECgN2YuFKO+h7/O3hMcNaQ7ILUTSUMh/L2iCu6l8ba46Om76PBM YIA0HQYZasXecXYcXLDC =ARVy -----END PGP SIGNATURE----- --VSVNCtZB1QZ8vhj+--