From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756161AbbLHJIA (ORCPT <rfc822;w@1wt.eu>);
	Tue, 8 Dec 2015 04:08:00 -0500
Received: from casper.infradead.org ([85.118.1.10]:43306 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755743AbbLHJHY (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 8 Dec 2015 04:07:24 -0500
Date: Tue, 8 Dec 2015 10:07:22 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Harish Chegondi <harish.chegondi@intel.com>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com,
        Harish Chegondi <harish.chegondi@gmail.com>,
        Andi Kleen <andi.kleen@intel.com>, Kan Liang <kan.liang@intel.com>,
        Lukasz Anaczkowski <lukasz.anaczkowski@intel.com>
Subject: Re: [PATCH 2/2] perf/x86/intel/uncore: Add Knights Landing uncore
 PMU support
Message-ID: <20151208090722.GH6356@twins.programming.kicks-ass.net>
References: <872e8ef16cfc38e5ff3b45fac1094e6f1722e4ad.1449470704.git.harish.chegondi@intel.com>
 <8ac513981264c3eb10343a3f523f19cc5a2d12fe.1449470704.git.harish.chegondi@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8ac513981264c3eb10343a3f523f19cc5a2d12fe.1449470704.git.harish.chegondi@intel.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Dec 07, 2015 at 02:32:32PM -0800, Harish Chegondi wrote:
> @@ -981,6 +990,8 @@ static int __init uncore_pci_init(void)
>  		break;
>  	case 61: /* Broadwell */
>  		ret = bdw_uncore_pci_init();
> +	case 87: /* Knights Landing */
> +		ret = knl_uncore_pci_init();
>  		break;
>  	default:
>  		return 0;
> @@ -1289,6 +1300,8 @@ static int __init uncore_cpu_init(void)
>  		break;
>  	case 86: /* BDX-DE */
>  		bdx_uncore_cpu_init();
> +	case 87: /* Knights Landing */
> +		knl_uncore_cpu_init();
>  		break;
>  	default:

Surely you need some extra break statements in there?