Re: [PATCH 06/20] qla2xxx: Delete session if initiator is gone from FW

From: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, target-devel@vger.kernel.org,
	nab@linux-iscsi.org, giridhar.malavali@qlogic.com,
	linux-scsi@vger.kernel.org, himanshu.madhani@qlogic.com
Subject: Re: [PATCH 06/20] qla2xxx: Delete session if initiator is gone from FW
Date: Tue, 8 Dec 2015 09:41:50 +0800	[thread overview]
Message-ID: <201512080957.hAIULkZl%fengguang.wu@intel.com> (raw)
In-Reply-To: <1449535747-2850-7-git-send-email-himanshu.madhani@qlogic.com>

[-- Attachment #1: Type: text/plain, Size: 2049 bytes --]

Hi Alexei,

[auto build test WARNING on target/master]
[also build test WARNING on v4.4-rc4 next-20151207]
[cannot apply to scsi/for-next]

url:    https://github.com/0day-ci/linux/commits/Himanshu-Madhani/qla2xxx-Patches-for-target-pending-branch/20151208-093328
base:   https://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git master
config: i386-randconfig-x007-12070758 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/scsi/qla2xxx/qla_target.c: In function 'qlt_do_ctio_completion':
>> drivers/scsi/qla2xxx/qla_target.c:3465:20: warning: comparison of constant '41' with boolean expression is always false [-Wbool-compare]
           (logged_out == CTIO_PORT_LOGGED_OUT) ?
                       ^

vim +/41 +3465 drivers/scsi/qla2xxx/qla_target.c

  3449				/* They are OK */
  3450				ql_dbg(ql_dbg_tgt_mgt, vha, 0xf058,
  3451				    "qla_target(%d): CTIO with "
  3452				    "status %#x received, state %x, se_cmd %p, "
  3453				    "(LIP_RESET=e, ABORTED=2, TARGET_RESET=17, "
  3454				    "TIMEOUT=b, INVALID_RX_ID=8)\n", vha->vp_idx,
  3455				    status, cmd->state, se_cmd);
  3456				break;
  3457	
  3458			case CTIO_PORT_LOGGED_OUT:
  3459			case CTIO_PORT_UNAVAILABLE:
  3460			{
  3461				bool logged_out = (status & 0xFFFF);
  3462				ql_dbg(ql_dbg_tgt_mgt, vha, 0xf059,
  3463				    "qla_target(%d): CTIO with %s status %x "
  3464				    "received (state %x, se_cmd %p)\n", vha->vp_idx,
> 3465				    (logged_out == CTIO_PORT_LOGGED_OUT) ?
  3466				    "PORT LOGGED OUT" : "PORT UNAVAILABLE",
  3467				    status, cmd->state, se_cmd);
  3468	
  3469				if (logged_out && cmd->sess) {
  3470					/*
  3471					 * Session is already logged out, but we need
  3472					 * to notify initiator, who's not aware of this
  3473					 */

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 26411 bytes --]