From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Viktorin Subject: Re: [PATCH v2 2/3] eal/acl: enable acl for armv7-a Date: Tue, 08 Dec 2015 11:25:54 +0100 Message-ID: <20151208102554.4661328.64801.1373@rehivetech.com> References: <1448995276-9599-1-git-send-email-jianbo.liu@linaro.org> <4116700.gN3RbU5N65@xps13> <2562409.c2PxG9doT8@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org To: Thomas Monjalon , Jianbo Liu Return-path: Received: from wes1-so1.wedos.net (wes1-so1.wedos.net [46.28.106.15]) by dpdk.org (Postfix) with ESMTP id ADB265683 for ; Tue, 8 Dec 2015 11:25:55 +0100 (CET) In-Reply-To: <2562409.c2PxG9doT8@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" =C2=A0 P=C5=AFvodn=C3=AD zpr=C3=A1va =C2=A0 Od: Thomas Monjalon Odesl=C3=A1no: =C3=BAter=C3=BD, 8. prosince 2015 11:04 Komu: Jianbo Liu Kopie: dev@dpdk.org; Jan Viktorin; Jerin Jacob P=C5=99edm=C4=9Bt: Re: [dpdk-dev] [PATCH v2 2/3] eal/acl: enable acl for ar= mv7-a 2015-12-08 15:56, Jianbo Liu: > On 8 December 2015 at 10:23, Thomas Monjalon = wrote: > > 2015-12-08 09:50, Jianbo Liu: > >> On 8 December 2015 at 09:18, Thomas Monjalon wrote: > >> > 2015-12-03 23:02, Jianbo Liu: > >> >> -ifeq ($(CONFIG_RTE_ARCH_ARM64),y) > >> >> +ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM) $(CONFIG_RTE_ARCH_ARM64))= ,) > >> > [...] > >> >> +#ifdef RTE_ARCH_ARM > >> >> +/* NEON intrinsic vqtbl1q_u8() is not supported in ARMv7-A(AArch32= ) */ > >> > > >> > I'm convinced there is a good reason why ARMv8 is also called ARCH_A= RM64, > >> > and ARMv7 may be called AArch32 or ARCH_ARM. But I don't know why? > >> > > >> https://lkml.org/lkml/2012/7/15/133 > >> > >> > Is ARCH_ARM32 or ARCH_ARMv7 too simple? > >> > Is it possible to have a 32-bit ARMv8? > >> Yes, ARMv8-R/M > > > > So what does mean CONFIG_RTE_ARCH_ARM? > > ARMv7? ARM32? > > Please consider a renaming. >=20 > I'd rather not renaming becase it can be both ARMv7 and AARCH32, which > are ISA compatibility. > If further differentiation is needed, CONFIG_RTE_ARCH_ARMv7 is added > in the config, just like Jan Viktorin did. >> I don't understand. >> You say CONFIG_RTE_ARCH_ARM is for ARMv7 and AARCH32, right? >> Both are 32-bit right? >> Why not rename it to CONFIG_RTE_ARCH_ARM32? Hello, CONFIG_RTE_ARCH_ARMv7 entry specifies the certain architecture, subset of C= ONFIG_RTE_ARCH_ARM (which is 32b). For ARM64 we can differentiate among architectures v8, v9, ..., v64 :) as w= ell. However, I doubt somebody will use dpdk on ARMv6. IMO, the major options should be CONFIG_RTE_ARCH_ARM and CONFIG_RTE_ARCH_AR= M64. Jan Viktorin RehiveTech Sent from a mobile device=E2=80=8E =E2=80=8E