From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Date: Tue, 08 Dec 2015 12:53:07 +0000 Subject: Re: [PATCH v2 2/9] i2c: add generic routine to parse DT for timing information Message-Id: <20151208125307.GA3359@katana> MIME-Version: 1 Content-Type: multipart/mixed; boundary="IS0zKkzwUGydFO0o" List-Id: References: <1449567473-2084-1-git-send-email-wsa@the-dreams.de> <1449567473-2084-3-git-send-email-wsa@the-dreams.de> <20151208110944.GH1766@lahna.fi.intel.com> In-Reply-To: <20151208110944.GH1766@lahna.fi.intel.com> To: Mika Westerberg Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org, Magnus Damm , Simon Horman , Laurent Pinchart , Geert Uytterhoeven , Yoshihiro Shimoda , linux-rockchip@lists.infradead.org, Andy Shevchenko , Jarkko Nikula --IS0zKkzwUGydFO0o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > I wonder if it makes sense to add "i2c-sda-hold-time-ns" (taken from the > designware driver DT binding) to the timings structure? It is tHD;DAT > parameter in the I2C bus specification. It totally makes sense. I just didn't need it for the RCar driver and didn't want to implement something which isn't actually used. So feel free to add it, or ask me to do it, if you promise to use it in the designware driver :) Thanks for the review! --IS0zKkzwUGydFO0o Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWZtKyAAoJEBQN5MwUoCm2dqQP/34nxInrnYQSTVxE+dBiUae2 qnqUJhDn6r9S4RB3QeOMVmSACBg7rY5XfYkjJS9f40GTgr3Bf2LJW9wuLxXY3Pal Y5dTIWDBQGaVq/DUlixw9KMEO0fsw8i4bKWwYqV3+wbd50ANmsBT91aTc9WksRQV mBwHBv8YgDAgBzlPlVFOFfGTvoHkHxX11uJedegOELWO5X5mID9wpILp0ix3v2mW tqFq4SiPGxJqiIi5l+HREbJpqCGvW+up8AUsRAig68hhlLXmdH/xsf5Yl1tpSMCF nvpdLK21jv1VvJPon1jgCLaunr4KIokaOBT57I7NDDpPTlLAicPxOOm50TUcLrMi ErRhnNeerFmR9nMlG/1oygwVZEjKVGv6NMntQXQ+/rnNrOVXp31OulqjMeVWW0HX t861X56RRPRFhHlh3sbFqiZUw+hGQQjsAf30WGkcgllm39cueB+tZ3SDXOLTgdG3 th5D+9Ox4Dw8mKSmNud+lJESncptk7cJBqZQIV2WgGH+hqNljvHRvLc14vikD6XK XAXk47uXTL+nq8EB81lASxyo7gOmtmDp9ozkfYO0u3f5hSUghxQdE0VfU7ZNSM3c I4JeRubpF912nFkvJXeOPyKjN9rXhQUyDLOxRQ+rWVH+tGPR5bbFzRiBv7HQIoZA SXFpDHXsrnsHnKFjXHI2 =/Rha -----END PGP SIGNATURE----- --IS0zKkzwUGydFO0o-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH v2 2/9] i2c: add generic routine to parse DT for timing information Date: Tue, 8 Dec 2015 13:53:07 +0100 Message-ID: <20151208125307.GA3359@katana> References: <1449567473-2084-1-git-send-email-wsa@the-dreams.de> <1449567473-2084-3-git-send-email-wsa@the-dreams.de> <20151208110944.GH1766@lahna.fi.intel.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IS0zKkzwUGydFO0o" Return-path: Received: from sauhun.de ([89.238.76.85]:42778 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751854AbbLHMxP (ORCPT ); Tue, 8 Dec 2015 07:53:15 -0500 Content-Disposition: inline In-Reply-To: <20151208110944.GH1766@lahna.fi.intel.com> Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Mika Westerberg Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org, Magnus Damm , Simon Horman , Laurent Pinchart , Geert Uytterhoeven , Yoshihiro Shimoda , linux-rockchip@lists.infradead.org, Andy Shevchenko , Jarkko Nikula --IS0zKkzwUGydFO0o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > I wonder if it makes sense to add "i2c-sda-hold-time-ns" (taken from the > designware driver DT binding) to the timings structure? It is tHD;DAT > parameter in the I2C bus specification. It totally makes sense. I just didn't need it for the RCar driver and didn't want to implement something which isn't actually used. So feel free to add it, or ask me to do it, if you promise to use it in the designware driver :) Thanks for the review! --IS0zKkzwUGydFO0o Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWZtKyAAoJEBQN5MwUoCm2dqQP/34nxInrnYQSTVxE+dBiUae2 qnqUJhDn6r9S4RB3QeOMVmSACBg7rY5XfYkjJS9f40GTgr3Bf2LJW9wuLxXY3Pal Y5dTIWDBQGaVq/DUlixw9KMEO0fsw8i4bKWwYqV3+wbd50ANmsBT91aTc9WksRQV mBwHBv8YgDAgBzlPlVFOFfGTvoHkHxX11uJedegOELWO5X5mID9wpILp0ix3v2mW tqFq4SiPGxJqiIi5l+HREbJpqCGvW+up8AUsRAig68hhlLXmdH/xsf5Yl1tpSMCF nvpdLK21jv1VvJPon1jgCLaunr4KIokaOBT57I7NDDpPTlLAicPxOOm50TUcLrMi ErRhnNeerFmR9nMlG/1oygwVZEjKVGv6NMntQXQ+/rnNrOVXp31OulqjMeVWW0HX t861X56RRPRFhHlh3sbFqiZUw+hGQQjsAf30WGkcgllm39cueB+tZ3SDXOLTgdG3 th5D+9Ox4Dw8mKSmNud+lJESncptk7cJBqZQIV2WgGH+hqNljvHRvLc14vikD6XK XAXk47uXTL+nq8EB81lASxyo7gOmtmDp9ozkfYO0u3f5hSUghxQdE0VfU7ZNSM3c I4JeRubpF912nFkvJXeOPyKjN9rXhQUyDLOxRQ+rWVH+tGPR5bbFzRiBv7HQIoZA SXFpDHXsrnsHnKFjXHI2 =/Rha -----END PGP SIGNATURE----- --IS0zKkzwUGydFO0o--