From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Date: Tue, 08 Dec 2015 13:03:46 +0000 Subject: Re: [PATCH v2 2/9] i2c: add generic routine to parse DT for timing information Message-Id: <20151208130346.GO1766@lahna.fi.intel.com> List-Id: References: <1449567473-2084-1-git-send-email-wsa@the-dreams.de> <1449567473-2084-3-git-send-email-wsa@the-dreams.de> <20151208110944.GH1766@lahna.fi.intel.com> <20151208125307.GA3359@katana> In-Reply-To: <20151208125307.GA3359@katana> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wolfram Sang Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org, Magnus Damm , Simon Horman , Laurent Pinchart , Geert Uytterhoeven , Yoshihiro Shimoda , linux-rockchip@lists.infradead.org, Andy Shevchenko , Jarkko Nikula On Tue, Dec 08, 2015 at 01:53:07PM +0100, Wolfram Sang wrote: > > > I wonder if it makes sense to add "i2c-sda-hold-time-ns" (taken from the > > designware driver DT binding) to the timings structure? It is tHD;DAT > > parameter in the I2C bus specification. > > It totally makes sense. I just didn't need it for the RCar driver and > didn't want to implement something which isn't actually used. So feel > free to add it, or ask me to do it, if you promise to use it in the > designware driver :) I can add it in a separate patch later on. Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH v2 2/9] i2c: add generic routine to parse DT for timing information Date: Tue, 8 Dec 2015 15:03:46 +0200 Message-ID: <20151208130346.GO1766@lahna.fi.intel.com> References: <1449567473-2084-1-git-send-email-wsa@the-dreams.de> <1449567473-2084-3-git-send-email-wsa@the-dreams.de> <20151208110944.GH1766@lahna.fi.intel.com> <20151208125307.GA3359@katana> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga01.intel.com ([192.55.52.88]:1905 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750901AbbLHNGI (ORCPT ); Tue, 8 Dec 2015 08:06:08 -0500 Content-Disposition: inline In-Reply-To: <20151208125307.GA3359@katana> Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Wolfram Sang Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org, Magnus Damm , Simon Horman , Laurent Pinchart , Geert Uytterhoeven , Yoshihiro Shimoda , linux-rockchip@lists.infradead.org, Andy Shevchenko , Jarkko Nikula On Tue, Dec 08, 2015 at 01:53:07PM +0100, Wolfram Sang wrote: > > > I wonder if it makes sense to add "i2c-sda-hold-time-ns" (taken from the > > designware driver DT binding) to the timings structure? It is tHD;DAT > > parameter in the I2C bus specification. > > It totally makes sense. I just didn't need it for the RCar driver and > didn't want to implement something which isn't actually used. So feel > free to add it, or ask me to do it, if you promise to use it in the > designware driver :) I can add it in a separate patch later on. Thanks!