From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754148AbbLIUCn (ORCPT <rfc822;w@1wt.eu>);
	Wed, 9 Dec 2015 15:02:43 -0500
Received: from shards.monkeyblade.net ([149.20.54.216]:38782 "EHLO
	shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750977AbbLIUCl (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 9 Dec 2015 15:02:41 -0500
Date: Wed, 09 Dec 2015 15:02:37 -0500 (EST)
Message-Id: <20151209.150237.1395563395881100002.davem@davemloft.net>
To: tj@kernel.org
Cc: alaa@dev.mellanox.co.il, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] cgroup: fix sock_cgroup_data initialization
 on earlier compilers
From: David Miller <davem@davemloft.net>
In-Reply-To: <20151209173046.GO30240@mtj.duckdns.org>
References: <20151209173046.GO30240@mtj.duckdns.org>
X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-7
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 09 Dec 2015 12:02:41 -0800 (PST)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tB9K2mBR028489

From: Tejun Heo <tj@kernel.org>
Date: Wed, 9 Dec 2015 12:30:46 -0500

> sock_cgroup_data is a struct containing an anonymous union.
> sock_cgroup_set_prioidx() and sock_cgroup_set_classid() were
> initializing a field inside the anonymous union as follows.
> 
>  struct sock_ccgroup_data skcd_buf = { .val = VAL };
> 
> While this is fine on more recent compilers, gcc-4.4.7 triggers the
> following errors.
> 
>  include/linux/cgroup-defs.h: In function �sock_cgroup_set_prioidx�:
>  include/linux/cgroup-defs.h:619: error: unknown field �val� specified in initializer
>  include/linux/cgroup-defs.h:619: warning: missing braces around initializer
>  include/linux/cgroup-defs.h:619: warning: (near initialization for �skcd_buf.<anonymous>�)
> 
> This is because .val belongs to the anonymous union nested inside the
> struct but the initializer is missing the nesting.  Fix it by adding
> an extra pair of braces.
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: Alaa Hleihel <alaa@dev.mellanox.co.il>
> Fixes: bd1060a1d671 ("sock, cgroup: add sock->sk_cgroup")

Applied, thanks.
���{.n�+�������+%�����ݶ��w��{.n�+����{��G�����{ay�ʇڙ�,j��f���h��������z_�(�階�ݢj"���m������G������?����&���~��iO��z��v�^�m����������?�I�

From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next] cgroup: fix sock_cgroup_data initialization
 on earlier compilers
Date: Wed, 09 Dec 2015 15:02:37 -0500 (EST)
Message-ID: <20151209.150237.1395563395881100002.davem@davemloft.net>
References: <20151209173046.GO30240@mtj.duckdns.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-7
Content-Transfer-Encoding: base64
Cc: alaa@dev.mellanox.co.il, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
To: tj@kernel.org
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20151209173046.GO30240@mtj.duckdns.org>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

RnJvbTogVGVqdW4gSGVvIDx0akBrZXJuZWwub3JnPg0KRGF0ZTogV2VkLCA5IERlYyAyMDE1IDEy
OjMwOjQ2IC0wNTAwDQoNCj4gc29ja19jZ3JvdXBfZGF0YSBpcyBhIHN0cnVjdCBjb250YWluaW5n
IGFuIGFub255bW91cyB1bmlvbi4NCj4gc29ja19jZ3JvdXBfc2V0X3ByaW9pZHgoKSBhbmQgc29j
a19jZ3JvdXBfc2V0X2NsYXNzaWQoKSB3ZXJlDQo+IGluaXRpYWxpemluZyBhIGZpZWxkIGluc2lk
ZSB0aGUgYW5vbnltb3VzIHVuaW9uIGFzIGZvbGxvd3MuDQo+IA0KPiAgc3RydWN0IHNvY2tfY2Nn
cm91cF9kYXRhIHNrY2RfYnVmID0geyAudmFsID0gVkFMIH07DQo+IA0KPiBXaGlsZSB0aGlzIGlz
IGZpbmUgb24gbW9yZSByZWNlbnQgY29tcGlsZXJzLCBnY2MtNC40LjcgdHJpZ2dlcnMgdGhlDQo+
IGZvbGxvd2luZyBlcnJvcnMuDQo+IA0KPiAgaW5jbHVkZS9saW51eC9jZ3JvdXAtZGVmcy5oOiBJ
biBmdW5jdGlvbiChc29ja19jZ3JvdXBfc2V0X3ByaW9pZHiiOg0KPiAgaW5jbHVkZS9saW51eC9j
Z3JvdXAtZGVmcy5oOjYxOTogZXJyb3I6IHVua25vd24gZmllbGQgoXZhbKIgc3BlY2lmaWVkIGlu
IGluaXRpYWxpemVyDQo+ICBpbmNsdWRlL2xpbnV4L2Nncm91cC1kZWZzLmg6NjE5OiB3YXJuaW5n
OiBtaXNzaW5nIGJyYWNlcyBhcm91bmQgaW5pdGlhbGl6ZXINCj4gIGluY2x1ZGUvbGludXgvY2dy
b3VwLWRlZnMuaDo2MTk6IHdhcm5pbmc6IChuZWFyIGluaXRpYWxpemF0aW9uIGZvciChc2tjZF9i
dWYuPGFub255bW91cz6iKQ0KPiANCj4gVGhpcyBpcyBiZWNhdXNlIC52YWwgYmVsb25ncyB0byB0
aGUgYW5vbnltb3VzIHVuaW9uIG5lc3RlZCBpbnNpZGUgdGhlDQo+IHN0cnVjdCBidXQgdGhlIGlu
aXRpYWxpemVyIGlzIG1pc3NpbmcgdGhlIG5lc3RpbmcuICBGaXggaXQgYnkgYWRkaW5nDQo+IGFu
IGV4dHJhIHBhaXIgb2YgYnJhY2VzLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogVGVqdW4gSGVvIDx0
akBrZXJuZWwub3JnPg0KPiBSZXBvcnRlZC1ieTogQWxhYSBIbGVpaGVsIDxhbGFhQGRldi5tZWxs
YW5veC5jby5pbD4NCj4gRml4ZXM6IGJkMTA2MGExZDY3MSAoInNvY2ssIGNncm91cDogYWRkIHNv
Y2stPnNrX2Nncm91cCIpDQoNCkFwcGxpZWQsIHRoYW5rcy4NCg==