From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v5 2/2] eal/linux: Add support for handling
 built-in kernel modules
Date: Wed, 9 Dec 2015 08:38:58 -0800
Message-ID: <20151209083858.6e812d0a@xeon-e3>
References: <1449588833-485-1-git-send-email-Kamil.Rytarowski@caviumnetworks.com>
 <1449667198-27218-1-git-send-email-Kamil.Rytarowski@caviumnetworks.com>
 <1449667198-27218-2-git-send-email-Kamil.Rytarowski@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Kamil Rytarowski <Kamil.Rytarowski@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com
 [209.85.220.46]) by dpdk.org (Postfix) with ESMTP id CD1B1B62
 for <dev@dpdk.org>; Wed,  9 Dec 2015 17:38:52 +0100 (CET)
Received: by pabur14 with SMTP id ur14so32280405pab.0
 for <dev@dpdk.org>; Wed, 09 Dec 2015 08:38:52 -0800 (PST)
In-Reply-To: <1449667198-27218-2-git-send-email-Kamil.Rytarowski@caviumnetworks.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, 9 Dec 2015 14:19:58 +0100
Kamil Rytarowski <Kamil.Rytarowski@caviumnetworks.com> wrote:

> +	/* Check if there is sysfs mounted */
> +	if (stat("/sys/module", &st) != 0) {
> +		RTE_LOG(DEBUG, EAL, "sysfs is not mounted! error %i (%s)\n",
> +			errno, strerror(errno));
>  		return -1;
>  	}

This check is redundant. Remove it.
If the later "/sys/module/foo" would fail if /sys/module was not present.

> -	while (!feof(fd)) {
> -		n = fscanf(fd, "%29s %*[^\n]", mod_name);
> -		if ((n == 1) && !strcmp(mod_name, module_name)) {
> -			ret = 1;
> -			break;
> -		}
> +
> +	/* A module might be built-in, therefore try sysfs */
> +	n = snprintf(sysfs_mod_name, PATH_MAX, "/sys/module/%s", module_name);