From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753616AbbLIJLB (ORCPT ); Wed, 9 Dec 2015 04:11:01 -0500 Received: from relay.parallels.com ([195.214.232.42]:51428 "EHLO relay.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753205AbbLIJKy (ORCPT ); Wed, 9 Dec 2015 04:10:54 -0500 Date: Wed, 9 Dec 2015 12:10:39 +0300 From: Vladimir Davydov To: Johannes Weiner CC: Andrew Morton , Michal Hocko , , , , Subject: Re: [PATCH 3/8] mm: memcontrol: give the kmem states more descriptive names Message-ID: <20151209091038.GM11488@esperanza> References: <1449599665-18047-1-git-send-email-hannes@cmpxchg.org> <1449599665-18047-4-git-send-email-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1449599665-18047-4-git-send-email-hannes@cmpxchg.org> X-ClientProxiedBy: US-EXCH2.sw.swsoft.com (10.255.249.46) To MSK-EXCH1.sw.swsoft.com (10.67.48.55) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 08, 2015 at 01:34:20PM -0500, Johannes Weiner wrote: > On any given memcg, the kmem accounting feature has three separate > states: not initialized, structures allocated, and actively accounting > slab memory. These are represented through a combination of the > kmem_acct_activated and kmem_acct_active flags, which is confusing. > > Convert to a kmem_state enum with the states NONE, ALLOCATED, and > ONLINE. Then rename the functions to modify the state accordingly. > This follows the nomenclature of css object states more closely. > > Signed-off-by: Johannes Weiner Acked-by: Vladimir Davydov From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f45.google.com (mail-lf0-f45.google.com [209.85.215.45]) by kanga.kvack.org (Postfix) with ESMTP id 253206B0259 for ; Wed, 9 Dec 2015 04:10:59 -0500 (EST) Received: by lfs39 with SMTP id 39so29872967lfs.3 for ; Wed, 09 Dec 2015 01:10:58 -0800 (PST) Received: from relay.parallels.com (relay.parallels.com. [195.214.232.42]) by mx.google.com with ESMTPS id j78si3987911lfi.123.2015.12.09.01.10.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Dec 2015 01:10:57 -0800 (PST) Date: Wed, 9 Dec 2015 12:10:39 +0300 From: Vladimir Davydov Subject: Re: [PATCH 3/8] mm: memcontrol: give the kmem states more descriptive names Message-ID: <20151209091038.GM11488@esperanza> References: <1449599665-18047-1-git-send-email-hannes@cmpxchg.org> <1449599665-18047-4-git-send-email-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1449599665-18047-4-git-send-email-hannes@cmpxchg.org> Sender: owner-linux-mm@kvack.org List-ID: To: Johannes Weiner Cc: Andrew Morton , Michal Hocko , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com On Tue, Dec 08, 2015 at 01:34:20PM -0500, Johannes Weiner wrote: > On any given memcg, the kmem accounting feature has three separate > states: not initialized, structures allocated, and actively accounting > slab memory. These are represented through a combination of the > kmem_acct_activated and kmem_acct_active flags, which is confusing. > > Convert to a kmem_state enum with the states NONE, ALLOCATED, and > ONLINE. Then rename the functions to modify the state accordingly. > This follows the nomenclature of css object states more closely. > > Signed-off-by: Johannes Weiner Acked-by: Vladimir Davydov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Davydov Subject: Re: [PATCH 3/8] mm: memcontrol: give the kmem states more descriptive names Date: Wed, 9 Dec 2015 12:10:39 +0300 Message-ID: <20151209091038.GM11488@esperanza> References: <1449599665-18047-1-git-send-email-hannes@cmpxchg.org> <1449599665-18047-4-git-send-email-hannes@cmpxchg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <1449599665-18047-4-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Transfer-Encoding: 7bit To: Johannes Weiner Cc: Andrew Morton , Michal Hocko , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-team-b10kYP2dOMg@public.gmane.org On Tue, Dec 08, 2015 at 01:34:20PM -0500, Johannes Weiner wrote: > On any given memcg, the kmem accounting feature has three separate > states: not initialized, structures allocated, and actively accounting > slab memory. These are represented through a combination of the > kmem_acct_activated and kmem_acct_active flags, which is confusing. > > Convert to a kmem_state enum with the states NONE, ALLOCATED, and > ONLINE. Then rename the functions to modify the state accordingly. > This follows the nomenclature of css object states more closely. > > Signed-off-by: Johannes Weiner Acked-by: Vladimir Davydov