All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Senna Tschudin <peter.senna@gmail.com>
To: "Geyslan G. Bem" <geyslan@gmail.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/9v2] usb: host: ehci.h: remove macros trailing semicolon
Date: Thu, 10 Dec 2015 11:20:13 +0100	[thread overview]
Message-ID: <20151210102013.GG4013@toshiba-peter.rsr.lip6.fr> (raw)
In-Reply-To: <1449700359-14262-7-git-send-email-geyslan@gmail.com>

On Wed, Dec 09, 2015 at 07:32:36PM -0300, Geyslan G. Bem wrote:
> Removes trailing semicolon from macros.
> 
> Caught by checkpatch:
> "WARNING: macros should not use a trailing semicolon"
> 
> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
As with previous, missing the changelog, but other than that the patch
looks good to me.

Acked-by: Peter Senna Tschudin <peter.senna@gmail.com>
> ---
>  drivers/usb/host/ehci.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
> index ea56147..15de5bf 100644
> --- a/drivers/usb/host/ehci.h
> +++ b/drivers/usb/host/ehci.h
> @@ -635,10 +635,10 @@ struct ehci_tt {
>  /* Prepare the PORTSC wakeup flags during controller suspend/resume */
>  
>  #define ehci_prepare_ports_for_controller_suspend(ehci, do_wakeup)	\
> -		ehci_adjust_port_wakeup_flags(ehci, true, do_wakeup);
> +		ehci_adjust_port_wakeup_flags(ehci, true, do_wakeup)
>  
>  #define ehci_prepare_ports_for_controller_resume(ehci)			\
> -		ehci_adjust_port_wakeup_flags(ehci, false, false);
> +		ehci_adjust_port_wakeup_flags(ehci, false, false)
>  
>  /*-------------------------------------------------------------------------*/
>  
> -- 
> 2.6.3
> 

  reply	other threads:[~2015-12-10 10:20 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-09 22:32 [PATCH 1/9v2] usb: host: ehci.h: remove space before comma Geyslan G. Bem
2015-12-09 22:32 ` [PATCH 2/9v2] usb: host: ehci.h: remove space before function open parenthesis Geyslan G. Bem
2015-12-10  9:24   ` Peter Senna Tschudin
2015-12-09 22:32 ` [PATCH 3/9v2] usb: host: ehci.h: remove space before open square bracket Geyslan G. Bem
2015-12-10  9:27   ` Peter Senna Tschudin
2015-12-09 22:32 ` [PATCH 4/9v2] usb: host: ehci.h: fix single statement macros Geyslan G. Bem
2015-12-10  9:58   ` Peter Senna Tschudin
2015-12-10 11:54   ` Sergei Shtylyov
2015-12-10 12:20     ` Geyslan G. Bem
2015-12-10 13:05       ` Geyslan G. Bem
2015-12-10 14:44         ` Sergei Shtylyov
2015-12-10 14:56           ` Geyslan G. Bem
2015-12-10 17:26             ` Sergei Shtylyov
2015-12-10 17:40               ` Geyslan G. Bem
2015-12-10 17:47                 ` Sergei Shtylyov
2015-12-10 18:04                   ` Geyslan G. Bem
2015-12-09 22:32 ` [PATCH 5/9v2] usb: host: ehci.h: remove direct use of __attribute__ keyword Geyslan G. Bem
2015-12-10 10:01   ` Peter Senna Tschudin
2015-12-10 10:25     ` Geyslan G. Bem
2015-12-09 22:32 ` [PATCH 6/9v2] usb: host: ehci.h: use space after comma Geyslan G. Bem
2015-12-10 10:18   ` Peter Senna Tschudin
2015-12-10 15:57     ` Alan Stern
2015-12-10 16:02       ` Geyslan G. Bem
2015-12-09 22:32 ` [PATCH 7/9v2] usb: host: ehci.h: remove macros trailing semicolon Geyslan G. Bem
2015-12-10 10:20   ` Peter Senna Tschudin [this message]
2015-12-09 22:32 ` [PATCH 8/9v2] usb: host: ehci.h: move pointer operator to name side Geyslan G. Bem
2015-12-10 10:21   ` Peter Senna Tschudin
2015-12-10  9:15 ` [PATCH 1/9v2] usb: host: ehci.h: remove space before comma Peter Senna Tschudin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151210102013.GG4013@toshiba-peter.rsr.lip6.fr \
    --to=peter.senna@gmail.com \
    --cc=geyslan@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.