From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/1] drm/i915: intel_ring_initialized() must be simple and inline Date: Thu, 10 Dec 2015 11:24:54 +0100 Message-ID: <20151210102454.GT20822@phenom.ffwll.local> References: <1449586956-32360-1-git-send-email-david.s.gordon@intel.com> <1449586956-32360-2-git-send-email-david.s.gordon@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by gabe.freedesktop.org (Postfix) with ESMTPS id 16E676E964 for ; Thu, 10 Dec 2015 02:24:58 -0800 (PST) Received: by mail-wm0-f52.google.com with SMTP id w144so17257377wmw.1 for ; Thu, 10 Dec 2015 02:24:58 -0800 (PST) Content-Disposition: inline In-Reply-To: <1449586956-32360-2-git-send-email-david.s.gordon@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBEZWMgMDgsIDIwMTUgYXQgMDM6MDI6MzZQTSArMDAwMCwgRGF2ZSBHb3Jkb24gd3Jv dGU6Cj4gQmFzZWQgb24gQ2hyaXMgV2lsc29uJ3MgcGF0Y2ggZnJvbSA2IG1vbnRocyBhZ28sIHJl YmFzZWQgYW5kIGFkYXB0ZWQuCj4gCj4gVGhlIGN1cnJlbnQgaW1wbGVtZW50YXRpb24gb2YgaW50 ZWxfcmluZ19pbml0aWFsaXplZCgpIGlzIHRvbyBoZWF2eXdlaWdodDsKPiBpdCdzIGEgbm9uLWlu bGluZWQgZnVuY3Rpb24gdGhhdCBjaGFzZXMgc2V2ZXJhbCBsZXZlbHMgb2YgcG9pbnRlcnMuIFRo aXMKPiB3b3VsZG4ndCBtYXR0ZXIgdG9vIG11Y2ggaWYgaXQgd2VyZSByYXJlbHkgY2FsbGVkLCBi dXQgaXQncyB1c2VkIGluc2lkZQo+IHRoZSBpdGVyYXRvciB0ZXN0IG9mIGZvcl9lYWNoX3Jpbmco KSBhbmQgaXMgdGhlcmVmb3JlIGNhbGxlZCBxdWl0ZQo+IGZyZXF1ZW50bHkuIFNvIGxldCdzIG1h a2UgaXQgc2ltcGxlIGFuZCBpbmxpbmUgLi4uCj4gCj4gVGhlIGlkZWEgaGVyZSBpcyB0byB1c2Ug cmluZy0+ZGV2IGFzIGFuIGluZGljYXRvciBzaG93aW5nIHdoaWNoIGVuZ2luZXMKPiBoYXZlIGJl ZW4gaW5pdGlhbGlzZWQgYW5kIGFyZSB0aGVyZWZvcmUgdG8gYmUgaW5jbHVkZWQgaW4gaXRlcmF0 aW9ucyB0aGF0Cj4gdXNlIGZvcl9lYWNoX3JpbmcoKS4gVGhpcyBhbGxvd3MgdXMgdG8gYXZvaWQg bXVsdGlwbGUgbWVtb3J5IHJlZmVyZW5jZXMKPiBhbmQgYSAobm9uLWlubGluZWQpIGZ1bmN0aW9u IGNhbGwgb24gZWFjaCBpdGVyYXRpb24gb2YgZWFjaCBzdWNoIGxvb3AuCj4gCj4gCUZpeGVzIHJl Z3Jlc3Npb24gZnJvbQo+IAljb21taXQgNDhkODIzODc4ZDY0ZjkzMTYzZjVhOTQ5NjIzMzQ2NzQ4 YmJjZTFiNAo+IAlBdXRob3I6IE9zY2FyIE1hdGVvIDxvc2Nhci5tYXRlb0BpbnRlbC5jb20+Cj4g CURhdGU6ICAgVGh1IEp1bCAyNCAxNzowNDoyMyAyMDE0ICswMTAwCj4gCj4gCSAgICBkcm0vaTkx NS9iZHc6IEdlbmVyaWMgbG9naWNhbCByaW5nIGluaXQgYW5kIGNsZWFudXAKPiAKPiBTaWduZWQt b2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBTaWduZWQt b2ZmLWJ5OiBEYXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25AaW50ZWwuY29tPgoKUXVldWVkIGZv ciAtbmV4dCwgdGhhbmtzIGZvciB0aGUgcGF0Y2guCi1EYW5pZWwKPiAtLS0KPiAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgICAgICAgIHwgMTcgKysrKysrKysrLS0tLS0KPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jIHwgMzkgKysrKysrKysrKystLS0t LS0tLS0tLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZm ZXIuaCB8ICA2ICsrKystCj4gIDMgZmlsZXMgY2hhbmdlZCwgMzAgaW5zZXJ0aW9ucygrKSwgMzIg ZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2xyYy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiBpbmRleCA0ZWJhZmFi Li43NjQ0YzQ4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiBAQCAtMTg5NCw4ICsx ODk0LDEwIEBAIHZvaWQgaW50ZWxfbG9naWNhbF9yaW5nX2NsZWFudXAoc3RydWN0IGludGVsX2Vu Z2luZV9jcyAqcmluZykKPiAgCj4gIAlkZXZfcHJpdiA9IHJpbmctPmRldi0+ZGV2X3ByaXZhdGU7 Cj4gIAo+IC0JaW50ZWxfbG9naWNhbF9yaW5nX3N0b3AocmluZyk7Cj4gLQlXQVJOX09OKChJOTE1 X1JFQURfTU9ERShyaW5nKSAmIE1PREVfSURMRSkgPT0gMCk7Cj4gKwlpZiAocmluZy0+YnVmZmVy KSB7Cj4gKwkJaW50ZWxfbG9naWNhbF9yaW5nX3N0b3AocmluZyk7Cj4gKwkJV0FSTl9PTigoSTkx NV9SRUFEX01PREUocmluZykgJiBNT0RFX0lETEUpID09IDApOwo+ICsJfQo+ICAKPiAgCWlmIChy aW5nLT5jbGVhbnVwKQo+ICAJCXJpbmctPmNsZWFudXAocmluZyk7Cj4gQEAgLTE5MDksNiArMTkx MSw3IEBAIHZvaWQgaW50ZWxfbG9naWNhbF9yaW5nX2NsZWFudXAoc3RydWN0IGludGVsX2VuZ2lu ZV9jcyAqcmluZykKPiAgCX0KPiAgCj4gIAlscmNfZGVzdHJveV93YV9jdHhfb2JqKHJpbmcpOwo+ ICsJcmluZy0+ZGV2ID0gTlVMTDsKPiAgfQo+ICAKPiAgc3RhdGljIGludCBsb2dpY2FsX3Jpbmdf aW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5n KQo+IEBAIC0xOTMxLDExICsxOTM0LDExIEBAIHN0YXRpYyBpbnQgbG9naWNhbF9yaW5nX2luaXQo c3RydWN0IGRybV9kZXZpY2UgKmRldiwgc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluCj4gIAo+ ICAJcmV0ID0gaTkxNV9jbWRfcGFyc2VyX2luaXRfcmluZyhyaW5nKTsKPiAgCWlmIChyZXQpCj4g LQkJcmV0dXJuIHJldDsKPiArCQlnb3RvIGVycm9yOwo+ICAKPiAgCXJldCA9IGludGVsX2xyX2Nv bnRleHRfZGVmZXJyZWRfYWxsb2MocmluZy0+ZGVmYXVsdF9jb250ZXh0LCByaW5nKTsKPiAgCWlm IChyZXQpCj4gLQkJcmV0dXJuIHJldDsKPiArCQlnb3RvIGVycm9yOwo+ICAKPiAgCS8qIEFzIHRo aXMgaXMgdGhlIGRlZmF1bHQgY29udGV4dCwgYWx3YXlzIHBpbiBpdCAqLwo+ICAJcmV0ID0gaW50 ZWxfbHJfY29udGV4dF9kb19waW4oCj4gQEAgLTE5NDYsOSArMTk0OSwxMyBAQCBzdGF0aWMgaW50 IGxvZ2ljYWxfcmluZ19pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdCBpbnRlbF9l bmdpbmVfY3MgKnJpbgo+ICAJCURSTV9FUlJPUigKPiAgCQkJIkZhaWxlZCB0byBwaW4gYW5kIG1h cCByaW5nYnVmZmVyICVzOiAlZFxuIiwKPiAgCQkJcmluZy0+bmFtZSwgcmV0KTsKPiAtCQlyZXR1 cm4gcmV0Owo+ICsJCWdvdG8gZXJyb3I7Cj4gIAl9Cj4gIAo+ICsJcmV0dXJuIDA7Cj4gKwo+ICtl cnJvcjoKPiArCWludGVsX2xvZ2ljYWxfcmluZ19jbGVhbnVwKHJpbmcpOwo+ICAJcmV0dXJuIHJl dDsKPiAgfQo+ICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmlu Z2J1ZmZlci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4gaW5k ZXggNTdkNzhmMi4uOTIxYzhhNiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9yaW5nYnVmZmVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5n YnVmZmVyLmMKPiBAQCAtMzMsMjMgKzMzLDYgQEAKPiAgI2luY2x1ZGUgImk5MTVfdHJhY2UuaCIK PiAgI2luY2x1ZGUgImludGVsX2Rydi5oIgo+ICAKPiAtYm9vbAo+IC1pbnRlbF9yaW5nX2luaXRp YWxpemVkKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcpCj4gLXsKPiAtCXN0cnVjdCBkcm1f ZGV2aWNlICpkZXYgPSByaW5nLT5kZXY7Cj4gLQo+IC0JaWYgKCFkZXYpCj4gLQkJcmV0dXJuIGZh bHNlOwo+IC0KPiAtCWlmIChpOTE1LmVuYWJsZV9leGVjbGlzdHMpIHsKPiAtCQlzdHJ1Y3QgaW50 ZWxfY29udGV4dCAqZGN0eCA9IHJpbmctPmRlZmF1bHRfY29udGV4dDsKPiAtCQlzdHJ1Y3QgaW50 ZWxfcmluZ2J1ZmZlciAqcmluZ2J1ZiA9IGRjdHgtPmVuZ2luZVtyaW5nLT5pZF0ucmluZ2J1ZjsK PiAtCj4gLQkJcmV0dXJuIHJpbmdidWYtPm9iajsKPiAtCX0gZWxzZQo+IC0JCXJldHVybiByaW5n LT5idWZmZXIgJiYgcmluZy0+YnVmZmVyLT5vYmo7Cj4gLX0KPiAtCj4gIGludCBfX2ludGVsX3Jp bmdfc3BhY2UoaW50IGhlYWQsIGludCB0YWlsLCBpbnQgc2l6ZSkKPiAgewo+ICAJaW50IHNwYWNl ID0gaGVhZCAtIHRhaWw7Cj4gQEAgLTIxNjcsOCArMjE1MCwxMCBAQCBzdGF0aWMgaW50IGludGVs X2luaXRfcmluZ19idWZmZXIoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCWluaXRfd2FpdHF1 ZXVlX2hlYWQoJnJpbmctPmlycV9xdWV1ZSk7Cj4gIAo+ICAJcmluZ2J1ZiA9IGludGVsX2VuZ2lu ZV9jcmVhdGVfcmluZ2J1ZmZlcihyaW5nLCAzMiAqIFBBR0VfU0laRSk7Cj4gLQlpZiAoSVNfRVJS KHJpbmdidWYpKQo+IC0JCXJldHVybiBQVFJfRVJSKHJpbmdidWYpOwo+ICsJaWYgKElTX0VSUihy aW5nYnVmKSkgewo+ICsJCXJldCA9IFBUUl9FUlIocmluZ2J1Zik7Cj4gKwkJZ290byBlcnJvcjsK PiArCX0KPiAgCXJpbmctPmJ1ZmZlciA9IHJpbmdidWY7Cj4gIAo+ICAJaWYgKEk5MTVfTkVFRF9H RlhfSFdTKGRldikpIHsKPiBAQCAtMjE5Nyw4ICsyMTgyLDcgQEAgc3RhdGljIGludCBpbnRlbF9p bml0X3JpbmdfYnVmZmVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAlyZXR1cm4gMDsKPiAg Cj4gIGVycm9yOgo+IC0JaW50ZWxfcmluZ2J1ZmZlcl9mcmVlKHJpbmdidWYpOwo+IC0JcmluZy0+ YnVmZmVyID0gTlVMTDsKPiArCWludGVsX2NsZWFudXBfcmluZ19idWZmZXIocmluZyk7Cj4gIAly ZXR1cm4gcmV0Owo+ICB9Cj4gIAo+IEBAIC0yMjExLDEyICsyMTk1LDE0IEBAIHZvaWQgaW50ZWxf Y2xlYW51cF9yaW5nX2J1ZmZlcihzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nKQo+ICAKPiAg CWRldl9wcml2ID0gdG9faTkxNShyaW5nLT5kZXYpOwo+ICAKPiAtCWludGVsX3N0b3BfcmluZ19i dWZmZXIocmluZyk7Cj4gLQlXQVJOX09OKCFJU19HRU4yKHJpbmctPmRldikgJiYgKEk5MTVfUkVB RF9NT0RFKHJpbmcpICYgTU9ERV9JRExFKSA9PSAwKTsKPiArCWlmIChyaW5nLT5idWZmZXIpIHsK PiArCQlpbnRlbF9zdG9wX3JpbmdfYnVmZmVyKHJpbmcpOwo+ICsJCVdBUk5fT04oIUlTX0dFTjIo cmluZy0+ZGV2KSAmJiAoSTkxNV9SRUFEX01PREUocmluZykgJiBNT0RFX0lETEUpID09IDApOwo+ ICAKPiAtCWludGVsX3VucGluX3JpbmdidWZmZXJfb2JqKHJpbmctPmJ1ZmZlcik7Cj4gLQlpbnRl bF9yaW5nYnVmZmVyX2ZyZWUocmluZy0+YnVmZmVyKTsKPiAtCXJpbmctPmJ1ZmZlciA9IE5VTEw7 Cj4gKwkJaW50ZWxfdW5waW5fcmluZ2J1ZmZlcl9vYmoocmluZy0+YnVmZmVyKTsKPiArCQlpbnRl bF9yaW5nYnVmZmVyX2ZyZWUocmluZy0+YnVmZmVyKTsKPiArCQlyaW5nLT5idWZmZXIgPSBOVUxM Owo+ICsJfQo+ICAKPiAgCWlmIChyaW5nLT5jbGVhbnVwKQo+ICAJCXJpbmctPmNsZWFudXAocmlu Zyk7Cj4gQEAgLTIyMjUsNiArMjIxMSw3IEBAIHZvaWQgaW50ZWxfY2xlYW51cF9yaW5nX2J1ZmZl cihzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nKQo+ICAKPiAgCWk5MTVfY21kX3BhcnNlcl9m aW5pX3JpbmcocmluZyk7Cj4gIAlpOTE1X2dlbV9iYXRjaF9wb29sX2ZpbmkoJnJpbmctPmJhdGNo X3Bvb2wpOwo+ICsJcmluZy0+ZGV2ID0gTlVMTDsKPiAgfQo+ICAKPiAgc3RhdGljIGludCByaW5n X3dhaXRfZm9yX3NwYWNlKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcsIGludCBuKQo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmggYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgKPiBpbmRleCA1ZDFlYjIwLi40OTU3 NGZmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIu aAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaAo+IEBAIC0z NTAsNyArMzUwLDExIEBAIHN0cnVjdCAgaW50ZWxfZW5naW5lX2NzIHsKPiAgCXUzMiAoKmdldF9j bWRfbGVuZ3RoX21hc2spKHUzMiBjbWRfaGVhZGVyKTsKPiAgfTsKPiAgCj4gLWJvb2wgaW50ZWxf cmluZ19pbml0aWFsaXplZChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nKTsKPiArc3RhdGlj IGlubGluZSBib29sCj4gK2ludGVsX3JpbmdfaW5pdGlhbGl6ZWQoc3RydWN0IGludGVsX2VuZ2lu ZV9jcyAqcmluZykKPiArewo+ICsJcmV0dXJuIHJpbmctPmRldiAhPSBOVUxMOwo+ICt9Cj4gIAo+ ICBzdGF0aWMgaW5saW5lIHVuc2lnbmVkCj4gIGludGVsX3JpbmdfZmxhZyhzdHJ1Y3QgaW50ZWxf ZW5naW5lX2NzICpyaW5nKQo+IC0tIAo+IDEuOS4xCj4gCj4gCj4gX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4g SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3 YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=