Re: [Qemu-devel] [PATCH 04/12] etraxfs_eth: Don't use hw_error() in init() method

From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 04/12] etraxfs_eth: Don't use hw_error() in init() method
Date: Thu, 10 Dec 2015 11:32:50 +0100	[thread overview]
Message-ID: <20151210103250.GA17020@toto> (raw)
In-Reply-To: <1449743372-17169-5-git-send-email-armbru@redhat.com>

On Thu, Dec 10, 2015 at 11:29:24AM +0100, Markus Armbruster wrote:
> Device init() methods aren't supposed to call hw_error(), they should
> report the error and fail cleanly.  Do that.
> 
> Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>

> ---
>  hw/net/etraxfs_eth.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/net/etraxfs_eth.c b/hw/net/etraxfs_eth.c
> index d600275..b562ac9 100644
> --- a/hw/net/etraxfs_eth.c
> +++ b/hw/net/etraxfs_eth.c
> @@ -26,6 +26,7 @@
>  #include "hw/sysbus.h"
>  #include "net/net.h"
>  #include "hw/cris/etraxfs.h"
> +#include "qemu/error-report.h"
>  
>  #define D(x)
>  
> @@ -589,7 +590,8 @@ static int fs_eth_init(SysBusDevice *sbd)
>      ETRAXFSEthState *s = ETRAX_FS_ETH(dev);
>  
>      if (!s->dma_out || !s->dma_in) {
> -        hw_error("Unconnected ETRAX-FS Ethernet MAC.\n");
> +        error_report("Unconnected ETRAX-FS Ethernet MAC");
> +        return -1;
>      }
>  
>      s->dma_out->client.push = eth_tx_push;
> -- 
> 2.4.3
> 