From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH 4/9] dmaengine: pl330: add new items for pl330 private data Date: Fri, 11 Dec 2015 14:59:10 +0530 Message-ID: <20151211092909.GW1854@localhost> References: <1449199466-6081-1-git-send-email-annie.wang@amd.com> <1449199466-6081-5-git-send-email-annie.wang@amd.com> <20151210040909.GM1854@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Wang, Annie" Cc: "Li, Tony" , "Wan, Vincent" , Greg Kroah-Hartman , "Rafael J. Wysocki" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , "Huang, Ray" , Borislav Petkov , "linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Mika Westerberg , "Xue, Ken" List-Id: linux-acpi@vger.kernel.org On Thu, Dec 10, 2015 at 06:38:09AM +0000, Wang, Annie wrote: > > > >Why not DT or ACPI for this? > > > We choose to use private data, as pl330 already has struct dma_pl330_platdata. > Physically DMA share ACPI device with UART, however, BIOS believes DMA and UART is one device. > We can't get irq share info from ACPI. And we don't use DT. > That should be then a MFD device -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754617AbbLKJ0d (ORCPT ); Fri, 11 Dec 2015 04:26:33 -0500 Received: from mga02.intel.com ([134.134.136.20]:43853 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751395AbbLKJ02 (ORCPT ); Fri, 11 Dec 2015 04:26:28 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,412,1444719600"; d="scan'208";a="858693214" Date: Fri, 11 Dec 2015 14:59:10 +0530 From: Vinod Koul To: "Wang, Annie" Cc: Mika Westerberg , Joerg Roedel , Greg Kroah-Hartman , "Rafael J. Wysocki" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-serial@vger.kernel.org" , "dmaengine@vger.kernel.org" , "iommu@lists.linux-foundation.org" , Borislav Petkov , "Huang, Ray" , "Wan, Vincent" , "Xue, Ken" , "Li, Tony" Subject: Re: [PATCH 4/9] dmaengine: pl330: add new items for pl330 private data Message-ID: <20151211092909.GW1854@localhost> References: <1449199466-6081-1-git-send-email-annie.wang@amd.com> <1449199466-6081-5-git-send-email-annie.wang@amd.com> <20151210040909.GM1854@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 10, 2015 at 06:38:09AM +0000, Wang, Annie wrote: > > > >Why not DT or ACPI for this? > > > We choose to use private data, as pl330 already has struct dma_pl330_platdata. > Physically DMA share ACPI device with UART, however, BIOS believes DMA and UART is one device. > We can't get irq share info from ACPI. And we don't use DT. > That should be then a MFD device -- ~Vinod