From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Fri, 11 Dec 2015 15:21:04 +0100
Subject: [U-Boot] [PATCH 1/6] arm: socfpga: cyclone5-socdk: Enabling mtd
	partitioning layout
In-Reply-To: <1449825353-2568-1-git-send-email-clsee@altera.com>
References: <1449825353-2568-1-git-send-email-clsee@altera.com>
Message-ID: <201512111521.05075.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Friday, December 11, 2015 at 10:15:48 AM, Chin Liang See wrote:
> Enabling mtd partitioning layout which indicate partition
> for various boot partition
> 
> Signed-off-by: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> Cc: Dinh Nguyen <dinh.linux@gmail.com>
> Cc: Pavel Machek <pavel@denx.de>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Stefan Roese <sr@denx.de>
> ---
>  include/configs/socfpga_cyclone5_socdk.h | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/include/configs/socfpga_cyclone5_socdk.h
> b/include/configs/socfpga_cyclone5_socdk.h index 67bb35f..e4a1657 100644
> --- a/include/configs/socfpga_cyclone5_socdk.h
> +++ b/include/configs/socfpga_cyclone5_socdk.h
> @@ -96,4 +96,16 @@
>  /* The rest of the configuration is shared */
>  #include <configs/socfpga_common.h>
> 
> +/* mtd partitioning for serial NOR flash */
> +#if defined(CONFIG_CMD_UBI) || defined(CONFIG_CMD_SF)

Is this the default Altera layout ?

> +#define MTDPARTS_DEFAULT	"mtdparts=ff705000.spi:"\
> +				"256k(spl),"		\
> +				"64k(env),"		\
> +				"64k(dtb),"		\

What happens if the DT grows over 64k ?

> +				"256k(boot),"		\

256k is not enough for U-Boot (considering this is U-Boot).

> +				"16m(kernel),"		\
> +				"16m(rootfs),"		\

Why don't you put kernel and rootfs onto the UBI volume instead ?

> +				"-(UBI)\0"
> +#endif
> +
>  #endif	/* __CONFIG_SOCFPGA_CYCLONE5_H__ */
> --
> 1.9.2.468.g3f0c02a

Best regards,
Marek Vasut