From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2] drm/i915: Fix context/engine cleanup order Date: Fri, 11 Dec 2015 17:26:19 +0100 Message-ID: <20151211162619.GD20822@phenom.ffwll.local> References: <1449845949-4161-1-git-send-email-nicholas.hoath@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by gabe.freedesktop.org (Postfix) with ESMTPS id BF78C6E01F for ; Fri, 11 Dec 2015 08:26:23 -0800 (PST) Received: by mail-wm0-f53.google.com with SMTP id c17so17836358wmd.1 for ; Fri, 11 Dec 2015 08:26:23 -0800 (PST) Content-Disposition: inline In-Reply-To: <1449845949-4161-1-git-send-email-nicholas.hoath@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Nick Hoath Cc: intel-gfx@lists.freedesktop.org, Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBEZWMgMTEsIDIwMTUgYXQgMDI6NTk6MDlQTSArMDAwMCwgTmljayBIb2F0aCB3cm90 ZToKPiBTd2FwIHRoZSBvcmRlciBvZiBjb250ZXh0ICYgZW5naW5lIGNsZWFudXAsIHNvIHRoYXQg aXQgaXMgbm93Cj4gY29udGV4dHMsIHRoZW4gZW5naW5lcy4KPiBUaGlzIGFsbG93cyB0aGUgY29u dGV4dCBjbGVhbiB1cCBjb2RlIHRvIGRvIHRoaW5ncyBsaWtlIGNvbmZpcm0KPiB0aGF0IHJpbmct PmRldi0+c3RydWN0X211dGV4IGlzIGxvY2tlZCB3aXRob3V0IGEgTlVMTCBwb2ludGVyCj4gZGVy ZWZlcmVuY2UuCj4gVGhpcyBjYW1lIGFib3V0IGFzIGEgcmVzdWx0IG9mIHRoZSAnaW50ZWxfcmlu Z19pbml0aWFsaXplZCgpIG11c3QKPiBiZSBzaW1wbGUgYW5kIGlubGluZScgcGF0Y2ggbm93IHVz aW5nIHJpbmctPmRldiBhcyBhbiBpbml0aWFsaXNlZAo+IGZsYWcuCj4gUmVuYW1lIHRoZSBjbGVh bnVwIGZ1bmN0aW9uIHRvIHJlZmxlY3Qgd2hhdCBpdCBhY3R1YWxseSBkb2VzLgo+IEFsc28gY2xl YW4gdXAgc29tZSB2ZXJ5IGFubm95aW5nIHdoaXRlc3BhY2UgaXNzdWVzIGF0IHRoZSBzYW1lIHRp bWUuCj4gCj4gdjI6IEFsc28gbWFrZSB0aGUgZml4IGluIGk5MTVfbG9hZF9tb2Rlc2V0X2luaXQs IG5vdCBqdXN0Cj4gICAgIGluIGk5MTVfZHJpdmVyX3VubG9hZCAoQ2hyaXMgV2lsc29uKQo+IAo+ IFNpZ25lZC1vZmYtYnk6IE5pY2sgSG9hdGggPG5pY2hvbGFzLmhvYXRoQGludGVsLmNvbT4KPiBS ZXZpZXdlZC1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gCj4g Q2M6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFAbGludXguaW50ZWwuY29tPgo+IENjOiBE YW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IENjOiBEYXZpZCBHb3Jkb24g PGRhdmlkLnMuZ29yZG9uQGludGVsLmNvbT4KPiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJp cy13aWxzb24uY28udWs+CgpRdWV1ZWQgZm9yIC1uZXh0LCB0aGFua3MgZm9yIHRoZSBwYXRjaC4K LURhbmllbAoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kbWEuYyB8ICA0ICsr LS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCB8ICAyICstCj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgfCAyMyArKysrKysrKysrKystLS0tLS0tLS0tLQo+ICAz IGZpbGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygtKQo+IAo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RtYS5jIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kbWEuYwo+IGluZGV4IDg0ZTJiMjAuLjRkYWQxMjEgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kbWEuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZG1hLmMKPiBAQCAtNDQ5LDggKzQ0OSw4IEBAIHN0YXRpYyBpbnQgaTkxNV9s b2FkX21vZGVzZXRfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAKPiAgY2xlYW51cF9n ZW06Cj4gIAltdXRleF9sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4gLQlpOTE1X2dlbV9jbGVh bnVwX3JpbmdidWZmZXIoZGV2KTsKPiAgCWk5MTVfZ2VtX2NvbnRleHRfZmluaShkZXYpOwo+ICsJ aTkxNV9nZW1fY2xlYW51cF9lbmdpbmVzKGRldik7Cj4gIAltdXRleF91bmxvY2soJmRldi0+c3Ry dWN0X211dGV4KTsKPiAgY2xlYW51cF9pcnE6Cj4gIAlpbnRlbF9ndWNfdWNvZGVfZmluaShkZXYp Owo+IEBAIC0xMTg4LDggKzExODgsOCBAQCBpbnQgaTkxNV9kcml2ZXJfdW5sb2FkKHN0cnVjdCBk cm1fZGV2aWNlICpkZXYpCj4gIAo+ICAJaW50ZWxfZ3VjX3Vjb2RlX2ZpbmkoZGV2KTsKPiAgCW11 dGV4X2xvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiAtCWk5MTVfZ2VtX2NsZWFudXBfcmluZ2J1 ZmZlcihkZXYpOwo+ICAJaTkxNV9nZW1fY29udGV4dF9maW5pKGRldik7Cj4gKwlpOTE1X2dlbV9j bGVhbnVwX2VuZ2luZXMoZGV2KTsKPiAgCW11dGV4X3VubG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgp Owo+ICAJaW50ZWxfZmJjX2NsZWFudXBfY2ZiKGRldl9wcml2KTsKPiAgCWk5MTVfZ2VtX2NsZWFu dXBfc3RvbGVuKGRldik7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf ZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gaW5kZXggNWVkZDM5My4u ZTMxN2Y4OCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+IEBAIC0zMDE2LDcgKzMwMTYs NyBAQCBpbnQgaTkxNV9nZW1faW5pdF9yaW5ncyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPiAg aW50IF9fbXVzdF9jaGVjayBpOTE1X2dlbV9pbml0X2h3KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYp Owo+ICBpbnQgaTkxNV9nZW1fbDNfcmVtYXAoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpy ZXEsIGludCBzbGljZSk7Cj4gIHZvaWQgaTkxNV9nZW1faW5pdF9zd2l6emxpbmcoc3RydWN0IGRy bV9kZXZpY2UgKmRldik7Cj4gLXZvaWQgaTkxNV9nZW1fY2xlYW51cF9yaW5nYnVmZmVyKHN0cnVj dCBkcm1fZGV2aWNlICpkZXYpOwo+ICt2b2lkIGk5MTVfZ2VtX2NsZWFudXBfZW5naW5lcyhzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2KTsKPiAgaW50IF9fbXVzdF9jaGVjayBpOTE1X2dwdV9pZGxlKHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+ICBpbnQgX19tdXN0X2NoZWNrIGk5MTVfZ2VtX3N1c3Bl bmQoc3RydWN0IGRybV9kZXZpY2UgKmRldik7Cj4gIHZvaWQgX19pOTE1X2FkZF9yZXF1ZXN0KHN0 cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxLAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+ IGluZGV4IDhlMmFjZGUuLjA0YTIyZGIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9nZW0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiBA QCAtNDgyMyw3ICs0ODIzLDcgQEAgaTkxNV9nZW1faW5pdF9odyhzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2KQo+ICAKPiAgCQlyZXQgPSBpOTE1X2dlbV9yZXF1ZXN0X2FsbG9jKHJpbmcsIHJpbmctPmRl ZmF1bHRfY29udGV4dCwgJnJlcSk7Cj4gIAkJaWYgKHJldCkgewo+IC0JCQlpOTE1X2dlbV9jbGVh bnVwX3JpbmdidWZmZXIoZGV2KTsKPiArCQkJaTkxNV9nZW1fY2xlYW51cF9lbmdpbmVzKGRldik7 Cj4gIAkJCWdvdG8gb3V0Owo+ICAJCX0KPiAgCj4gQEAgLTQ4MzYsNyArNDgzNiw3IEBAIGk5MTVf Z2VtX2luaXRfaHcoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgCQlpZiAocmV0ICYmIHJldCAh PSAtRUlPKSB7Cj4gIAkJCURSTV9FUlJPUigiUFBHVFQgZW5hYmxlIHJpbmcgIyVkIGZhaWxlZCAl ZFxuIiwgaSwgcmV0KTsKPiAgCQkJaTkxNV9nZW1fcmVxdWVzdF9jYW5jZWwocmVxKTsKPiAtCQkJ aTkxNV9nZW1fY2xlYW51cF9yaW5nYnVmZmVyKGRldik7Cj4gKwkJCWk5MTVfZ2VtX2NsZWFudXBf ZW5naW5lcyhkZXYpOwo+ICAJCQlnb3RvIG91dDsKPiAgCQl9Cj4gIAo+IEBAIC00ODQ0LDcgKzQ4 NDQsNyBAQCBpOTE1X2dlbV9pbml0X2h3KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gIAkJaWYg KHJldCAmJiByZXQgIT0gLUVJTykgewo+ICAJCQlEUk1fRVJST1IoIkNvbnRleHQgZW5hYmxlIHJp bmcgIyVkIGZhaWxlZCAlZFxuIiwgaSwgcmV0KTsKPiAgCQkJaTkxNV9nZW1fcmVxdWVzdF9jYW5j ZWwocmVxKTsKPiAtCQkJaTkxNV9nZW1fY2xlYW51cF9yaW5nYnVmZmVyKGRldik7Cj4gKwkJCWk5 MTVfZ2VtX2NsZWFudXBfZW5naW5lcyhkZXYpOwo+ICAJCQlnb3RvIG91dDsKPiAgCQl9Cj4gIAo+ IEBAIC00OTE5LDcgKzQ5MTksNyBAQCBvdXRfdW5sb2NrOgo+ICB9Cj4gIAo+ICB2b2lkCj4gLWk5 MTVfZ2VtX2NsZWFudXBfcmluZ2J1ZmZlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICtpOTE1 X2dlbV9jbGVhbnVwX2VuZ2luZXMoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgewo+ICAJc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiAgCXN0 cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmc7Cj4gQEAgLTQ5MjgsMTMgKzQ5MjgsMTQgQEAgaTkx NV9nZW1fY2xlYW51cF9yaW5nYnVmZmVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gIAlmb3Jf ZWFjaF9yaW5nKHJpbmcsIGRldl9wcml2LCBpKQo+ICAJCWRldl9wcml2LT5ndC5jbGVhbnVwX3Jp bmcocmluZyk7Cj4gIAo+IC0gICAgaWYgKGk5MTUuZW5hYmxlX2V4ZWNsaXN0cykKPiAtICAgICAg ICAgICAgLyoKPiAtICAgICAgICAgICAgICogTmVpdGhlciB0aGUgQklPUywgb3Vyc2VsdmVzIG9y IGFueSBvdGhlciBrZXJuZWwKPiAtICAgICAgICAgICAgICogZXhwZWN0cyB0aGUgc3lzdGVtIHRv IGJlIGluIGV4ZWNsaXN0cyBtb2RlIG9uIHN0YXJ0dXAsCj4gLSAgICAgICAgICAgICAqIHNvIHdl IG5lZWQgdG8gcmVzZXQgdGhlIEdQVSBiYWNrIHRvIGxlZ2FjeSBtb2RlLgo+IC0gICAgICAgICAg ICAgKi8KPiAtICAgICAgICAgICAgaW50ZWxfZ3B1X3Jlc2V0KGRldik7Cj4gKwlpZiAoaTkxNS5l bmFibGVfZXhlY2xpc3RzKSB7Cj4gKwkJLyoKPiArCQkgKiBOZWl0aGVyIHRoZSBCSU9TLCBvdXJz ZWx2ZXMgb3IgYW55IG90aGVyIGtlcm5lbAo+ICsJCSAqIGV4cGVjdHMgdGhlIHN5c3RlbSB0byBi ZSBpbiBleGVjbGlzdHMgbW9kZSBvbiBzdGFydHVwLAo+ICsJCSAqIHNvIHdlIG5lZWQgdG8gcmVz ZXQgdGhlIEdQVSBiYWNrIHRvIGxlZ2FjeSBtb2RlLgo+ICsJCSAqLwo+ICsJCWludGVsX2dwdV9y ZXNldChkZXYpOwo+ICsJfQo+ICB9Cj4gIAo+ICBzdGF0aWMgdm9pZAo+IC0tIAo+IDEuOS4xCj4g CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24K aHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK