From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] RFC: split PM workarounds into separate lib
Date: Fri, 11 Dec 2015 18:03:30 +0100 [thread overview]
Message-ID: <20151211170330.GI20822@phenom.ffwll.local> (raw)
In-Reply-To: <20151210160128.GB6509@boom>
On Thu, Dec 10, 2015 at 06:01:28PM +0200, David Weinehall wrote:
> On Tue, Dec 08, 2015 at 03:42:27PM +0200, Ville Syrjälä wrote:
> > On Tue, Dec 08, 2015 at 10:50:39AM +0200, David Weinehall wrote:
> > > Since the defaults for some external power management related settings
> > > prevents us from testing our power management functionality properly,
> > > we have to work around it. Currently this is done from the individual
> > > test cases, but this is sub-optimal. This patch moves the PM-related
> > > workarounds into a separate library, and adds some code to restore the
> > > previous settings for the SATA link power management while at it.
> >
> > Why is it called "workarounds"? That gives me the impression we're
> > working around something that's supposed to work but doesn't. That's not
> > the case here.
>
> Workarounds was because we are working around "imperfect" settings
> in other components. At least to me power management should be enabled
> out of the box, not something that requires admin-level workarounds.
> Since we're not in control of said defaults, we have to modify the
> settings when we run our tests, hence workarounds.
Fully agreed that power tuning should be applied by default, but that's a
loooooong process to convince all the other kernel maintainers. And we
need to get our own house in order first too, but that's in progress.
> That said, as I've replied to a later post, igt_pm is fine by me.
One more: Please namespace all the library functions you're adding and
exporting to tests with igt_pm_. Static/internal functions can still be
named however you feel like.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-12-11 17:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 8:50 [PATCH i-g-t] RFC: split PM workarounds into separate lib David Weinehall
2015-12-08 8:50 ` [PATCH i-g-t] lib/pm_workarounds: Lib for PM workarounds David Weinehall
2015-12-08 13:22 ` [PATCH i-g-t] RFC: split PM workarounds into separate lib Zanoni, Paulo R
2015-12-10 16:05 ` David Weinehall
2015-12-08 13:42 ` Ville Syrjälä
2015-12-08 19:05 ` Paulo Zanoni
2015-12-10 10:09 ` Daniel Vetter
2015-12-10 15:55 ` David Weinehall
2015-12-10 16:01 ` David Weinehall
2015-12-11 17:03 ` Daniel Vetter [this message]
2015-12-15 9:14 ` [PATCH i-g-t v2] Add a lib for power management helpers David Weinehall
2015-12-15 9:14 ` [PATCH i-g-t] lib/igt_pm: Lib for power management David Weinehall
2015-12-18 19:27 ` Thomas Wood
2016-02-11 7:25 ` [PATCH v3 0/1] Add a lib for power management helpers David Weinehall
2016-02-11 7:25 ` [PATCH v3 1/1] lib/igt_pm: Lib for power management David Weinehall
2016-02-11 8:27 ` [PATCH v3 0/1] Add a lib for power management helpers Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151211170330.GI20822@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.