From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/6] arm: socfpga: de0-nano-soc: Enabling mtd partitioning layout
Date: Sat, 12 Dec 2015 22:45:58 +0100 [thread overview]
Message-ID: <201512122245.58506.marex@denx.de> (raw)
In-Reply-To: <20151212211000.GA21342@amd>
On Saturday, December 12, 2015 at 10:10:00 PM, Pavel Machek wrote:
> On Fri 2015-12-11 17:15:50, Chin Liang See wrote:
> > Enabling mtd partitioning layout which indicate partition
> > for various boot partition
> >
> > Signed-off-by: Chin Liang See <clsee@altera.com>
> > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > Cc: Dinh Nguyen <dinh.linux@gmail.com>
> > Cc: Pavel Machek <pavel@denx.de>
> > Cc: Marek Vasut <marex@denx.de>
> > Cc: Stefan Roese <sr@denx.de>
> > ---
> >
> > include/configs/socfpga_de0_nano_soc.h | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/include/configs/socfpga_de0_nano_soc.h
> > b/include/configs/socfpga_de0_nano_soc.h index 16e146c..c42175d 100644
> > --- a/include/configs/socfpga_de0_nano_soc.h
> > +++ b/include/configs/socfpga_de0_nano_soc.h
> > @@ -86,4 +86,16 @@
> >
> > /* The rest of the configuration is shared */
> > #include <configs/socfpga_common.h>
> >
> > +/* mtd partitioning for serial NOR flash */
> > +#if defined(CONFIG_CMD_UBI) || defined(CONFIG_CMD_SF)
> > +#define MTDPARTS_DEFAULT "mtdparts=ff705000.spi:"\
> > + "256k(spl)," \
> > + "64k(env)," \
> > + "64k(dtb)," \
> > + "256k(boot)," \
> > + "16m(kernel)," \
> > + "16m(rootfs)," \
> > + "-(UBI)\0"
> > +#endif
> > +
> >
> > #endif /* __CONFIG_TERASIC_DE0_H__ */
>
> Ok, three copies of the same table. Should it go to socfpga common?
> You could at least do
>
> MTDPARTS_DEFAULT_SOCDK
>
> and then use
>
> #define MTDPARTS_DEFAULT MTDPARTS_DEFAULT_SOCDK
>
> in the socfpga_de0_nano_soc.h, so we don't have 3 copies of the same
> table.
I'd rather suggest to do something like
#ifndef MTDPARTS_DEFAULT
#define ...
#endif
in socfpga_common.h . Even better would obviously be if we could just scrap
this altogether and parse the MTD layout from OF. I dunno if we can do that
nowadays, but that'd be great.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-12-12 21:45 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 9:15 [U-Boot] [PATCH 1/6] arm: socfpga: cyclone5-socdk: Enabling mtd partitioning layout Chin Liang See
2015-12-11 9:15 ` [U-Boot] [PATCH 2/6] arm: socfpga: arria5-socdk: " Chin Liang See
2015-12-11 9:15 ` [U-Boot] [PATCH 3/6] arm: socfpga: de0-nano-soc: " Chin Liang See
2015-12-11 14:21 ` Marek Vasut
2015-12-11 15:43 ` Dinh Nguyen
2015-12-11 17:36 ` Marek Vasut
2015-12-12 0:01 ` Chin Liang See
2015-12-12 21:10 ` Pavel Machek
2015-12-12 21:45 ` Marek Vasut [this message]
2015-12-13 0:01 ` Chin Liang See
2015-12-13 0:04 ` Chin Liang See
2015-12-11 9:15 ` [U-Boot] [PATCH 4/6] arm: socfpga: mcvevk: " Chin Liang See
2015-12-11 14:21 ` Marek Vasut
2015-12-11 9:15 ` [U-Boot] [PATCH 5/6] arm: socfpga: sockit: " Chin Liang See
2015-12-11 14:23 ` Marek Vasut
2015-12-11 9:15 ` [U-Boot] [PATCH 6/6] arm: socfpga: socrates: " Chin Liang See
2015-12-11 14:23 ` Marek Vasut
2015-12-11 14:21 ` [U-Boot] [PATCH 1/6] arm: socfpga: cyclone5-socdk: " Marek Vasut
2015-12-11 23:59 ` Chin Liang See
2015-12-12 3:20 ` Marek Vasut
2015-12-12 6:30 ` Chin Liang See
2015-12-12 15:36 ` Marek Vasut
2015-12-12 23:59 ` Chin Liang See
2015-12-13 0:01 ` Marek Vasut
2015-12-13 0:49 ` Chin Liang See
2015-12-13 3:14 ` Marek Vasut
2015-12-13 13:03 ` Chin Liang See
2015-12-13 15:42 ` Marek Vasut
2015-12-14 0:11 ` Chin Liang See
2015-12-14 0:22 ` Marek Vasut
2015-12-14 0:43 ` Chin Liang See
2015-12-14 0:58 ` Marek Vasut
2015-12-14 1:22 ` Chin Liang See
2015-12-14 1:25 ` Marek Vasut
2015-12-14 15:22 ` Chin Liang See
2015-12-15 0:32 ` Marek Vasut
2015-12-15 1:09 ` Chin Liang See
2015-12-15 1:15 ` Marek Vasut
2015-12-15 10:09 ` Chin Liang See
2015-12-15 18:16 ` Marek Vasut
2015-12-18 9:39 ` Chin Liang See
2015-12-18 13:10 ` Marek Vasut
2015-12-22 15:49 ` Chin Liang See
2015-12-22 15:53 ` Marek Vasut
2015-12-22 16:00 ` Chin Liang See
2015-12-22 20:10 ` Marek Vasut
2015-12-23 0:24 ` Chin Liang See
2015-12-23 0:48 ` Marek Vasut
2015-12-23 1:38 ` Chin Liang See
2015-12-23 19:02 ` Pavel Machek
2015-12-23 22:57 ` Chin Liang See
2015-12-23 23:16 ` Marek Vasut
2015-12-23 23:36 ` Chin Liang See
2015-12-24 1:30 ` Marek Vasut
2015-12-28 8:51 ` Chin Liang See
2015-12-28 12:39 ` Marek Vasut
2015-12-29 21:06 ` Chin Liang See
2015-12-29 21:20 ` Marek Vasut
2015-12-23 23:18 ` Marek Vasut
2015-12-14 7:54 ` Pavel Machek
2015-12-14 11:09 ` Marek Vasut
2015-12-14 11:26 ` Pavel Machek
2015-12-14 11:31 ` Marek Vasut
2015-12-14 11:51 ` Pavel Machek
2015-12-14 12:20 ` Marek Vasut
2015-12-14 12:53 ` Pavel Machek
2015-12-14 13:34 ` Marek Vasut
2015-12-14 15:31 ` Chin Liang See
2015-12-13 0:49 ` Chin Liang See
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201512122245.58506.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.