All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Staging: iio: accel: Fixed NULL comparison style
@ 2015-12-13  9:54 Bhaktipriya Shridhar
  2015-12-13 11:07 ` Dan Carpenter
  0 siblings, 1 reply; 2+ messages in thread
From: Bhaktipriya Shridhar @ 2015-12-13  9:54 UTC (permalink / raw)
  To: jic23, knaack.h, lars, pmeerw, gregkh, ciorneiioana,
	cristina.moraru09, dan.carpenter, josselin.costanzi,
	bhaktipriya96
  Cc: linux-iio, devel, linux-kernel

This patch fixes checkpatch.pl check:
CHECK: Comparison to NULL could be written "!rx_p"
+       if (*rx_p == NULL) {

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
 drivers/staging/iio/accel/sca3000_ring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/accel/sca3000_ring.c b/drivers/staging/iio/accel/sca3000_ring.c
index 20b878d..5339b10 100644
--- a/drivers/staging/iio/accel/sca3000_ring.c
+++ b/drivers/staging/iio/accel/sca3000_ring.c
@@ -48,7 +48,7 @@ static int sca3000_read_data(struct sca3000_state *st,
 		}
 	};
 	*rx_p = kmalloc(len, GFP_KERNEL);
-	if (*rx_p == NULL) {
+	if (!rx_p) {
 		ret = -ENOMEM;
 		goto error_ret;
 	}
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Staging: iio: accel: Fixed NULL comparison style
  2015-12-13  9:54 [PATCH] Staging: iio: accel: Fixed NULL comparison style Bhaktipriya Shridhar
@ 2015-12-13 11:07 ` Dan Carpenter
  0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2015-12-13 11:07 UTC (permalink / raw)
  To: Bhaktipriya Shridhar, Joe Perches
  Cc: jic23, knaack.h, lars, pmeerw, gregkh, ciorneiioana,
	cristina.moraru09, josselin.costanzi, linux-iio, devel,
	linux-kernel

On Sun, Dec 13, 2015 at 12:54:27PM +0300, Bhaktipriya Shridhar wrote:
> This patch fixes checkpatch.pl check:
> CHECK: Comparison to NULL could be written "!rx_p"
> +       if (*rx_p == NULL) {
> 

Actually it should be "if (!*rx_p)".  checkpatch.pl appears to have a
bug here.

regards,
dan carpenter

> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> ---
>  drivers/staging/iio/accel/sca3000_ring.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/accel/sca3000_ring.c b/drivers/staging/iio/accel/sca3000_ring.c
> index 20b878d..5339b10 100644
> --- a/drivers/staging/iio/accel/sca3000_ring.c
> +++ b/drivers/staging/iio/accel/sca3000_ring.c
> @@ -48,7 +48,7 @@ static int sca3000_read_data(struct sca3000_state *st,
>  		}
>  	};
>  	*rx_p = kmalloc(len, GFP_KERNEL);
> -	if (*rx_p == NULL) {
> +	if (!rx_p) {
>  		ret = -ENOMEM;
>  		goto error_ret;
>  	}
> -- 
> 2.1.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-12-13 11:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-13  9:54 [PATCH] Staging: iio: accel: Fixed NULL comparison style Bhaktipriya Shridhar
2015-12-13 11:07 ` Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.