From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932326AbbLNLED (ORCPT ); Mon, 14 Dec 2015 06:04:03 -0500 Received: from mx2.suse.de ([195.135.220.15]:54061 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932140AbbLNLEB (ORCPT ); Mon, 14 Dec 2015 06:04:01 -0500 Date: Mon, 14 Dec 2015 12:03:58 +0100 From: Jan Kara To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Jan Kara Subject: Re: [PATCH 02/10] fs: make quota/netlink.c explicitly non-modular Message-ID: <20151214110358.GF8474@quack.suse.cz> References: <1449955812-10149-1-git-send-email-paul.gortmaker@windriver.com> <1449955812-10149-3-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449955812-10149-3-git-send-email-paul.gortmaker@windriver.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat 12-12-15 16:30:04, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > config QUOTA_NETLINK_INTERFACE > bool "Report quota messages through netlink interface" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the couple traces of modularity so that when reading the > driver there is no doubt it is builtin-only. > > Since module_init translates to device_initcall in the non-modular > case, the init ordering gets bumped to one level earlier when we > use the more appropriate fs_initcall here. However we've made similar > changes before without any fallout and none is expected here either. > > Cc: Jan Kara > Signed-off-by: Paul Gortmaker Looks good. I have taken the patch into my tree. Honza -- Jan Kara SUSE Labs, CR