From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752661AbbLNPQm (ORCPT <rfc822;w@1wt.eu>);
	Mon, 14 Dec 2015 10:16:42 -0500
Received: from mail.kernel.org ([198.145.29.136]:38163 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751832AbbLNPQl (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 14 Dec 2015 10:16:41 -0500
Date: Mon, 14 Dec 2015 12:16:36 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        linux-kernel@vger.kernel.org, Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH v3 01/17] perf build: Remove unnecessary line in
 Makefile.feature
Message-ID: <20151214151636.GJ6843@kernel.org>
References: <cover.1449965119.git.jpoimboe@redhat.com>
 <554a05c18af564ba015c9e68f25730126e0f4acb.1449965119.git.jpoimboe@redhat.com>
 <20151214100507.GC27640@krava.brq.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151214100507.GC27640@krava.brq.redhat.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Mon, Dec 14, 2015 at 11:05:07AM +0100, Jiri Olsa escreveu:
> On Sun, Dec 13, 2015 at 10:18:01PM -0600, Josh Poimboeuf wrote:
> > This line always silently fails because it doesn't add the 'test-'
> > prefix to the .bin file.
> > 
> > And it seems to be unnecessary anyway: the line immediately after it
> > does all the individual feature checks.
> > 
> > Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> > ---
> >  tools/build/Makefile.feature | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
> > index 37ff4c9..b8c31ec 100644
> > --- a/tools/build/Makefile.feature
> > +++ b/tools/build/Makefile.feature
> > @@ -101,7 +101,6 @@ ifeq ($(feature-all), 1)
> >    #
> >    $(foreach feat,$(FEATURE_TESTS),$(call feature_set,$(feat)))
> >  else
> > -  $(shell $(MAKE) OUTPUT=$(OUTPUT_FEATURES) CFLAGS="$(EXTRA_CFLAGS)" LDFLAGS=$(LDFLAGS) -i -j -C $(feature_dir) $(addsuffix .bin,$(FEATURE_TESTS)) >/dev/null 2>&1)
> >    $(foreach feat,$(FEATURE_TESTS),$(call feature_check,$(feat)))
> 
> ugh, nice ;-)
> 
> Acked-by: Jiri Olsa <jolsa@kernel.org>

Thanks, applied.