From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8kjj-0005sK-H3 for qemu-devel@nongnu.org; Tue, 15 Dec 2015 03:13:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8kjg-00075a-BO for qemu-devel@nongnu.org; Tue, 15 Dec 2015 03:13:31 -0500 Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]:38817) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8kjg-00075V-0L for qemu-devel@nongnu.org; Tue, 15 Dec 2015 03:13:28 -0500 Received: by mail-wm0-x232.google.com with SMTP id p66so13289621wmp.1 for ; Tue, 15 Dec 2015 00:13:27 -0800 (PST) Date: Tue, 15 Dec 2015 10:13:24 +0200 From: Shmulik Ladkani Message-ID: <20151215101324.6bb0356a@halley> In-Reply-To: <20151214202556-mutt-send-email-mst@redhat.com> References: <1449994112-7054-1-git-send-email-shmulik.ladkani@ravellosystems.com> <1449994112-7054-7-git-send-email-shmulik.ladkani@ravellosystems.com> <566EF753.4070605@redhat.com> <20151214190935-mutt-send-email-mst@redhat.com> <163895392.40236889.1450114130220.JavaMail.zimbra@redhat.com> <20151214193220-mutt-send-email-mst@redhat.com> <566F04B1.8070204@redhat.com> <20151214202556-mutt-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Dmitry Fleytman , Paolo Bonzini , idan brown , qemu-devel@nongnu.org, Marcel Apfelbaum Hi, On Mon, 14 Dec 2015 20:26:35 +0200 "Michael S. Tsirkin" wrote: > > > It's set internally by machine types to avoid breaking > > > migration. I don't see any reason for users to set it. > > > > But they do set it :) albeit only through machine types. I don't think > > it's different from offloads, just much more specialized. > > > > Or do you mean that it could go away if we decide to remove very old > > machine types? I think we would remove compat properties connected to > > those machine types as well, even without "x-". > > > > Then we'll break users who set them directly for some reason. > So x- means "not part of stable ABI". > No? BTW, different drivers use different naming approaches. E.g. d209c744 'hw/audio/intel-hda: Fix MSI capability address' suggests a "old_msi_addr" property (yes, underscores) for intel-hda. Michael, you were the reviewer ;-) Perhaps we can standartize that "c-" prefix denotes compat properties? Regards, Shmulik