From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8oA4-0004Fb-T8 for qemu-devel@nongnu.org; Tue, 15 Dec 2015 06:53:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8oA0-0000ro-TS for qemu-devel@nongnu.org; Tue, 15 Dec 2015 06:52:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8oA0-0000qm-Og for qemu-devel@nongnu.org; Tue, 15 Dec 2015 06:52:52 -0500 Date: Tue, 15 Dec 2015 11:52:44 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20151215115243.GE2500@work-vm> References: <1450167779-9960-1-git-send-email-zhang.zhanghailiang@huawei.com> <1450167779-9960-30-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450167779-9960-30-git-send-email-zhang.zhanghailiang@huawei.com> Subject: Re: [Qemu-devel] [PATCH COLO-Frame v12 29/38] COLO: Update the global runstate after going into colo state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang Cc: lizhijian@cn.fujitsu.com, quintela@redhat.com, yunhong.jiang@intel.com, eddie.dong@intel.com, peter.huangpeng@huawei.com, qemu-devel@nongnu.org, arei.gonglei@huawei.com, stefanha@redhat.com, amit.shah@redhat.com, hongyang.yang@easystack.cn * zhanghailiang (zhang.zhanghailiang@huawei.com) wrote: > If we start qemu with -S, the runstate will change from 'prelaunch' to 'running' > after going into colo state. > So it is necessary to update the global runstate after going into colo state. > > Signed-off-by: zhanghailiang > Signed-off-by: Li Zhijian Reviewed-by: Dr. David Alan Gilbert > --- > migration/colo.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/migration/colo.c b/migration/colo.c > index a094991..62a0444 100644 > --- a/migration/colo.c > +++ b/migration/colo.c > @@ -374,6 +374,11 @@ static void colo_process_checkpoint(MigrationState *s) > qemu_mutex_unlock_iothread(); > trace_colo_vm_state_change("stop", "run"); > > + ret = global_state_store(); > + if (ret < 0) { > + goto out; > + } > + > while (s->state == MIGRATION_STATUS_COLO) { > if (failover_request_is_active()) { > error_report("failover request"); > -- > 1.8.3.1 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK