All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Dec 2015, #05; Tue, 15)
Date: Tue, 15 Dec 2015 19:50:45 -0500	[thread overview]
Message-ID: <20151216005045.GA31433@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqq4mfjff9x.fsf@gitster.mtv.corp.google.com>

On Tue, Dec 15, 2015 at 03:44:42PM -0800, Junio C Hamano wrote:

> Junio C Hamano <gitster@pobox.com> writes:
> 
> > There already was strbuf_getline_crlf(), and I wanted a new name to
> > be conservative.
> 
> When I re-read the series, I realize that the existing one had
> exactly the same semantics as strbuf_gets(), so I think no risk
> would come from reusing that name.  Let me try redoing the series
> when I find time ;-)

Heh. I just made up that name, not realizing it existed. Looks like it
is fairly recent as part of builtin-am, which explains why I hadn't seen
it yet.

I agree it looks like it does what you want. Upon reading your first
message I thought "eh, did I totally misunderstand the intent of the
series?", but it looks like we are on the same page. :)

-Peff

  reply	other threads:[~2015-12-16  0:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-15 22:48 Junio C Hamano
2015-12-15 23:16 ` Stefan Beller
2015-12-15 23:32 ` Jeff King
2015-12-15 23:34   ` Junio C Hamano
2015-12-15 23:36   ` Junio C Hamano
2015-12-15 23:44     ` Junio C Hamano
2015-12-16  0:50       ` Jeff King [this message]
2015-12-16 15:58       ` Johannes Schindelin
2015-12-16  6:58 ` Torsten Bögershausen
2015-12-16 18:04   ` Junio C Hamano
2015-12-21 15:31     ` Torsten Bögershausen
2015-12-18 13:23 ` SZEDER Gábor
2015-12-21 16:54   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151216005045.GA31433@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --subject='Re: What'\''s cooking in git.git (Dec 2015, #05; Tue, 15)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.