Re: [PATCH] drm/i915: Move Braswell stop_machine GGTT insertion workaround

From: Chris Wilson <chris@chris-wilson.co.uk>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	intel-gfx@lists.freedesktop.org,
	Mika Kuoppala <mika.kuoppala@intel.com>
Subject: Re: [PATCH] drm/i915: Move Braswell stop_machine GGTT insertion workaround
Date: Wed, 16 Dec 2015 20:27:21 +0000	[thread overview]
Message-ID: <20151216202721.GF18452@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <20151216200229.GL4437@intel.com>

On Wed, Dec 16, 2015 at 10:02:29PM +0200, Ville Syrjälä wrote:
> On Wed, Nov 18, 2015 at 03:19:39PM +0000, Chris Wilson wrote:
> > +static void gen8_ggtt_insert_entries__BKL(struct i915_address_space *vm,
> > +					  struct sg_table *st,
> > +					  uint64_t start,
> > +					  enum i915_cache_level level,
> > +					  u32 flags)
> > +{
> > +	struct insert_entries arg = { vm, st, start, level, flags };
> 
> Could use named initializers to avoid potential accidents with the
> weaker typed members. But the struct definition is close by so not a
> huge risk.

struct insert_entries arg = { .vm=vm, .st=st, .start=start, .level=level, .flags=flags };

Hmm, I may just pass on that for the moment.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx