From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jones Subject: Re: [PATCH kvm-unit-tests v2 09/12] x86/hyperv_synic: check for support before testing Date: Thu, 17 Dec 2015 13:42:09 -0600 Message-ID: <20151217194209.GG14168@hawk.localdomain> References: <1450374823-7648-1-git-send-email-rkrcmar@redhat.com> <1450374823-7648-10-git-send-email-rkrcmar@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, Paolo Bonzini To: Radim =?utf-8?B?S3LEjW3DocWZ?= Return-path: Received: from mx1.redhat.com ([209.132.183.28]:53036 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753930AbbLQTmP (ORCPT ); Thu, 17 Dec 2015 14:42:15 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 2921232D3BB for ; Thu, 17 Dec 2015 19:42:15 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1450374823-7648-10-git-send-email-rkrcmar@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Dec 17, 2015 at 06:53:40PM +0100, Radim Kr=C4=8Dm=C3=A1=C5=99 w= rote: > It's not easy to distinguish successful unit-test from failed QEMU, s= o > we check for presence of the needed feature before hand. >=20 > Signed-off-by: Radim Kr=C4=8Dm=C3=A1=C5=99 > --- > v2: remove "> /dev/null" as check doesn't print the output anymore > =20 > x86/unittests.cfg | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/x86/unittests.cfg b/x86/unittests.cfg > index 6b94ad93dcf0..25779993cc27 100644 > --- a/x86/unittests.cfg > +++ b/x86/unittests.cfg > @@ -182,3 +182,4 @@ arch =3D x86_64 > file =3D hyperv_synic.flat > smp =3D 2 > extra_params =3D -cpu kvm64,hv_synic -device hyperv-testdev > +check =3D echo quit | $qemu -cpu kvm64,hv_synic -device hyperv-testd= ev -monitor stdio Let's make sure $QEMU=3D=3D$qemu in contexts where unittests.cfg is use= d, and then document (in the unittests.cfg header) that $QEMU may be used in t= he check lines. > --=20 > 2.6.4 >=20 > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html