All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon-2ukJVAZIZ/Y@public.gmane.org>
To: Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>
Cc: Hal Rosenstock
	<hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
	"ira.weiny" <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Jason Gunthorpe
	<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Subject: Re: [PATCH 3/3] bject: IB Core: Display extended counter set if available
Date: Thu, 17 Dec 2015 22:40:25 +0200	[thread overview]
Message-ID: <20151217204025.GA29716@leon.nu> (raw)
In-Reply-To: <20151217195312.334770847-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>

There are number of minor issues:
Subject: Re: [PATCH 3/3] bject: IB Core: Display extended counter set if
                        ^^^^^^^

On Thu, Dec 17, 2015 at 01:52:58PM -0600, Christoph Lameter wrote:
> -	in_mad->data[41] = port_num;	/* PortSelect field */
> +	if (port_num)
> +		in_mad->data[41] = port_num;	/* PortSelect field */
in_mad was created with kzalloc with all fields zeroed by default, so
you can drop if(port_num) condition.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2015-12-17 20:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-17 19:52 [PATCH 0/3] IB 64 bit counter support V2 Christoph Lameter
2015-12-17 19:52 ` [PATCH 1/3] IB Core: Create get_perf_mad function in sysfs.c Christoph Lameter
     [not found]   ` <20151217195312.126391272-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>
2015-12-17 20:12     ` Hal Rosenstock
     [not found]   ` <5684E027.4040006@sandisk.com>
     [not found]     ` <5684E027.4040006-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-04  3:47       ` ira.weiny
2015-12-17 19:52 ` [PATCH 2/3] IB core counters: Specify attribute_id in port_table_attribute Christoph Lameter
     [not found]   ` <20151217195312.228660904-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>
2015-12-17 20:12     ` Hal Rosenstock
2015-12-17 19:52 ` [PATCH 3/3] bject: IB Core: Display extended counter set if available Christoph Lameter
     [not found]   ` <20151217195312.334770847-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>
2015-12-17 20:11     ` Hal Rosenstock
     [not found]       ` <567316F7.9030707-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-12-17 21:28         ` Christoph Lameter
     [not found]           ` <alpine.DEB.2.20.1512171527060.22782-wcBtFHqTun5QOdAKl3ChDw@public.gmane.org>
2015-12-17 21:48             ` Hal Rosenstock
     [not found]               ` <56732D97.2080303-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-12-17 22:50                 ` Christoph Lameter
     [not found]                   ` <alpine.DEB.2.20.1512171649070.22782-wcBtFHqTun5QOdAKl3ChDw@public.gmane.org>
2015-12-17 23:19                     ` Hal Rosenstock
     [not found]                       ` <567342F5.5090000-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-12-18 13:39                         ` Christoph Lameter
     [not found]                           ` <alpine.DEB.2.20.1512180737150.32514-wcBtFHqTun5QOdAKl3ChDw@public.gmane.org>
2015-12-18 13:52                             ` Hal Rosenstock
     [not found]                               ` <56740F8C.4060703-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-12-18 15:46                                 ` Christoph Lameter
     [not found]                                   ` <alpine.DEB.2.20.1512180944540.1506-wcBtFHqTun5QOdAKl3ChDw@public.gmane.org>
2015-12-18 16:26                                     ` Hal Rosenstock
2015-12-17 20:40     ` Leon Romanovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151217204025.GA29716@leon.nu \
    --to=leon-2ukjvaziz/y@public.gmane.org \
    --cc=cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
    --cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.