From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] emlog:new package
Date: Thu, 17 Dec 2015 22:42:20 +0100 [thread overview]
Message-ID: <20151217214220.GF3653@free.fr> (raw)
In-Reply-To: <1449224567-14412-1-git-send-email-joris.lijssens@gmail.com>
Joris, All,
On 2015-12-04 11:22 +0100, Joris Lijssens spake thusly:
> Signed-off-by: Joris Lijssens <joris.lijssens@gmail.com>
> ---
[--SNIP--]
> diff --git a/package/emlog/emlog.mk b/package/emlog/emlog.mk
> new file mode 100644
> index 0000000..9264849
> --- /dev/null
> +++ b/package/emlog/emlog.mk
> @@ -0,0 +1,26 @@
> +################################################################################
> +#
> +# emlog
> +#
> +################################################################################
> +
> +EMLOG_VERSION = 0.52
> +EMLOG_SITE = $(call github,nicupavel,emlog,emlog-$(EMLOG_VERSION))
> +EMLOG_LICENSE = GPLv2
> +EMLOG_LICENSE_FILES = COPYING
> +
> +EMLOG_DEPENDENCIES = linux
> +
> +define EMLOG_BUILD_CMDS
> + $(MAKE) $(LINUX_MAKE_FLAGS) -C $(LINUX_DIR) M=$(@D) modules
> + $(MAKE) CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS)" -C $(@D) nbcat
> +endef
> +
> +define EMLOG_INSTALL_TARGET_CMDS
> + $(MAKE) $(LINUX_MAKE_FLAGS) -C $(LINUX_DIR) M=$(@D) \
> + INSTALL_MOD_STRIP=1 \
> + modules_install
> + $(INSTALL) -m 0755 $(@D)/nbcat $(TARGET_DIR)/usr/bin
> +endef
As far as I can see, this is using the standrad Linux out-of-tree
external module mechanism to build the emlog module. Buildroot has
an infrastructure to help write packages that build a kernel module:
https://buildroot.org/downloads/manual/manual.html#_infrastructure_for_packages_building_kernel_modules
Thomas and I believe emlog should use that kernel-module infra.
You just need to handle the nbcat userland utility with the
generic-package infra.
Care to update and respin, please?
In the meantime, I'm marking this patch as "Changes Requested" in our
Patchwork.
Thanks! :-)
> +$(eval $(generic-package))
> --
> 1.8.3.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-12-17 21:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 10:22 [Buildroot] [PATCH 1/1] emlog:new package Joris Lijssens
2015-12-17 21:42 ` Yann E. MORIN [this message]
2015-12-18 13:44 [Buildroot] [PATCH 1/1] emlog: new package Joris Lijssens
2015-12-18 16:07 ` Thomas Petazzoni
2015-12-20 16:06 ` Arnout Vandecappelle
2015-12-21 22:52 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151217214220.GF3653@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.