From: David Miller <davem@davemloft.net>
To: stephen@networkplumber.org
Cc: ben.hutchings@codethink.co.uk, ivecera@redhat.com,
linuxbrad@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] asix: silence log message from oversize packet
Date: Fri, 18 Dec 2015 21:25:14 -0500 (EST) [thread overview]
Message-ID: <20151218.212514.1288582729750012735.davem@davemloft.net> (raw)
In-Reply-To: <20151218161503.123b5171@xeon-e3>
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 18 Dec 2015 16:15:03 -0800
> On Fri, 18 Dec 2015 16:08:53 -0500 (EST)
> David Miller <davem@davemloft.net> wrote:
>
>> From: Stephen Hemminger <stephen@networkplumber.org>
>> Date: Thu, 17 Dec 2015 17:51:16 -0800
>>
>> > Since it is possible for an external system to send oversize packets
>> > at anytime, it is best for driver not to print a message and spam
>> > the log (potential external DoS).
>> >
>> > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=109471
>> >
>> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>>
>> Seems reasonable, applied, thanks Stephen.
>
> It doesn't fix the bug that is generating the oversize packet, that still needs
> to be root caused.
Remote systems can do this easily. It's not a bug in the driver.
Say you decrease the MTU to 500 or whatever, nothing in the hardware
prevents reception of > 500 byte frames.
It's only a software limit.
prev parent reply other threads:[~2015-12-19 2:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 1:51 [PATCH net-next] asix: silence log message from oversize packet Stephen Hemminger
2015-12-18 21:08 ` David Miller
2015-12-19 0:15 ` Stephen Hemminger
2015-12-19 2:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151218.212514.1288582729750012735.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben.hutchings@codethink.co.uk \
--cc=ivecera@redhat.com \
--cc=linuxbrad@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.