From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH v5 3/3] vhost: Add helper function to convert
 port id to virtio device pointer
Date: Fri, 18 Dec 2015 12:19:50 +0800
Message-ID: <20151218041950.GJ29571@yliu-dev.sh.intel.com>
References: <1447392031-24970-3-git-send-email-mukawa@igel.co.jp>
 <1448355603-21275-1-git-send-email-mukawa@igel.co.jp>
 <1448355603-21275-4-git-send-email-mukawa@igel.co.jp>
 <20151217114750.GD29571@yliu-dev.sh.intel.com>
 <56737A65.9060603@igel.co.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, ann.zhuangyanying@huawei.com
To: Tetsuya Mukawa <mukawa@igel.co.jp>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 2F7578D8F
 for <dev@dpdk.org>; Fri, 18 Dec 2015 05:19:21 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <56737A65.9060603@igel.co.jp>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Dec 18, 2015 at 12:15:49PM +0900, Tetsuya Mukawa wrote:
> On 2015/12/17 20:47, Yuanhan Liu wrote:
> > On Tue, Nov 24, 2015 at 06:00:03PM +0900, Tetsuya Mukawa wrote:
> >> This helper function is used to convert port id to virtio device
> >> pointer. To use this function, a port should be managed by vhost PMD.
> >> After getting virtio device pointer, it can be used for calling vhost
> >> library APIs.
> > I'm thinking why is that necessary. I mean, hey, can we simply treat
> > it as a normal pmd driver, and don't consider any vhost lib functions
> > any more while using vhost pmd?
> 
> I guess vhost PMD cannot  hide some of vhost features.

Sorry, a "guess" could not convice me to have it.

On the other hand, it does no harm but brings great benefit to make
things simple in the first time. __If__ there really is a need for
them, we could add it back, isn't it? ;)

	--yliu

> Because of this, we may need to add ethdev APIs to wraps these features.
> I described more in one more email. Could you please see it also?
> 
> Thanks,
> Tetsuya
>