From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46165)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <shmulik.ladkani@ravellosystems.com>)
	id 1a9oQ2-0006aO-87
	for qemu-devel@nongnu.org; Fri, 18 Dec 2015 01:21:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <shmulik.ladkani@ravellosystems.com>)
	id 1a9oPy-00051J-8R
	for qemu-devel@nongnu.org; Fri, 18 Dec 2015 01:21:34 -0500
Received: from mail-wm0-x229.google.com ([2a00:1450:400c:c09::229]:37889)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <shmulik.ladkani@ravellosystems.com>)
	id 1a9oPy-000511-0n
	for qemu-devel@nongnu.org; Fri, 18 Dec 2015 01:21:30 -0500
Received: by mail-wm0-x229.google.com with SMTP id l126so51155363wml.1
	for <qemu-devel@nongnu.org>; Thu, 17 Dec 2015 22:21:29 -0800 (PST)
Date: Fri, 18 Dec 2015 08:21:25 +0200
From: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
Message-ID: <20151218082125.4fa8826e@halley>
In-Reply-To: <5672FA23.80505@redhat.com>
References: <1450374401-31352-1-git-send-email-pbonzini@redhat.com>
	<1450374401-31352-9-git-send-email-pbonzini@redhat.com>
	<5672FA23.80505@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 08/45] vmw_pvscsi: Introduce
 'x-old-pci-configuration' backword compatability property
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

Hi Eric,

On Thu, 17 Dec 2015 11:08:35 -0700 Eric Blake <eblake@redhat.com> wrote:
> On 12/17/2015 10:46 AM, Paolo Bonzini wrote:
> > From: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
> 
> If there's a reason to respin:
> 
> long subject line, and contains a typo (should be backward, not
> backword). Could shorten by saying 'back-compat' instead of spelling it out.
> 
> But since this is already in a PULL request, I'm also fine if it lands
> as-is.

Thanks for your suggestion. Was about to fix; just noticed it was
already pulled.

There's one fix I need to submit however:

Since this is pulled post 2.5, we need to introduce HW_COMPAT_2_5 and
place the compat props there (instead of within HW_COMPAT_2_4).

Will submit.

Regards,
Shmulik