From: Chris Wilson <chris@chris-wilson.co.uk>
To: Namrta Salonie <namrta.salonie@intel.com>
Cc: intel-gfx@lists.freedesktop.org, akash.goel@intel.com,
"Satyanantha, Rama Gopal M" <rama.gopal.m.satyanantha@intel.com>
Subject: Re: [PATCH] drm/i915/vlv: Modifying RC6 Promotion timer for Media workloads.
Date: Fri, 18 Dec 2015 10:24:09 +0000 [thread overview]
Message-ID: <20151218102409.GD26780@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <1450433676-24924-1-git-send-email-namrta.salonie@intel.com>
On Fri, Dec 18, 2015 at 03:44:36PM +0530, Namrta Salonie wrote:
> In normal cases, RC6 promotion timer is 1700us. This will result in more
> time spent in C1 state. For more residency in C6 in case of media workloads,
> this is changed to 250us. Not doing this for 3D workloads as too many C6-C0
> transition delays can result in performance impact. Tracking the media
> workloads based on command submission to MFX engine.
Why bother flipping the media rc6 timeout? Why not just set it to the
new preferred value?
Other wise fix the use of a duplicate task (duplicates
retire-work/idle-work) (and not doing correct rpm wakeref tracking or
documentating that you only set if on the second batch, which seems an
interesting choice.)
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-12-18 10:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 10:14 [PATCH] drm/i915/vlv: Modifying RC6 Promotion timer for Media workloads Namrta Salonie
2015-12-18 10:24 ` Chris Wilson [this message]
2015-12-18 10:30 ` ✗ failure: Fi.CI.BAT Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151218102409.GD26780@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=akash.goel@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=namrta.salonie@intel.com \
--cc=rama.gopal.m.satyanantha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.