From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965190AbbLRVOE (ORCPT ); Fri, 18 Dec 2015 16:14:04 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:57746 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965164AbbLRVOB (ORCPT ); Fri, 18 Dec 2015 16:14:01 -0500 Date: Fri, 18 Dec 2015 13:14:00 -0800 From: Andrew Morton To: Michal Hocko Cc: Linus Torvalds , Mel Gorman , Tetsuo Handa , David Rientjes , Oleg Nesterov , Hugh Dickins , Andrea Argangeli , Rik van Riel , linux-mm , LKML Subject: Re: [PATCH 1/2] mm, oom: introduce oom reaper Message-Id: <20151218131400.751bc4d582a947c9833c09eb@linux-foundation.org> In-Reply-To: <20151218115454.GE28443@dhcp22.suse.cz> References: <1450204575-13052-1-git-send-email-mhocko@kernel.org> <20151216165035.38a4d9b84600d6348a3cf4bf@linux-foundation.org> <20151217130223.GE18625@dhcp22.suse.cz> <20151217120004.b5f849e1613a3a367482b379@linux-foundation.org> <20151218115454.GE28443@dhcp22.suse.cz> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Dec 2015 12:54:55 +0100 Michal Hocko wrote: > /* Retry the down_read_trylock(mmap_sem) a few times */ > - while (attempts++ < 10 && !__oom_reap_vmas(mm)) > - msleep_interruptible(100); > + while (attempts++ < 10 && !__oom_reap_vmas(mm)) { > + __set_task_state(current, TASK_IDLE); > + schedule_timeout(HZ/10); > + } If you won't, I shall ;) From: Andrew Morton Subject: sched: add schedule_timeout_idle() This will be needed in the patch "mm, oom: introduce oom reaper". Cc: Michal Hocko Cc: Ingo Molnar Cc: Peter Zijlstra Signed-off-by: Andrew Morton --- include/linux/sched.h | 1 + kernel/time/timer.c | 11 +++++++++++ 2 files changed, 12 insertions(+) diff -puN kernel/time/timer.c~sched-add-schedule_timeout_idle kernel/time/timer.c --- a/kernel/time/timer.c~sched-add-schedule_timeout_idle +++ a/kernel/time/timer.c @@ -1566,6 +1566,17 @@ signed long __sched schedule_timeout_uni } EXPORT_SYMBOL(schedule_timeout_uninterruptible); +/* + * Like schedule_timeout_uninterruptible(), except this task will not contribute + * to load average. + */ +signed long __sched schedule_timeout_idle(signed long timeout) +{ + __set_current_state(TASK_IDLE); + return schedule_timeout(timeout); +} +EXPORT_SYMBOL(schedule_timeout_idle); + #ifdef CONFIG_HOTPLUG_CPU static void migrate_timer_list(struct tvec_base *new_base, struct hlist_head *head) { diff -puN include/linux/sched.h~sched-add-schedule_timeout_idle include/linux/sched.h --- a/include/linux/sched.h~sched-add-schedule_timeout_idle +++ a/include/linux/sched.h @@ -423,6 +423,7 @@ extern signed long schedule_timeout(sign extern signed long schedule_timeout_interruptible(signed long timeout); extern signed long schedule_timeout_killable(signed long timeout); extern signed long schedule_timeout_uninterruptible(signed long timeout); +extern signed long schedule_timeout_idle(signed long timeout); asmlinkage void schedule(void); extern void schedule_preempt_disabled(void); _ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f179.google.com (mail-pf0-f179.google.com [209.85.192.179]) by kanga.kvack.org (Postfix) with ESMTP id 7E5026B0003 for ; Fri, 18 Dec 2015 16:14:02 -0500 (EST) Received: by mail-pf0-f179.google.com with SMTP id o64so54614834pfb.3 for ; Fri, 18 Dec 2015 13:14:02 -0800 (PST) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id d10si26170873pap.237.2015.12.18.13.14.01 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Dec 2015 13:14:01 -0800 (PST) Date: Fri, 18 Dec 2015 13:14:00 -0800 From: Andrew Morton Subject: Re: [PATCH 1/2] mm, oom: introduce oom reaper Message-Id: <20151218131400.751bc4d582a947c9833c09eb@linux-foundation.org> In-Reply-To: <20151218115454.GE28443@dhcp22.suse.cz> References: <1450204575-13052-1-git-send-email-mhocko@kernel.org> <20151216165035.38a4d9b84600d6348a3cf4bf@linux-foundation.org> <20151217130223.GE18625@dhcp22.suse.cz> <20151217120004.b5f849e1613a3a367482b379@linux-foundation.org> <20151218115454.GE28443@dhcp22.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Linus Torvalds , Mel Gorman , Tetsuo Handa , David Rientjes , Oleg Nesterov , Hugh Dickins , Andrea Argangeli , Rik van Riel , linux-mm , LKML On Fri, 18 Dec 2015 12:54:55 +0100 Michal Hocko wrote: > /* Retry the down_read_trylock(mmap_sem) a few times */ > - while (attempts++ < 10 && !__oom_reap_vmas(mm)) > - msleep_interruptible(100); > + while (attempts++ < 10 && !__oom_reap_vmas(mm)) { > + __set_task_state(current, TASK_IDLE); > + schedule_timeout(HZ/10); > + } If you won't, I shall ;) From: Andrew Morton Subject: sched: add schedule_timeout_idle() This will be needed in the patch "mm, oom: introduce oom reaper". Cc: Michal Hocko Cc: Ingo Molnar Cc: Peter Zijlstra Signed-off-by: Andrew Morton --- include/linux/sched.h | 1 + kernel/time/timer.c | 11 +++++++++++ 2 files changed, 12 insertions(+) diff -puN kernel/time/timer.c~sched-add-schedule_timeout_idle kernel/time/timer.c --- a/kernel/time/timer.c~sched-add-schedule_timeout_idle +++ a/kernel/time/timer.c @@ -1566,6 +1566,17 @@ signed long __sched schedule_timeout_uni } EXPORT_SYMBOL(schedule_timeout_uninterruptible); +/* + * Like schedule_timeout_uninterruptible(), except this task will not contribute + * to load average. + */ +signed long __sched schedule_timeout_idle(signed long timeout) +{ + __set_current_state(TASK_IDLE); + return schedule_timeout(timeout); +} +EXPORT_SYMBOL(schedule_timeout_idle); + #ifdef CONFIG_HOTPLUG_CPU static void migrate_timer_list(struct tvec_base *new_base, struct hlist_head *head) { diff -puN include/linux/sched.h~sched-add-schedule_timeout_idle include/linux/sched.h --- a/include/linux/sched.h~sched-add-schedule_timeout_idle +++ a/include/linux/sched.h @@ -423,6 +423,7 @@ extern signed long schedule_timeout(sign extern signed long schedule_timeout_interruptible(signed long timeout); extern signed long schedule_timeout_killable(signed long timeout); extern signed long schedule_timeout_uninterruptible(signed long timeout); +extern signed long schedule_timeout_idle(signed long timeout); asmlinkage void schedule(void); extern void schedule_preempt_disabled(void); _ -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org