All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH nf] netfilter: nft_ct: include direction when dumping NFT_CT_L3PROTOCOL key
@ 2015-12-18 13:32 Florian Westphal
  2015-12-18 13:46 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 2+ messages in thread
From: Florian Westphal @ 2015-12-18 13:32 UTC (permalink / raw)
  To: netfilter-devel; +Cc: Florian Westphal

one nft userspace test case fails with

'ct l3proto original ipv4' mismatches 'ct l3proto ipv4'

... because NFTA_CT_DIRECTION attr is missing.

Signed-off-by: Florian Westphal <fw@strlen.de>
---
diff --git a/net/netfilter/nft_ct.c b/net/netfilter/nft_ct.c
index 8cbca34..9399215 100644
--- a/net/netfilter/nft_ct.c
+++ b/net/netfilter/nft_ct.c
@@ -366,6 +366,7 @@ static int nft_ct_get_dump(struct sk_buff *skb, const struct nft_expr *expr)
 		goto nla_put_failure;
 
 	switch (priv->key) {
+	case NFT_CT_L3PROTOCOL:
 	case NFT_CT_PROTOCOL:
 	case NFT_CT_SRC:
 	case NFT_CT_DST:
-- 
2.4.10


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH nf] netfilter: nft_ct: include direction when dumping NFT_CT_L3PROTOCOL key
  2015-12-18 13:32 [PATCH nf] netfilter: nft_ct: include direction when dumping NFT_CT_L3PROTOCOL key Florian Westphal
@ 2015-12-18 13:46 ` Pablo Neira Ayuso
  0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2015-12-18 13:46 UTC (permalink / raw)
  To: Florian Westphal; +Cc: netfilter-devel

On Fri, Dec 18, 2015 at 02:32:07PM +0100, Florian Westphal wrote:
> one nft userspace test case fails with
> 
> 'ct l3proto original ipv4' mismatches 'ct l3proto ipv4'
> 
> ... because NFTA_CT_DIRECTION attr is missing.

Applied, thanks Florian.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-12-18 13:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-18 13:32 [PATCH nf] netfilter: nft_ct: include direction when dumping NFT_CT_L3PROTOCOL key Florian Westphal
2015-12-18 13:46 ` Pablo Neira Ayuso

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.