From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932577AbbLRN5z (ORCPT ); Fri, 18 Dec 2015 08:57:55 -0500 Received: from mail-bl2on0070.outbound.protection.outlook.com ([65.55.169.70]:27323 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932444AbbLRN5u (ORCPT ); Fri, 18 Dec 2015 08:57:50 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@caviumnetworks.com; Date: Fri, 18 Dec 2015 16:57:17 +0300 From: Yury Norov To: Arnd Bergmann CC: , , , , , , , , , , Andrew Pinski , , Andrew Pinski , , , , , Subject: Re: [PATCH v6 10/20] arm64:ilp32 use the native LP64 'start_thread' for ILP32 threads Message-ID: <20151218135717.GC31200@yury-N73SV> References: <1450215766-14765-1-git-send-email-ynorov@caviumnetworks.com> <1450215766-14765-11-git-send-email-ynorov@caviumnetworks.com> <12007390.0rtOQc0npd@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <12007390.0rtOQc0npd@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [95.143.213.121] X-ClientProxiedBy: AM3PR01CA042.eurprd01.prod.exchangelabs.com (10.141.191.32) To BLUPR07MB610.namprd07.prod.outlook.com (10.141.207.15) X-Microsoft-Exchange-Diagnostics: 1;BLUPR07MB610;2:SyzGoDPEAS1Uqz0+RK+lfVndrvxqZbFgEcv6Zo1fk+bQuYrSoEkzUJ7Dq62q4kHlMrF/iTYCmKFGxQj95IxsN40ZrS0WvcTbat0w4OZbNHS30lCW0sUXYTkhoJBR0q/ec2v19SzoDxOcIuLB8fbajA==;3:Or+sJEduT1EN8I+y59N98B42ep9smJ47nivljeZxqmMui6or1eGLsB5VZQLpge1k2N3ufwAM9OZl88MFjhOhmpO45CUQlhNI4MaxR/lUVxJXCP/fzYSteFL7tAI3L0BI;25:EJ+OJg6AkPrvUw1OF8vAZ9wh/84RiTVLtIfu+taXKwtWc3e2tqE7HfxIBNzCdlykSalPhqEL/C8cT25V+KkoXeRqYln53ZcBtGOGqeIRQg9HdpV/dlP3+UYW881Q4DoiX6/LKp3enl8u4wcsyLSHakHfFm0gxRmOo4JZBv5Wva4k2gm1S3UWCTxmUc5Ht9En7s8lkeyz8IPb7e3CJSGgO1X2Wa/A0zpKEsrVVn4wTmkG7Zld6v4DoS3OAxgJdrd7UDAWDlNkGyJPvvZwMQFihQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR07MB610; X-Microsoft-Exchange-Diagnostics: 1;BLUPR07MB610;20:kZZQ01pEDcz/4M76HqVX9q/V9dZxHEESHI3qarep7esZio4L+kr0TGaYFxEPGaKbEhAXJyB8PcoQ1He49zEJhb0NnJeuPzN6ufAahXr1znwr2FIxs8lD9Xu5N3vCtZzdQkAAGSm9HVBHRjBlItNRS5YcaN6Xl+H3WKb+lxOI0vjnmaWUIIQEUCTuUp6SEk4jmvo+2hFC0Kvjo5D/GTzbGaeU+qO6B7pDaCbvdRw0LYlvKgS4nF/oSCP1Bo3r+U7Is1LpeUmMBPnQTkAGQukkC0XKPLkDH3jXm6wdSPlHkQ/ddGVWF/WJfSdqHIw05PXAevGsOBH8cvVKL6JWNdKr//H3Mp/EgdHrL7g62AnSKjrArPEugIFsbV4uzi+cGe8yNvv33ULGYSsh2t3Chp98u1+ZVIU65QIgnmQ7UW8nonlwR6oiO0rhoRADllOUclqjK/xHNM82mLMfW/zTJi/bgOGpgRGQhBCg/LbkQAuulFX9NAV1V60wzcKpRJqJYYH5kAepj24SvDfMeI99bjaDc4tH5BrnVQTw4Vpp20EYjXMSMZrzaQPDZBYKg2WQikgo9JQfoOEJZbgAylO41QhlUi6Tante2XBlXfN3Pu3ewKo= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(3002001)(10201501046);SRVR:BLUPR07MB610;BCL:0;PCL:0;RULEID:;SRVR:BLUPR07MB610; X-Microsoft-Exchange-Diagnostics: 1;BLUPR07MB610;4:FypPoU5EoDzSdQVyO0um94JfhW5OGbg5ZY9Nhog3hvhSo5U3gVDMqSyeDas/GzlBd8NEcjuX0IxlJ5t2ywFjA2aWHnA3XYEpNQZraQl2KI4naoVbqupP3bmv2o2AuhsGV+Z7LpYWDY3jHzDg3M3UoT1Sf0cW8QRS8dHjdQvgPvbcPT8IXgFgv6h6iPvju4OH93/PchHtQ10+IGIn/5xDiwJ/7Cjyi5rufo9tOARIFy/psjOPHREV9SRA4egvs0h8nV3oF5U8HRK//0NRV54J4fYfvfvxBbBIEIk32CjVt7w8SciMLhdcH16+9ZjcsAY4S59HJuC7uqH8zuvjLB7AK5oT56z83a0w+aRvKfOWbM16NMUI3YHdAHpLq4As6lBg X-Forefront-PRVS: 07943272E1 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6069001)(199003)(24454002)(189002)(83506001)(97756001)(110136002)(3846002)(77096005)(23726003)(4001350100001)(40100003)(46406003)(105586002)(586003)(6116002)(97736004)(33716001)(66066001)(189998001)(1076002)(1096002)(50466002)(5008740100001)(106356001)(7520500002)(2950100001)(47776003)(5004730100002)(122386002)(81156007)(101416001)(92566002)(5001960100002)(42186005)(33656002)(50986999)(76506005)(76176999)(87976001)(54356999);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR07MB610;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BLUPR07MB610;23:co/6QSgiikfDt02qUxscrbc7H4lxSzO1ppTr/LhGsA?= =?us-ascii?Q?yICY/REX1520+tYyRgFsD5/WSDqjHiP2wh/EBgiIE3hftVz0mA1hMuCGaMVj?= =?us-ascii?Q?G88LHYBW5FWxpu/u8VLr6EW6d2W0zaJwm1G5K3jCbMh3kMSlRM10FQMmdOCM?= =?us-ascii?Q?XMLQCYO0fSTSsSd9buIMDMXRc9qnluYURnhxI7lxnBj4BRxV499MS4OlmbA6?= =?us-ascii?Q?4wR47Uby9qsN5jHtGGXBS9WmdvzX5XVFko9R9Hl5qfJW4nBPKRdD1UuFD3GX?= =?us-ascii?Q?6FYmG8Bbyi61WFOM7b6GAfaycbBM5OSVuoIINOT4L+iN/NaMk87RvkBS+x9A?= =?us-ascii?Q?g1QfGN0d4RXTLWGzJG3iFeJebCtU6WUil8I8SLK5HUd3599I+QVtlBQ8Qrvy?= =?us-ascii?Q?DfWWf5YhQcpGidhF6CFSNuv1bYTNJImog9CgT8wYw5wAl7N7c9AJsRgl3PjW?= =?us-ascii?Q?wFcS3qNzuSgvZWJ/EhBzodXhh6FiaigBRj6uB8F290b4MVKpbCs7rSZETJq+?= =?us-ascii?Q?I3+W7jnUgInBOb31V9XxSp92bIgA6KfYsLaF7K47h/eQ/weJkihJXK8+8NKP?= =?us-ascii?Q?Kg+rQajN5LOu4E5Oz/cPOCjeKNRL+vCAB04/MXMGHTqyRgWToaFZd3Xn0wKa?= =?us-ascii?Q?q+J7y1dbSBFQAJuY6Igj+d7V3IEUIwuoqo5whLPlS+/AFIeH3pM7DlL3LY8c?= =?us-ascii?Q?AlGbf9YT+voFZN/f4G1bCAjAlXDdBRhOuEXEVUMSWQPm6Kf75wyG9K9fGa9R?= =?us-ascii?Q?dZqjzfd7B3xeVeEYchkmmP0jJD2Za2wt9wETp1QZLi22yQq+u0H9rJNIu4Qe?= =?us-ascii?Q?XmcTr1e78anSyIsFED66KsR59iBe3emOYhrDuoZG/LCjvsFoAl8aaMUMc32K?= =?us-ascii?Q?MqC/RJ1dHnjHde81lFYmnpysrVvuIRMF7BEnFfcmkVmFJZWc/XDprGxjfprz?= =?us-ascii?Q?JAiBCX0uvb8jzyO5Zza94VtYl5BJNBkjdFGD2a+lM2F5j/dWfa4jl2V7up9E?= =?us-ascii?Q?3JcmdnNlDoKfiVZGBWs355DL1jXUPvdd6Kh8X/6N0n+M/+aU4B+rKacJSUR+?= =?us-ascii?Q?Jld8gFfUeIWrqaypvi21g+9jQzpwky6c8+J2XPzyHEoVZqwA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR07MB610;5:dlRvOCTidnj7KomGRHJx9x4Iu4lEqQsiT5uRXFcYM3dMjc/YZOkaiQtkUGx3b3WeSCmmQV8O/lyAYiVcytfSvDye597cD/IjNwitJN3zjqZZjLvbDgxlF7TcWQDHqDUDRgciWXkzeAKgjPZudRroHg==;24:Pm28enrpMUGFMWTCND4K6QzC/j0Yj75o+o0ILzQYZcGFT7+xIxhI0/rDce+40MP6fXIW2LP9sW5dye4KERwf6GjulQxcsnfw6FsFPh0dYQA= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2015 13:57:48.0624 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR07MB610 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 16, 2015 at 04:50:18PM +0100, Arnd Bergmann wrote: > On Wednesday 16 December 2015 00:42:36 Yury Norov wrote: > > +#ifdef CONFIG_ARM64_ILP32 > > + /* ILP32 threads are started the same way as LP64 threads. */ > > + if (is_ilp32_compat_task()) { > > + start_thread(regs, pc, sp); > > + return; > > + } > > +#endif > > > > Just a small style comment, but I think you can just leave out the #ifdef, > as is_ilp32_compat_task() will already return false if that is disabled. > > Arnd Missed it, thank you. From mboxrd@z Thu Jan 1 00:00:00 1970 From: ynorov@caviumnetworks.com (Yury Norov) Date: Fri, 18 Dec 2015 16:57:17 +0300 Subject: [PATCH v6 10/20] arm64:ilp32 use the native LP64 'start_thread' for ILP32 threads In-Reply-To: <12007390.0rtOQc0npd@wuerfel> References: <1450215766-14765-1-git-send-email-ynorov@caviumnetworks.com> <1450215766-14765-11-git-send-email-ynorov@caviumnetworks.com> <12007390.0rtOQc0npd@wuerfel> Message-ID: <20151218135717.GC31200@yury-N73SV> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Dec 16, 2015 at 04:50:18PM +0100, Arnd Bergmann wrote: > On Wednesday 16 December 2015 00:42:36 Yury Norov wrote: > > +#ifdef CONFIG_ARM64_ILP32 > > + /* ILP32 threads are started the same way as LP64 threads. */ > > + if (is_ilp32_compat_task()) { > > + start_thread(regs, pc, sp); > > + return; > > + } > > +#endif > > > > Just a small style comment, but I think you can just leave out the #ifdef, > as is_ilp32_compat_task() will already return false if that is disabled. > > Arnd Missed it, thank you.