[Buildroot] [PATCH 0/4 v2] Do not select providers of virtual packages (branch yem/dont-select-providers)

[Buildroot] [PATCH 0/4 v2] Do not select providers of virtual packages (branch yem/dont-select-providers)

[Yann E. MORIN]

Hello All!

This series fixes the selection of the Lua package, a sit is a provider
for the virtual package lua-interpreter.

As explained in the manual, it is not allowed to select the provider of
a virtual package. Quoting:

    If your package really requires a specific provider, then you?ll
    have to make your package depends on this provider; you can not
    select a provider.

Followed by an explanations on the reasons this should not be done:

    https://buildroot.org/downloads/manual/manual.html#_infrastructure_for_virtual_packages

This series just cleanups the situation with respect to the
lua-interpreter virtual package. It has not been checked if we
had other virtual packages for which providers were selected.
This can be done in a later series.


Changes v1 -> v2:
  - drop the comment about Lua beeing needed  (Thomas)


Regards,
Yann E. MORIN.


The following changes since commit 1edb4c51dee78d7d26700c037f29558e73d27ee0:

  Makefile: valgrind needs non-stripped dynamic linker library (2015-12-17 23:21:17 +0100)

are available in the git repository at:

  git://git.busybox.net/~ymorin/git/buildroot yem/dont-select-providers

for you to fetch changes up to 84fa969c68f847a8cbc781c28da5a5c2bc56dce8:

  package/libedje: do not select Lua, depend on it (2015-12-17 23:38:13 +0100)

----------------------------------------------------------------
Yann E. MORIN (4):
      package/dnsmasq: do not select Lua, depend on it
      package/haserl: do not select Lua, depend on it
      package/lighttpd: do not select Lua, depend on it
      package/libedje: do not select Lua, depend on it

 package/dnsmasq/Config.in           | 2 +-
 package/efl/libedje/Config.in       | 4 ++--
 package/efl/libelementary/Config.in | 4 +++-
 package/efl/libethumb/Config.in     | 3 ++-
 package/enlightenment/Config.in     | 6 ++++--
 package/haserl/Config.in            | 2 +-
 package/lighttpd/Config.in          | 2 +-
 7 files changed, 14 insertions(+), 9 deletions(-)

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/4 v2] package/dnsmasq: do not select Lua, depend on it

[Yann E. MORIN]

Lua is a provider for the virtual package lua-interpreter, so it cannot
be selected, as explained in the manual.

Turn the 'select' into a 'depends on'.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

---
Note: I haven't check if dnsmasq could use luajit instead of Lua. This
change is just a mechanical change.

---
Changes v1 -> v2;
  - drop the comment  (Thomas)
---
 package/dnsmasq/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/dnsmasq/Config.in b/package/dnsmasq/Config.in
index 9e1c462..b4f34b8 100644
--- a/package/dnsmasq/Config.in
+++ b/package/dnsmasq/Config.in
@@ -38,7 +38,7 @@ config BR2_PACKAGE_DNSMASQ_IDN
 
 config BR2_PACKAGE_DNSMASQ_LUA
 	bool "Lua scripting support"
-	select BR2_PACKAGE_LUA
+	depends on BR2_PACKAGE_LUA
 	help
 	  Enable Lua scripting for dnsmasq
 
-- 
1.9.1

[Buildroot] [PATCH 2/4 v2] package/haserl: do not select Lua, depend on it

[Yann E. MORIN]

Lua is a provider for the virtual package lua-interpreter, so it cannot
be selected, as explained in the manual.

Turn the 'select' into a 'depends on'.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

---
Note: I haven't check if haserl could use luajit instead of Lua. This
change is just a mechanical change.

---
changes v1 -> v2:
  - drop comment  (Thomas)
---
 package/haserl/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/haserl/Config.in b/package/haserl/Config.in
index 1620d72..9ccc392 100644
--- a/package/haserl/Config.in
+++ b/package/haserl/Config.in
@@ -11,6 +11,6 @@ config BR2_PACKAGE_HASERL
 config BR2_PACKAGE_HASERL_WITH_LUA
 	bool "Lua support"
 	depends on BR2_PACKAGE_HASERL
-	select BR2_PACKAGE_LUA
+	depends on BR2_PACKAGE_LUA
 	help
 	  Enable Lua support for haserl
-- 
1.9.1

[Buildroot] [PATCH 3/4 v2] package/lighttpd: do not select Lua, depend on it

[Yann E. MORIN]

Lua is a provider for the virtual package lua-interpreter, so it cannot
be selected, as explained in the manual.

Turn the 'select' into a 'depends on'.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

---
Note: I haven't check if lighttpd could use luajit instead of Lua. This
change is just a mechanical change.

---
Changes v1 -> v2:
  - drop comment  (Thomas)
---
 package/lighttpd/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/lighttpd/Config.in b/package/lighttpd/Config.in
index 2c101e7..f62ccb9 100644
--- a/package/lighttpd/Config.in
+++ b/package/lighttpd/Config.in
@@ -52,7 +52,7 @@ config BR2_PACKAGE_LIGHTTPD_WEBDAV
 
 config BR2_PACKAGE_LIGHTTPD_LUA
 	bool "lua support"
-	select BR2_PACKAGE_LUA
+	depends on BR2_PACKAGE_LUA
 	help
 	  Enable Lua support. Needed to support mod_magnet
 
-- 
1.9.1

[Buildroot] [PATCH 4/4 v2] package/libedje: do not select Lua, depend on it

[Yann E. MORIN]

Lua is a provider for the virtual package lua-interpreter, so it cannot
be selected, as explained in the manual.

Turn the 'select' into a 'depends on'; propagate the dependency. Update
the comment for Enlightenment to reference Lua.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

---
Note: I haven't check if libedje could use luajit instead of Lua. This
change is just a mechanical change. Also, libedje is slated for removal
once we bump the EFL version to 1.15.x.

---
Changes v1 -> v2:
  - drop the comment  (Thomas)
  - except for Enlightenment
---
 package/efl/libedje/Config.in       | 4 ++--
 package/efl/libelementary/Config.in | 4 +++-
 package/efl/libethumb/Config.in     | 3 ++-
 package/enlightenment/Config.in     | 6 ++++--
 4 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/package/efl/libedje/Config.in b/package/efl/libedje/Config.in
index b163508..6af85ee 100644
--- a/package/efl/libedje/Config.in
+++ b/package/efl/libedje/Config.in
@@ -1,5 +1,5 @@
 comment "libedje needs a toolchain w/ threads"
-	depends on !BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_PACKAGE_LUA || !BR2_TOOLCHAIN_HAS_THREADS
 
 config BR2_PACKAGE_LIBEDJE
 	bool "libedje"
@@ -9,7 +9,7 @@ config BR2_PACKAGE_LIBEDJE
 	select BR2_PACKAGE_LIBECORE_EVAS
 	select BR2_PACKAGE_LIBEMBRYO
 	select BR2_PACKAGE_LIBEVAS
-	select BR2_PACKAGE_LUA
+	depends on BR2_PACKAGE_LUA
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libevas
 	help
 	  A graphical layout and animation library for animated
diff --git a/package/efl/libelementary/Config.in b/package/efl/libelementary/Config.in
index fcc7025..68237c7 100644
--- a/package/efl/libelementary/Config.in
+++ b/package/efl/libelementary/Config.in
@@ -1,10 +1,12 @@
 comment "libelementary needs a toolchain w/ threads, dynamic library"
-	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
+	depends on !BR2_PACKAGE_LUA || !BR2_TOOLCHAIN_HAS_THREADS \
+		|| BR2_STATIC_LIBS
 
 config BR2_PACKAGE_LIBELEMENTARY
 	bool "libelementary"
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libevas
 	depends on !BR2_STATIC_LIBS
+	depends on BR2_PACKAGE_LUA # libedje
 	select BR2_PACKAGE_LIBEINA
 	select BR2_PACKAGE_LIBEVAS
 	select BR2_PACKAGE_LIBECORE
diff --git a/package/efl/libethumb/Config.in b/package/efl/libethumb/Config.in
index 3e9cbde..78d51f9 100644
--- a/package/efl/libethumb/Config.in
+++ b/package/efl/libethumb/Config.in
@@ -1,5 +1,5 @@
 comment "libethumb needs a toolchain w/ threads"
-	depends on !BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_PACKAGE_LUA || !BR2_TOOLCHAIN_HAS_THREADS
 
 config BR2_PACKAGE_LIBETHUMB
 	bool "libethumb"
@@ -9,6 +9,7 @@ config BR2_PACKAGE_LIBETHUMB
 	select BR2_PACKAGE_LIBECORE_EVAS
 	select BR2_PACKAGE_LIBEDJE
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libevas
+	depends on BR2_PACKAGE_LUA # libedje
 	help
 	  Ethumb is a library for generating thumbnail images of documents.
 
diff --git a/package/enlightenment/Config.in b/package/enlightenment/Config.in
index 9dad571..67e1dbc 100644
--- a/package/enlightenment/Config.in
+++ b/package/enlightenment/Config.in
@@ -11,6 +11,7 @@ config BR2_PACKAGE_ENLIGHTENMENT
 	depends on BR2_PACKAGE_XORG7
 	# libevas-generic-loaders-svg -> librsvg -> pango -> cairo
 	depends on BR2_ARCH_HAS_ATOMICS
+	depends on BR2_PACKAGE_LUA # libedje
 	select BR2_PACKAGE_EFL
 	select BR2_PACKAGE_LIBECORE
 	select BR2_PACKAGE_LIBECORE_X
@@ -37,7 +38,8 @@ config BR2_PACKAGE_ENLIGHTENMENT
 
 	  http://www.enlightenment.org/
 
-comment "enlightenment needs a toolchain w/ wchar, C++, threads"
+comment "enlightenment needs the Lua interpreter and a toolchain w/ wchar, C++, threads"
 	depends on BR2_PACKAGE_XORG7 && BR2_USE_MMU
-	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
+	depends on !BR2_PACKAGE_LUA || !BR2_USE_WCHAR \
+                || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
 	depends on BR2_ARCH_HAS_ATOMICS
-- 
1.9.1

[Buildroot] [PATCH 4/4 v2] package/libedje: do not select Lua, depend on it

[Yann E. MORIN]

All,

On 2015-12-17 23:40 +0100, Yann E. MORIN spake thusly:
> Lua is a provider for the virtual package lua-interpreter, so it cannot
> be selected, as explained in the manual.

I've marked that patch as Not Applicable in Patchwork, now that liedje
no longer exists.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 0/4 v2] Do not select providers of virtual packages (branch yem/dont-select-providers)

[Thomas Petazzoni]

Dear Yann E. MORIN,

On Thu, 17 Dec 2015 23:40:23 +0100, Yann E. MORIN wrote:

> Yann E. MORIN (4):
>       package/dnsmasq: do not select Lua, depend on it
>       package/haserl: do not select Lua, depend on it
>       package/lighttpd: do not select Lua, depend on it

Those three patches applied, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 0/4 v2] Do not select providers of virtual packages (branch yem/dont-select-providers)

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

> Dear Yann E. MORIN,
> On Thu, 17 Dec 2015 23:40:23 +0100, Yann E. MORIN wrote:

>> Yann E. MORIN (4):
>> package/dnsmasq: do not select Lua, depend on it
>> package/haserl: do not select Lua, depend on it
>> package/lighttpd: do not select Lua, depend on it

> Those three patches applied, thanks!

Should these lua suboptions perhaps now be enabled by default if lua is
available (E.G. default y)?

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 0/4 v2] Do not select providers of virtual packages (branch yem/dont-select-providers)

[Thomas Petazzoni]

Dear Peter Korsgaard,

On Wed, 30 Dec 2015 21:48:20 +0100, Peter Korsgaard wrote:

> Should these lua suboptions perhaps now be enabled by default if lua is
> available (E.G. default y)?

To provide better "legacy" compatibility ?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 0/4 v2] Do not select providers of virtual packages (branch yem/dont-select-providers)

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

> Dear Peter Korsgaard,
> On Wed, 30 Dec 2015 21:48:20 +0100, Peter Korsgaard wrote:

>> Should these lua suboptions perhaps now be enabled by default if lua is
>> available (E.G. default y)?

> To provide better "legacy" compatibility ?

No, just that the support code to provide lua support probably is quite
a bit smaller than lua / people are likely to want it if they have lua
enabled - So it perhaps makes sense to enable it by default.

You could also argue that we should handle it automatically without a
sub option like we do for openssl, but that would be a bigger change.

-- 
Venlig hilsen,
Peter Korsgaard 

[Buildroot] [PATCH 0/4 v2] Do not select providers of virtual packages (branch yem/dont-select-providers)

[Thomas Petazzoni]

Peter,

On Wed, 30 Dec 2015 22:19:10 +0100, Peter Korsgaard wrote:

> No, just that the support code to provide lua support probably is quite
> a bit smaller than lua / people are likely to want it if they have lua
> enabled - So it perhaps makes sense to enable it by default.
> 
> You could also argue that we should handle it automatically without a
> sub option like we do for openssl, but that would be a bigger change.

I don't feel very strongly about this. If we have sub-options, then I
don't really see why we should default them to y. But if Yann reads you
and wants to send a patch to do this, I won't oppose to it :-)

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com