From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jones Subject: Re: [PATCH kvm-unit-tests v2 01/12] run_tests: move run() to scripts/ Date: Fri, 18 Dec 2015 12:52:40 -0600 Message-ID: <20151218185240.GD3885@hawk.localdomain> References: <1450374823-7648-1-git-send-email-rkrcmar@redhat.com> <1450374823-7648-2-git-send-email-rkrcmar@redhat.com> <20151217184507.GA14168@hawk.localdomain> <20151218104240.GA19139@potion.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, Paolo Bonzini To: Radim =?utf-8?B?S3LEjW3DocWZ?= Return-path: Received: from mx1.redhat.com ([209.132.183.28]:41222 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932554AbbLRSwq (ORCPT ); Fri, 18 Dec 2015 13:52:46 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id AA8A08F4F6 for ; Fri, 18 Dec 2015 18:52:46 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20151218104240.GA19139@potion.brq.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Dec 18, 2015 at 11:42:40AM +0100, Radim Kr=C4=8Dm=C3=A1=C5=99 w= rote: > 2015-12-17 12:45-0600, Andrew Jones: > > On Thu, Dec 17, 2015 at 06:53:32PM +0100, Radim Kr=C4=8Dm=C3=A1=C5=99= wrote: > >> We'll be using it from scripts/mkstandalone later. > >>=20 > >> Signed-off-by: Radim Kr=C4=8Dm=C3=A1=C5=99 > >> --- > >> v2: new > >> =20 > >> run_tests.sh | 53 +------------------------------------------= ---------- > >> scripts/run.bash | 51 +++++++++++++++++++++++++++++++++++++++++++= ++++++++ > >=20 > > Could probably just put run() in scripts/functions.bash >=20 > Definitely. The drawback is that for_each_unittest() and any future > helper would be pasted in each unit test, which would complicate > conversion back to shell and uselessly bloat tests. Even though I li= ke Oh right, nevermind then. If we're going to 'cat run.bash >>' then it needs to be separate. But do we really want to 'cat run.bash'? I guess = I need to look at your mkstandalone changes again. > programming in shell far more than in C, I would not do it if we deci= de > to POSIX our standalone tests. (Bloating is not an issue for me.) > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html