From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [RFC nft] ct expr: make directional keys work
Date: Fri, 18 Dec 2015 21:30:51 +0100 [thread overview]
Message-ID: <20151218203051.GA2086@salvia> (raw)
In-Reply-To: <20151218171707.GA29573@breakpoint.cc>
On Fri, Dec 18, 2015 at 06:17:07PM +0100, Florian Westphal wrote:
> Florian Westphal <fw@strlen.de> wrote:
> > Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > > I think this should fit into the grammar that I'm proposing above with
> > > no shift/reduce conflicts, ie.
> > >
> > > ct packets VALUE
> > > ct direction original packets VALUE
> > > ct direction reply packets VALUE
> >
> > I'll have to check. I don't want to add any new keywords to the lexer
> > since that creates more problems for the grammar.
>
> Drats, it doesn't work.
> conflicts: 1 shift/reduce
Right, the parser doesn't know if it has to reduce
ct direction original
as simple expression, or keep shifting for more tokens.
> 'ct direction' is already a valid expression, it loads
> CTINFO2DIR(ctinfo).
>
> I'll send what I have in a second, but its not great either.
Wait for it.
prev parent reply other threads:[~2015-12-18 20:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 0:55 [RFC nft] ct expr: make directional keys work Florian Westphal
2015-12-17 11:13 ` Pablo Neira Ayuso
2015-12-17 13:03 ` Florian Westphal
2015-12-18 17:17 ` Florian Westphal
2015-12-18 20:30 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151218203051.GA2086@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.