All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] v4l2grab: new package
Date: Fri, 18 Dec 2015 22:40:11 +0100	[thread overview]
Message-ID: <20151218224011.117e774b@free-electrons.com> (raw)
In-Reply-To: <566847AA.3040401@inbox.ru>

Hello,

I've applied, but there were still two remaining issues. See below.

On Wed, 9 Dec 2015 18:24:26 +0300, Viacheslav Volkov wrote:

> diff --git a/package/v4l2grab/v4l2grab.hash b/package/v4l2grab/v4l2grab.hash
> new file mode 100644
> index 0000000..e0a1797
> --- /dev/null
> +++ b/package/v4l2grab/v4l2grab.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha256 568d51512107226dab1ac809ab1ed4d544ce3f8f505b62c3b2177fb643c8157b v4l2grab-0abed72532bee02e545a1924b6883c839d50febf.tar.gz
> diff --git a/package/v4l2grab/v4l2grab.mk b/package/v4l2grab/v4l2grab.mk
> new file mode 100644
> index 0000000..12b4c3f
> --- /dev/null
> +++ b/package/v4l2grab/v4l2grab.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# v4l2grab
> +#
> +################################################################################
> +
> +V4L2GRAB_VERSION = 0abed72532bee02e545a1924b6883c839d50febf
> +V4L2GRAB_SITE = $(call github,twam,v4l2grab,$(V4L2GRAB_VERSION))
> +V4L2GRAB_LICENSE = GPLv2+
> +V4L2GRAB_LICENSE_FILE = LICENSE.md

This variable should have been named V4L2GRAB_LICENSE_FILES.

> +# Fetched from github, no pre-generated configure script provided
> +V4L2GRAB_AUTORECONF = YES
> +V4L2GRAB_DEPENDENCIES = libjpeg libv4l

And as noted by Arnout, we should not depend on libjpeg, but on jpeg.

I've fixed those two issues before applying.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-12-18 21:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-01 22:00 [Buildroot] [PATCH 1/2] libv4l: add patches to fix musl build issues, and enable on musl Thomas Petazzoni
2015-12-01 22:00 ` [Buildroot] [PATCH 2/2] v4l2grab: new package Thomas Petazzoni
2015-12-01 22:25   ` Arnout Vandecappelle
2015-12-09 15:24   ` Viacheslav Volkov
2015-12-18 21:40     ` Thomas Petazzoni [this message]
2015-12-18 21:40 ` [Buildroot] [PATCH 1/2] libv4l: add patches to fix musl build issues, and enable on musl Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151218224011.117e774b@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.