* [U-Boot] [PATCH] net: eth_designware: select PHYLIB in Kconfig
@ 2015-12-06 13:19 Thomas Chou
2015-12-06 18:52 ` Marek Vasut
` (5 more replies)
0 siblings, 6 replies; 14+ messages in thread
From: Thomas Chou @ 2015-12-06 13:19 UTC (permalink / raw)
To: u-boot
Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB
from legacy board header files.
This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE
are selected.
Reported-by: Pavel Machek <pavel@denx.de>
Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
---
drivers/net/Kconfig | 1 +
include/configs/axs101.h | 1 -
include/configs/bf609-ezkit.h | 1 -
include/configs/galileo.h | 1 -
include/configs/socfpga_common.h | 1 -
include/configs/spear-common.h | 1 -
include/configs/stv0991.h | 1 -
include/configs/sunxi-common.h | 1 -
include/configs/tb100.h | 1 -
include/configs/x600.h | 1 -
10 files changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index a03a95d..4b04d09 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -88,6 +88,7 @@ config ETH_SANDBOX_RAW
config ETH_DESIGNWARE
bool "Synopsys Designware Ethernet MAC"
+ select PHYLIB
help
This MAC is present in SoCs from various vendors. It supports
100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to
diff --git a/include/configs/axs101.h b/include/configs/axs101.h
index 650d97d..eeb2ae6 100644
--- a/include/configs/axs101.h
+++ b/include/configs/axs101.h
@@ -95,7 +95,6 @@
/*
* Ethernet PHY configuration
*/
-#define CONFIG_PHYLIB
#define CONFIG_MII
#define CONFIG_PHY_GIGE
diff --git a/include/configs/bf609-ezkit.h b/include/configs/bf609-ezkit.h
index 0e353b9..b5d4847 100644
--- a/include/configs/bf609-ezkit.h
+++ b/include/configs/bf609-ezkit.h
@@ -75,7 +75,6 @@
#define CONFIG_DW_ALTDESCRIPTOR
#define CONFIG_CMD_MII
#define CONFIG_MII
-#define CONFIG_PHYLIB
/* i2c Settings */
#define CONFIG_SYS_I2C
diff --git a/include/configs/galileo.h b/include/configs/galileo.h
index eb16a5e..14a42b1 100644
--- a/include/configs/galileo.h
+++ b/include/configs/galileo.h
@@ -45,7 +45,6 @@
/* 10/100M Ethernet support */
#define CONFIG_DESIGNWARE_ETH
#define CONFIG_DW_ALTDESCRIPTOR
-#define CONFIG_PHYLIB
/* Environment configuration */
#define CONFIG_ENV_SECT_SIZE 0x1000
diff --git a/include/configs/socfpga_common.h b/include/configs/socfpga_common.h
index b3f65b6..86eccba 100644
--- a/include/configs/socfpga_common.h
+++ b/include/configs/socfpga_common.h
@@ -105,7 +105,6 @@
#define CONFIG_DW_ALTDESCRIPTOR
#define CONFIG_MII
#define CONFIG_AUTONEG_TIMEOUT (15 * CONFIG_SYS_HZ)
-#define CONFIG_PHYLIB
#define CONFIG_PHY_GIGE
#endif
diff --git a/include/configs/spear-common.h b/include/configs/spear-common.h
index 1d69477..d2630f4 100644
--- a/include/configs/spear-common.h
+++ b/include/configs/spear-common.h
@@ -17,7 +17,6 @@
/* Ethernet driver configuration */
#define CONFIG_MII
-#define CONFIG_PHYLIB
#define CONFIG_PHY_RESET_DELAY 10000 /* in usec */
#define CONFIG_PHY_GIGE /* Include GbE speed/duplex detection */
diff --git a/include/configs/stv0991.h b/include/configs/stv0991.h
index 14c6a9e..f421321 100644
--- a/include/configs/stv0991.h
+++ b/include/configs/stv0991.h
@@ -53,7 +53,6 @@
/* GMAC related configs */
#define CONFIG_MII
-#define CONFIG_PHYLIB
#define CONFIG_DW_ALTDESCRIPTOR
#define CONFIG_PHY_MICREL
diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h
index 98a2c74..31a68ac 100644
--- a/include/configs/sunxi-common.h
+++ b/include/configs/sunxi-common.h
@@ -312,7 +312,6 @@ extern int soft_i2c_gpio_scl;
#define CONFIG_PHY_GIGE /* GMAC can use gigabit PHY */
#define CONFIG_PHY_ADDR 1
#define CONFIG_MII /* MII PHY management */
-#define CONFIG_PHYLIB
#endif
#ifdef CONFIG_USB_EHCI_HCD
diff --git a/include/configs/tb100.h b/include/configs/tb100.h
index 8660ed4..e06484f 100644
--- a/include/configs/tb100.h
+++ b/include/configs/tb100.h
@@ -42,7 +42,6 @@
/*
* Ethernet PHY configuration
*/
-#define CONFIG_PHYLIB
#define CONFIG_PHY_GIGE
/*
diff --git a/include/configs/x600.h b/include/configs/x600.h
index 58f1aca..0263c50 100644
--- a/include/configs/x600.h
+++ b/include/configs/x600.h
@@ -77,7 +77,6 @@
/* Ethernet config options */
#define CONFIG_MII
-#define CONFIG_PHYLIB
#define CONFIG_PHY_RESET_DELAY 10000 /* in usec */
#define CONFIG_PHY_ADDR 0 /* PHY address */
#define CONFIG_PHY_GIGE /* Include GbE speed/duplex detection */
--
2.5.0
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [U-Boot] [PATCH] net: eth_designware: select PHYLIB in Kconfig
2015-12-06 13:19 [U-Boot] [PATCH] net: eth_designware: select PHYLIB in Kconfig Thomas Chou
@ 2015-12-06 18:52 ` Marek Vasut
2015-12-07 6:37 ` Thomas Chou
2015-12-07 1:50 ` Bin Meng
` (4 subsequent siblings)
5 siblings, 1 reply; 14+ messages in thread
From: Marek Vasut @ 2015-12-06 18:52 UTC (permalink / raw)
To: u-boot
On Sunday, December 06, 2015 at 02:19:56 PM, Thomas Chou wrote:
> Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB
> from legacy board header files.
>
> This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE
> are selected.
>
> Reported-by: Pavel Machek <pavel@denx.de>
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> ---
> drivers/net/Kconfig | 1 +
> include/configs/axs101.h | 1 -
> include/configs/bf609-ezkit.h | 1 -
> include/configs/galileo.h | 1 -
> include/configs/socfpga_common.h | 1 -
> include/configs/spear-common.h | 1 -
> include/configs/stv0991.h | 1 -
> include/configs/sunxi-common.h | 1 -
> include/configs/tb100.h | 1 -
> include/configs/x600.h | 1 -
> 10 files changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index a03a95d..4b04d09 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -88,6 +88,7 @@ config ETH_SANDBOX_RAW
>
> config ETH_DESIGNWARE
> bool "Synopsys Designware Ethernet MAC"
> + select PHYLIB
> help
> This MAC is present in SoCs from various vendors. It supports
> 100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to
You should also remove the PHYLIB check in drivers/net/designware.c ,
otherwise looks good.
[...]
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [PATCH] net: eth_designware: select PHYLIB in Kconfig
2015-12-06 13:19 [U-Boot] [PATCH] net: eth_designware: select PHYLIB in Kconfig Thomas Chou
2015-12-06 18:52 ` Marek Vasut
@ 2015-12-07 1:50 ` Bin Meng
2015-12-07 6:35 ` Thomas Chou
2015-12-07 6:09 ` Chin Liang See
` (3 subsequent siblings)
5 siblings, 1 reply; 14+ messages in thread
From: Bin Meng @ 2015-12-07 1:50 UTC (permalink / raw)
To: u-boot
Hi Thomas,
On Sun, Dec 6, 2015 at 9:19 PM, Thomas Chou <thomas@wytron.com.tw> wrote:
> Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB
> from legacy board header files.
>
> This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE
> are selected.
>
> Reported-by: Pavel Machek <pavel@denx.de>
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> ---
> drivers/net/Kconfig | 1 +
> include/configs/axs101.h | 1 -
> include/configs/bf609-ezkit.h | 1 -
> include/configs/galileo.h | 1 -
> include/configs/socfpga_common.h | 1 -
> include/configs/spear-common.h | 1 -
> include/configs/stv0991.h | 1 -
> include/configs/sunxi-common.h | 1 -
> include/configs/tb100.h | 1 -
> include/configs/x600.h | 1 -
> 10 files changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index a03a95d..4b04d09 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -88,6 +88,7 @@ config ETH_SANDBOX_RAW
>
> config ETH_DESIGNWARE
> bool "Synopsys Designware Ethernet MAC"
> + select PHYLIB
> help
> This MAC is present in SoCs from various vendors. It supports
> 100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to
> diff --git a/include/configs/axs101.h b/include/configs/axs101.h
> index 650d97d..eeb2ae6 100644
> --- a/include/configs/axs101.h
> +++ b/include/configs/axs101.h
> @@ -95,7 +95,6 @@
> /*
> * Ethernet PHY configuration
> */
> -#define CONFIG_PHYLIB
> #define CONFIG_MII
> #define CONFIG_PHY_GIGE
>
> diff --git a/include/configs/bf609-ezkit.h b/include/configs/bf609-ezkit.h
> index 0e353b9..b5d4847 100644
> --- a/include/configs/bf609-ezkit.h
> +++ b/include/configs/bf609-ezkit.h
> @@ -75,7 +75,6 @@
> #define CONFIG_DW_ALTDESCRIPTOR
> #define CONFIG_CMD_MII
> #define CONFIG_MII
> -#define CONFIG_PHYLIB
>
> /* i2c Settings */
> #define CONFIG_SYS_I2C
> diff --git a/include/configs/galileo.h b/include/configs/galileo.h
> index eb16a5e..14a42b1 100644
> --- a/include/configs/galileo.h
> +++ b/include/configs/galileo.h
> @@ -45,7 +45,6 @@
> /* 10/100M Ethernet support */
> #define CONFIG_DESIGNWARE_ETH
> #define CONFIG_DW_ALTDESCRIPTOR
> -#define CONFIG_PHYLIB
>
> /* Environment configuration */
> #define CONFIG_ENV_SECT_SIZE 0x1000
> diff --git a/include/configs/socfpga_common.h b/include/configs/socfpga_common.h
> index b3f65b6..86eccba 100644
> --- a/include/configs/socfpga_common.h
> +++ b/include/configs/socfpga_common.h
> @@ -105,7 +105,6 @@
> #define CONFIG_DW_ALTDESCRIPTOR
> #define CONFIG_MII
> #define CONFIG_AUTONEG_TIMEOUT (15 * CONFIG_SYS_HZ)
> -#define CONFIG_PHYLIB
> #define CONFIG_PHY_GIGE
> #endif
>
> diff --git a/include/configs/spear-common.h b/include/configs/spear-common.h
> index 1d69477..d2630f4 100644
> --- a/include/configs/spear-common.h
> +++ b/include/configs/spear-common.h
> @@ -17,7 +17,6 @@
>
> /* Ethernet driver configuration */
> #define CONFIG_MII
> -#define CONFIG_PHYLIB
> #define CONFIG_PHY_RESET_DELAY 10000 /* in usec */
> #define CONFIG_PHY_GIGE /* Include GbE speed/duplex detection */
>
> diff --git a/include/configs/stv0991.h b/include/configs/stv0991.h
> index 14c6a9e..f421321 100644
> --- a/include/configs/stv0991.h
> +++ b/include/configs/stv0991.h
> @@ -53,7 +53,6 @@
> /* GMAC related configs */
>
> #define CONFIG_MII
> -#define CONFIG_PHYLIB
> #define CONFIG_DW_ALTDESCRIPTOR
> #define CONFIG_PHY_MICREL
>
> diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h
> index 98a2c74..31a68ac 100644
> --- a/include/configs/sunxi-common.h
> +++ b/include/configs/sunxi-common.h
> @@ -312,7 +312,6 @@ extern int soft_i2c_gpio_scl;
> #define CONFIG_PHY_GIGE /* GMAC can use gigabit PHY */
> #define CONFIG_PHY_ADDR 1
> #define CONFIG_MII /* MII PHY management */
> -#define CONFIG_PHYLIB
> #endif
>
> #ifdef CONFIG_USB_EHCI_HCD
> diff --git a/include/configs/tb100.h b/include/configs/tb100.h
> index 8660ed4..e06484f 100644
> --- a/include/configs/tb100.h
> +++ b/include/configs/tb100.h
> @@ -42,7 +42,6 @@
> /*
> * Ethernet PHY configuration
> */
> -#define CONFIG_PHYLIB
> #define CONFIG_PHY_GIGE
>
> /*
> diff --git a/include/configs/x600.h b/include/configs/x600.h
> index 58f1aca..0263c50 100644
> --- a/include/configs/x600.h
> +++ b/include/configs/x600.h
> @@ -77,7 +77,6 @@
>
> /* Ethernet config options */
> #define CONFIG_MII
> -#define CONFIG_PHYLIB
> #define CONFIG_PHY_RESET_DELAY 10000 /* in usec */
> #define CONFIG_PHY_ADDR 0 /* PHY address */
> #define CONFIG_PHY_GIGE /* Include GbE speed/duplex detection */
> --
Please remove CONFIG_PHYLIB from galileo.h as well.
Regards,
Bin
^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [PATCH] net: eth_designware: select PHYLIB in Kconfig
2015-12-06 13:19 [U-Boot] [PATCH] net: eth_designware: select PHYLIB in Kconfig Thomas Chou
2015-12-06 18:52 ` Marek Vasut
2015-12-07 1:50 ` Bin Meng
@ 2015-12-07 6:09 ` Chin Liang See
2015-12-07 7:59 ` Pavel Machek
` (2 subsequent siblings)
5 siblings, 0 replies; 14+ messages in thread
From: Chin Liang See @ 2015-12-07 6:09 UTC (permalink / raw)
To: u-boot
On Sun, 2015-12-06 at 21:19 +0800, Thomas Chou wrote:
> Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB
> from legacy board header files.
>
> This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE
> are selected.
>
> Reported-by: Pavel Machek <pavel@denx.de>
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> ---
> drivers/net/Kconfig | 1 +
> include/configs/axs101.h | 1 -
> include/configs/bf609-ezkit.h | 1 -
> include/configs/galileo.h | 1 -
> include/configs/socfpga_common.h | 1 -
> include/configs/spear-common.h | 1 -
> include/configs/stv0991.h | 1 -
> include/configs/sunxi-common.h | 1 -
> include/configs/tb100.h | 1 -
> include/configs/x600.h | 1 -
> 10 files changed, 1 insertion(+), 9 deletions(-)
>
Acked-by: Chin Liang See <clsee@altera.com>
Thanks
Chin Liang
^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [PATCH] net: eth_designware: select PHYLIB in Kconfig
2015-12-07 1:50 ` Bin Meng
@ 2015-12-07 6:35 ` Thomas Chou
2015-12-07 9:32 ` Bin Meng
0 siblings, 1 reply; 14+ messages in thread
From: Thomas Chou @ 2015-12-07 6:35 UTC (permalink / raw)
To: u-boot
Hi Bin,
On 2015?12?07? 09:50, Bin Meng wrote:
> Hi Thomas,
>
> On Sun, Dec 6, 2015 at 9:19 PM, Thomas Chou <thomas@wytron.com.tw> wrote:
>> Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB
>> from legacy board header files.
>>
>> This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE
>> are selected.
>>
>> Reported-by: Pavel Machek <pavel@denx.de>
>> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
>> ---
>> drivers/net/Kconfig | 1 +
>> include/configs/axs101.h | 1 -
>> include/configs/bf609-ezkit.h | 1 -
>> include/configs/galileo.h | 1 -
>> include/configs/socfpga_common.h | 1 -
>> include/configs/spear-common.h | 1 -
>> include/configs/stv0991.h | 1 -
>> include/configs/sunxi-common.h | 1 -
>> include/configs/tb100.h | 1 -
>> include/configs/x600.h | 1 -
>> 10 files changed, 1 insertion(+), 9 deletions(-)
>>
>> diff --git a/include/configs/galileo.h b/include/configs/galileo.h
>> index eb16a5e..14a42b1 100644
>> --- a/include/configs/galileo.h
>> +++ b/include/configs/galileo.h
>> @@ -45,7 +45,6 @@
>> /* 10/100M Ethernet support */
>> #define CONFIG_DESIGNWARE_ETH
>> #define CONFIG_DW_ALTDESCRIPTOR
>> -#define CONFIG_PHYLIB
>>
The CONFIG_PHYLIB is removed from galileo.h with this patch.
Best regards,
Thomas
^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [PATCH] net: eth_designware: select PHYLIB in Kconfig
2015-12-06 18:52 ` Marek Vasut
@ 2015-12-07 6:37 ` Thomas Chou
0 siblings, 0 replies; 14+ messages in thread
From: Thomas Chou @ 2015-12-07 6:37 UTC (permalink / raw)
To: u-boot
HI Marek,
On 2015?12?07? 02:52, Marek Vasut wrote:
> On Sunday, December 06, 2015 at 02:19:56 PM, Thomas Chou wrote:
>> Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB
>> from legacy board header files.
>>
>> This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE
>> are selected.
>>
>> Reported-by: Pavel Machek <pavel@denx.de>
>> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
>> ---
>> drivers/net/Kconfig | 1 +
>> include/configs/axs101.h | 1 -
>> include/configs/bf609-ezkit.h | 1 -
>> include/configs/galileo.h | 1 -
>> include/configs/socfpga_common.h | 1 -
>> include/configs/spear-common.h | 1 -
>> include/configs/stv0991.h | 1 -
>> include/configs/sunxi-common.h | 1 -
>> include/configs/tb100.h | 1 -
>> include/configs/x600.h | 1 -
>> 10 files changed, 1 insertion(+), 9 deletions(-)
>>
>> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
>> index a03a95d..4b04d09 100644
>> --- a/drivers/net/Kconfig
>> +++ b/drivers/net/Kconfig
>> @@ -88,6 +88,7 @@ config ETH_SANDBOX_RAW
>>
>> config ETH_DESIGNWARE
>> bool "Synopsys Designware Ethernet MAC"
>> + select PHYLIB
>> help
>> This MAC is present in SoCs from various vendors. It supports
>> 100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to
>
> You should also remove the PHYLIB check in drivers/net/designware.c ,
> otherwise looks good.
>
Yes, it will be removed. Thanks.
Best regards,
Thomas
^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [PATCH] net: eth_designware: select PHYLIB in Kconfig
2015-12-06 13:19 [U-Boot] [PATCH] net: eth_designware: select PHYLIB in Kconfig Thomas Chou
` (2 preceding siblings ...)
2015-12-07 6:09 ` Chin Liang See
@ 2015-12-07 7:59 ` Pavel Machek
2015-12-07 9:33 ` Bin Meng
2015-12-07 12:53 ` [U-Boot] [PATCH v2] " Thomas Chou
5 siblings, 0 replies; 14+ messages in thread
From: Pavel Machek @ 2015-12-07 7:59 UTC (permalink / raw)
To: u-boot
On Sun 2015-12-06 21:19:56, Thomas Chou wrote:
> Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB
> from legacy board header files.
>
> This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE
> are selected.
>
Acked-by: Pavel Machek <pavel@denx.de>
Tested-by: Pavel Machek <pavel@denx.de>
Thanks!
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [PATCH] net: eth_designware: select PHYLIB in Kconfig
2015-12-07 6:35 ` Thomas Chou
@ 2015-12-07 9:32 ` Bin Meng
0 siblings, 0 replies; 14+ messages in thread
From: Bin Meng @ 2015-12-07 9:32 UTC (permalink / raw)
To: u-boot
Hi Thomas,
On Mon, Dec 7, 2015 at 2:35 PM, Thomas Chou <thomas@wytron.com.tw> wrote:
> Hi Bin,
>
> On 2015?12?07? 09:50, Bin Meng wrote:
>>
>> Hi Thomas,
>>
>> On Sun, Dec 6, 2015 at 9:19 PM, Thomas Chou <thomas@wytron.com.tw> wrote:
>>>
>>> Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB
>>> from legacy board header files.
>>>
>>> This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE
>>> are selected.
>>>
>>> Reported-by: Pavel Machek <pavel@denx.de>
>>> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
>>> ---
>>> drivers/net/Kconfig | 1 +
>>> include/configs/axs101.h | 1 -
>>> include/configs/bf609-ezkit.h | 1 -
>>> include/configs/galileo.h | 1 -
>>> include/configs/socfpga_common.h | 1 -
>>> include/configs/spear-common.h | 1 -
>>> include/configs/stv0991.h | 1 -
>>> include/configs/sunxi-common.h | 1 -
>>> include/configs/tb100.h | 1 -
>>> include/configs/x600.h | 1 -
>>> 10 files changed, 1 insertion(+), 9 deletions(-)
>>>
>
>>> diff --git a/include/configs/galileo.h b/include/configs/galileo.h
>>> index eb16a5e..14a42b1 100644
>>> --- a/include/configs/galileo.h
>>> +++ b/include/configs/galileo.h
>>> @@ -45,7 +45,6 @@
>>> /* 10/100M Ethernet support */
>>> #define CONFIG_DESIGNWARE_ETH
>>> #define CONFIG_DW_ALTDESCRIPTOR
>>> -#define CONFIG_PHYLIB
>>>
>
> The CONFIG_PHYLIB is removed from galileo.h with this patch.
>
Ah, yes, I must be brain dead :)
Regards,
Bin
^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [PATCH] net: eth_designware: select PHYLIB in Kconfig
2015-12-06 13:19 [U-Boot] [PATCH] net: eth_designware: select PHYLIB in Kconfig Thomas Chou
` (3 preceding siblings ...)
2015-12-07 7:59 ` Pavel Machek
@ 2015-12-07 9:33 ` Bin Meng
2015-12-07 12:53 ` [U-Boot] [PATCH v2] " Thomas Chou
5 siblings, 0 replies; 14+ messages in thread
From: Bin Meng @ 2015-12-07 9:33 UTC (permalink / raw)
To: u-boot
On Sun, Dec 6, 2015 at 9:19 PM, Thomas Chou <thomas@wytron.com.tw> wrote:
> Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB
> from legacy board header files.
>
> This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE
> are selected.
>
> Reported-by: Pavel Machek <pavel@denx.de>
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> ---
> drivers/net/Kconfig | 1 +
> include/configs/axs101.h | 1 -
> include/configs/bf609-ezkit.h | 1 -
> include/configs/galileo.h | 1 -
> include/configs/socfpga_common.h | 1 -
> include/configs/spear-common.h | 1 -
> include/configs/stv0991.h | 1 -
> include/configs/sunxi-common.h | 1 -
> include/configs/tb100.h | 1 -
> include/configs/x600.h | 1 -
> 10 files changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index a03a95d..4b04d09 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -88,6 +88,7 @@ config ETH_SANDBOX_RAW
>
> config ETH_DESIGNWARE
> bool "Synopsys Designware Ethernet MAC"
> + select PHYLIB
> help
> This MAC is present in SoCs from various vendors. It supports
> 100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to
> diff --git a/include/configs/axs101.h b/include/configs/axs101.h
> index 650d97d..eeb2ae6 100644
> --- a/include/configs/axs101.h
> +++ b/include/configs/axs101.h
> @@ -95,7 +95,6 @@
> /*
> * Ethernet PHY configuration
> */
> -#define CONFIG_PHYLIB
> #define CONFIG_MII
> #define CONFIG_PHY_GIGE
>
> diff --git a/include/configs/bf609-ezkit.h b/include/configs/bf609-ezkit.h
> index 0e353b9..b5d4847 100644
> --- a/include/configs/bf609-ezkit.h
> +++ b/include/configs/bf609-ezkit.h
> @@ -75,7 +75,6 @@
> #define CONFIG_DW_ALTDESCRIPTOR
> #define CONFIG_CMD_MII
> #define CONFIG_MII
> -#define CONFIG_PHYLIB
>
> /* i2c Settings */
> #define CONFIG_SYS_I2C
> diff --git a/include/configs/galileo.h b/include/configs/galileo.h
> index eb16a5e..14a42b1 100644
> --- a/include/configs/galileo.h
> +++ b/include/configs/galileo.h
> @@ -45,7 +45,6 @@
> /* 10/100M Ethernet support */
> #define CONFIG_DESIGNWARE_ETH
> #define CONFIG_DW_ALTDESCRIPTOR
> -#define CONFIG_PHYLIB
>
> /* Environment configuration */
> #define CONFIG_ENV_SECT_SIZE 0x1000
> diff --git a/include/configs/socfpga_common.h b/include/configs/socfpga_common.h
> index b3f65b6..86eccba 100644
> --- a/include/configs/socfpga_common.h
> +++ b/include/configs/socfpga_common.h
> @@ -105,7 +105,6 @@
> #define CONFIG_DW_ALTDESCRIPTOR
> #define CONFIG_MII
> #define CONFIG_AUTONEG_TIMEOUT (15 * CONFIG_SYS_HZ)
> -#define CONFIG_PHYLIB
> #define CONFIG_PHY_GIGE
> #endif
>
> diff --git a/include/configs/spear-common.h b/include/configs/spear-common.h
> index 1d69477..d2630f4 100644
> --- a/include/configs/spear-common.h
> +++ b/include/configs/spear-common.h
> @@ -17,7 +17,6 @@
>
> /* Ethernet driver configuration */
> #define CONFIG_MII
> -#define CONFIG_PHYLIB
> #define CONFIG_PHY_RESET_DELAY 10000 /* in usec */
> #define CONFIG_PHY_GIGE /* Include GbE speed/duplex detection */
>
> diff --git a/include/configs/stv0991.h b/include/configs/stv0991.h
> index 14c6a9e..f421321 100644
> --- a/include/configs/stv0991.h
> +++ b/include/configs/stv0991.h
> @@ -53,7 +53,6 @@
> /* GMAC related configs */
>
> #define CONFIG_MII
> -#define CONFIG_PHYLIB
> #define CONFIG_DW_ALTDESCRIPTOR
> #define CONFIG_PHY_MICREL
>
> diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h
> index 98a2c74..31a68ac 100644
> --- a/include/configs/sunxi-common.h
> +++ b/include/configs/sunxi-common.h
> @@ -312,7 +312,6 @@ extern int soft_i2c_gpio_scl;
> #define CONFIG_PHY_GIGE /* GMAC can use gigabit PHY */
> #define CONFIG_PHY_ADDR 1
> #define CONFIG_MII /* MII PHY management */
> -#define CONFIG_PHYLIB
> #endif
>
> #ifdef CONFIG_USB_EHCI_HCD
> diff --git a/include/configs/tb100.h b/include/configs/tb100.h
> index 8660ed4..e06484f 100644
> --- a/include/configs/tb100.h
> +++ b/include/configs/tb100.h
> @@ -42,7 +42,6 @@
> /*
> * Ethernet PHY configuration
> */
> -#define CONFIG_PHYLIB
> #define CONFIG_PHY_GIGE
>
> /*
> diff --git a/include/configs/x600.h b/include/configs/x600.h
> index 58f1aca..0263c50 100644
> --- a/include/configs/x600.h
> +++ b/include/configs/x600.h
> @@ -77,7 +77,6 @@
>
> /* Ethernet config options */
> #define CONFIG_MII
> -#define CONFIG_PHYLIB
> #define CONFIG_PHY_RESET_DELAY 10000 /* in usec */
> #define CONFIG_PHY_ADDR 0 /* PHY address */
> #define CONFIG_PHY_GIGE /* Include GbE speed/duplex detection */
> --
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [PATCH v2] net: eth_designware: select PHYLIB in Kconfig
2015-12-06 13:19 [U-Boot] [PATCH] net: eth_designware: select PHYLIB in Kconfig Thomas Chou
` (4 preceding siblings ...)
2015-12-07 9:33 ` Bin Meng
@ 2015-12-07 12:53 ` Thomas Chou
2015-12-19 3:56 ` Thomas Chou
5 siblings, 1 reply; 14+ messages in thread
From: Thomas Chou @ 2015-12-07 12:53 UTC (permalink / raw)
To: u-boot
Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB
from legacy board header files.
This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE
are selected.
Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
Reported-by: Pavel Machek <pavel@denx.de>
Acked-by: Chin Liang See <clsee@altera.com>
Acked-by: Pavel Machek <pavel@denx.de>
Tested-by: Pavel Machek <pavel@denx.de>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---
v2
remove the PHYLIB check as suggested by Marek.
drivers/net/Kconfig | 1 +
drivers/net/designware.c | 4 ----
include/configs/axs101.h | 1 -
include/configs/bf609-ezkit.h | 1 -
include/configs/galileo.h | 1 -
include/configs/socfpga_common.h | 1 -
include/configs/spear-common.h | 1 -
include/configs/stv0991.h | 1 -
include/configs/sunxi-common.h | 1 -
include/configs/tb100.h | 1 -
include/configs/x600.h | 1 -
11 files changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index a03a95d..4b04d09 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -88,6 +88,7 @@ config ETH_SANDBOX_RAW
config ETH_DESIGNWARE
bool "Synopsys Designware Ethernet MAC"
+ select PHYLIB
help
This MAC is present in SoCs from various vendors. It supports
100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to
diff --git a/drivers/net/designware.c b/drivers/net/designware.c
index a6c39c3..3af43b4 100644
--- a/drivers/net/designware.c
+++ b/drivers/net/designware.c
@@ -22,10 +22,6 @@
DECLARE_GLOBAL_DATA_PTR;
-#if !defined(CONFIG_PHYLIB)
-# error "DesignWare Ether MAC requires PHYLIB - missing CONFIG_PHYLIB"
-#endif
-
static int dw_mdio_read(struct mii_dev *bus, int addr, int devad, int reg)
{
struct eth_mac_regs *mac_p = bus->priv;
diff --git a/include/configs/axs101.h b/include/configs/axs101.h
index 650d97d..eeb2ae6 100644
--- a/include/configs/axs101.h
+++ b/include/configs/axs101.h
@@ -95,7 +95,6 @@
/*
* Ethernet PHY configuration
*/
-#define CONFIG_PHYLIB
#define CONFIG_MII
#define CONFIG_PHY_GIGE
diff --git a/include/configs/bf609-ezkit.h b/include/configs/bf609-ezkit.h
index 0e353b9..b5d4847 100644
--- a/include/configs/bf609-ezkit.h
+++ b/include/configs/bf609-ezkit.h
@@ -75,7 +75,6 @@
#define CONFIG_DW_ALTDESCRIPTOR
#define CONFIG_CMD_MII
#define CONFIG_MII
-#define CONFIG_PHYLIB
/* i2c Settings */
#define CONFIG_SYS_I2C
diff --git a/include/configs/galileo.h b/include/configs/galileo.h
index eb16a5e..14a42b1 100644
--- a/include/configs/galileo.h
+++ b/include/configs/galileo.h
@@ -45,7 +45,6 @@
/* 10/100M Ethernet support */
#define CONFIG_DESIGNWARE_ETH
#define CONFIG_DW_ALTDESCRIPTOR
-#define CONFIG_PHYLIB
/* Environment configuration */
#define CONFIG_ENV_SECT_SIZE 0x1000
diff --git a/include/configs/socfpga_common.h b/include/configs/socfpga_common.h
index b3f65b6..86eccba 100644
--- a/include/configs/socfpga_common.h
+++ b/include/configs/socfpga_common.h
@@ -105,7 +105,6 @@
#define CONFIG_DW_ALTDESCRIPTOR
#define CONFIG_MII
#define CONFIG_AUTONEG_TIMEOUT (15 * CONFIG_SYS_HZ)
-#define CONFIG_PHYLIB
#define CONFIG_PHY_GIGE
#endif
diff --git a/include/configs/spear-common.h b/include/configs/spear-common.h
index 1d69477..d2630f4 100644
--- a/include/configs/spear-common.h
+++ b/include/configs/spear-common.h
@@ -17,7 +17,6 @@
/* Ethernet driver configuration */
#define CONFIG_MII
-#define CONFIG_PHYLIB
#define CONFIG_PHY_RESET_DELAY 10000 /* in usec */
#define CONFIG_PHY_GIGE /* Include GbE speed/duplex detection */
diff --git a/include/configs/stv0991.h b/include/configs/stv0991.h
index 14c6a9e..f421321 100644
--- a/include/configs/stv0991.h
+++ b/include/configs/stv0991.h
@@ -53,7 +53,6 @@
/* GMAC related configs */
#define CONFIG_MII
-#define CONFIG_PHYLIB
#define CONFIG_DW_ALTDESCRIPTOR
#define CONFIG_PHY_MICREL
diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h
index 98a2c74..31a68ac 100644
--- a/include/configs/sunxi-common.h
+++ b/include/configs/sunxi-common.h
@@ -312,7 +312,6 @@ extern int soft_i2c_gpio_scl;
#define CONFIG_PHY_GIGE /* GMAC can use gigabit PHY */
#define CONFIG_PHY_ADDR 1
#define CONFIG_MII /* MII PHY management */
-#define CONFIG_PHYLIB
#endif
#ifdef CONFIG_USB_EHCI_HCD
diff --git a/include/configs/tb100.h b/include/configs/tb100.h
index 8660ed4..e06484f 100644
--- a/include/configs/tb100.h
+++ b/include/configs/tb100.h
@@ -42,7 +42,6 @@
/*
* Ethernet PHY configuration
*/
-#define CONFIG_PHYLIB
#define CONFIG_PHY_GIGE
/*
diff --git a/include/configs/x600.h b/include/configs/x600.h
index 58f1aca..0263c50 100644
--- a/include/configs/x600.h
+++ b/include/configs/x600.h
@@ -77,7 +77,6 @@
/* Ethernet config options */
#define CONFIG_MII
-#define CONFIG_PHYLIB
#define CONFIG_PHY_RESET_DELAY 10000 /* in usec */
#define CONFIG_PHY_ADDR 0 /* PHY address */
#define CONFIG_PHY_GIGE /* Include GbE speed/duplex detection */
--
2.5.0
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [U-Boot] [PATCH v2] net: eth_designware: select PHYLIB in Kconfig
2015-12-07 12:53 ` [U-Boot] [PATCH v2] " Thomas Chou
@ 2015-12-19 3:56 ` Thomas Chou
2015-12-19 5:47 ` Marek Vasut
0 siblings, 1 reply; 14+ messages in thread
From: Thomas Chou @ 2015-12-19 3:56 UTC (permalink / raw)
To: u-boot
Hi Marek,
On 2015?12?07? 20:53, Thomas Chou wrote:
> Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB
> from legacy board header files.
>
> This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE
> are selected.
>
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> Reported-by: Pavel Machek <pavel@denx.de>
> Acked-by: Chin Liang See <clsee@altera.com>
> Acked-by: Pavel Machek <pavel@denx.de>
> Tested-by: Pavel Machek <pavel@denx.de>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> ---
> v2
> remove the PHYLIB check as suggested by Marek.
>
> drivers/net/Kconfig | 1 +
> drivers/net/designware.c | 4 ----
> include/configs/axs101.h | 1 -
> include/configs/bf609-ezkit.h | 1 -
> include/configs/galileo.h | 1 -
> include/configs/socfpga_common.h | 1 -
> include/configs/spear-common.h | 1 -
> include/configs/stv0991.h | 1 -
> include/configs/sunxi-common.h | 1 -
> include/configs/tb100.h | 1 -
> include/configs/x600.h | 1 -
> 11 files changed, 1 insertion(+), 13 deletions(-)
>
Would you please pick this one? I didn't notice that it was delegated to
me before I sent a PR for nios. Thanks.
Best regards,
Thomas
^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [PATCH v2] net: eth_designware: select PHYLIB in Kconfig
2015-12-19 3:56 ` Thomas Chou
@ 2015-12-19 5:47 ` Marek Vasut
2015-12-19 8:24 ` Thomas Chou
0 siblings, 1 reply; 14+ messages in thread
From: Marek Vasut @ 2015-12-19 5:47 UTC (permalink / raw)
To: u-boot
On Saturday, December 19, 2015 at 04:56:38 AM, Thomas Chou wrote:
> Hi Marek,
>
> On 2015?12?07? 20:53, Thomas Chou wrote:
> > Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB
> > from legacy board header files.
> >
> > This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE
> > are selected.
> >
> > Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> > Reported-by: Pavel Machek <pavel@denx.de>
> > Acked-by: Chin Liang See <clsee@altera.com>
> > Acked-by: Pavel Machek <pavel@denx.de>
> > Tested-by: Pavel Machek <pavel@denx.de>
> > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> > ---
> > v2
> >
> > remove the PHYLIB check as suggested by Marek.
> >
> > drivers/net/Kconfig | 1 +
> > drivers/net/designware.c | 4 ----
> > include/configs/axs101.h | 1 -
> > include/configs/bf609-ezkit.h | 1 -
> > include/configs/galileo.h | 1 -
> > include/configs/socfpga_common.h | 1 -
> > include/configs/spear-common.h | 1 -
> > include/configs/stv0991.h | 1 -
> > include/configs/sunxi-common.h | 1 -
> > include/configs/tb100.h | 1 -
> > include/configs/x600.h | 1 -
> > 11 files changed, 1 insertion(+), 13 deletions(-)
>
> Would you please pick this one? I didn't notice that it was delegated to
> me before I sent a PR for nios. Thanks.
You mean via socfpga ?
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [PATCH v2] net: eth_designware: select PHYLIB in Kconfig
2015-12-19 5:47 ` Marek Vasut
@ 2015-12-19 8:24 ` Thomas Chou
2015-12-21 14:20 ` Marek Vasut
0 siblings, 1 reply; 14+ messages in thread
From: Thomas Chou @ 2015-12-19 8:24 UTC (permalink / raw)
To: u-boot
Hi Marek,
On 2015?12?19? 13:47, Marek Vasut wrote:
> On Saturday, December 19, 2015 at 04:56:38 AM, Thomas Chou wrote:
>> Hi Marek,
>>
>> On 2015?12?07? 20:53, Thomas Chou wrote:
>>> Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB
>>> from legacy board header files.
>>>
>>> This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE
>>> are selected.
>>>
>>> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
>>> Reported-by: Pavel Machek <pavel@denx.de>
>>> Acked-by: Chin Liang See <clsee@altera.com>
>>> Acked-by: Pavel Machek <pavel@denx.de>
>>> Tested-by: Pavel Machek <pavel@denx.de>
>>> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
>>> ---
>>> v2
>>>
>>> remove the PHYLIB check as suggested by Marek.
>>>
>>> drivers/net/Kconfig | 1 +
>>> drivers/net/designware.c | 4 ----
>>> include/configs/axs101.h | 1 -
>>> include/configs/bf609-ezkit.h | 1 -
>>> include/configs/galileo.h | 1 -
>>> include/configs/socfpga_common.h | 1 -
>>> include/configs/spear-common.h | 1 -
>>> include/configs/stv0991.h | 1 -
>>> include/configs/sunxi-common.h | 1 -
>>> include/configs/tb100.h | 1 -
>>> include/configs/x600.h | 1 -
>>> 11 files changed, 1 insertion(+), 13 deletions(-)
>>
>> Would you please pick this one? I didn't notice that it was delegated to
>> me before I sent a PR for nios. Thanks.
>
> You mean via socfpga ?
Yes, please. It was reported on socfpga.
Best regards,
Thomas
^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [PATCH v2] net: eth_designware: select PHYLIB in Kconfig
2015-12-19 8:24 ` Thomas Chou
@ 2015-12-21 14:20 ` Marek Vasut
0 siblings, 0 replies; 14+ messages in thread
From: Marek Vasut @ 2015-12-21 14:20 UTC (permalink / raw)
To: u-boot
On Saturday, December 19, 2015 at 09:24:11 AM, Thomas Chou wrote:
> Hi Marek,
>
> On 2015?12?19? 13:47, Marek Vasut wrote:
> > On Saturday, December 19, 2015 at 04:56:38 AM, Thomas Chou wrote:
> >> Hi Marek,
> >>
> >> On 2015?12?07? 20:53, Thomas Chou wrote:
> >>> Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB
> >>> from legacy board header files.
> >>>
> >>> This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE
> >>> are selected.
> >>>
> >>> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> >>> Reported-by: Pavel Machek <pavel@denx.de>
> >>> Acked-by: Chin Liang See <clsee@altera.com>
> >>> Acked-by: Pavel Machek <pavel@denx.de>
> >>> Tested-by: Pavel Machek <pavel@denx.de>
> >>> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> >>> ---
> >>> v2
> >>>
> >>> remove the PHYLIB check as suggested by Marek.
> >>>
> >>> drivers/net/Kconfig | 1 +
> >>> drivers/net/designware.c | 4 ----
> >>> include/configs/axs101.h | 1 -
> >>> include/configs/bf609-ezkit.h | 1 -
> >>> include/configs/galileo.h | 1 -
> >>> include/configs/socfpga_common.h | 1 -
> >>> include/configs/spear-common.h | 1 -
> >>> include/configs/stv0991.h | 1 -
> >>> include/configs/sunxi-common.h | 1 -
> >>> include/configs/tb100.h | 1 -
> >>> include/configs/x600.h | 1 -
> >>> 11 files changed, 1 insertion(+), 13 deletions(-)
> >>
> >> Would you please pick this one? I didn't notice that it was delegated to
> >> me before I sent a PR for nios. Thanks.
> >
> > You mean via socfpga ?
>
> Yes, please. It was reported on socfpga.
Applied, thanks!
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2015-12-21 14:20 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-06 13:19 [U-Boot] [PATCH] net: eth_designware: select PHYLIB in Kconfig Thomas Chou
2015-12-06 18:52 ` Marek Vasut
2015-12-07 6:37 ` Thomas Chou
2015-12-07 1:50 ` Bin Meng
2015-12-07 6:35 ` Thomas Chou
2015-12-07 9:32 ` Bin Meng
2015-12-07 6:09 ` Chin Liang See
2015-12-07 7:59 ` Pavel Machek
2015-12-07 9:33 ` Bin Meng
2015-12-07 12:53 ` [U-Boot] [PATCH v2] " Thomas Chou
2015-12-19 3:56 ` Thomas Chou
2015-12-19 5:47 ` Marek Vasut
2015-12-19 8:24 ` Thomas Chou
2015-12-21 14:20 ` Marek Vasut
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.