From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yann E. MORIN <yann.morin.1998@free.fr>
Date: Sun, 20 Dec 2015 13:55:17 +0100
Subject: [Buildroot] [PATCH] directfb: remove cle266 and unichrome
	support
In-Reply-To: <1450615477-11659-1-git-send-email-gustavo.zacarias@free-electrons.com>
References: <1450615477-11659-1-git-send-email-gustavo.zacarias@free-electrons.com>
Message-ID: <20151220125517.GB3677@free.fr>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Gustavo, All,

On 2015-12-20 09:44 -0300, gustavo.zacarias at free-electrons.com spake thusly:
> From: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
> 
> They're broken for the latest version and directfb upstream is gone.
> 
> cle266 is an old chipset for AMD K7 (32 bit) athlons with integrated
> graphics - very odd hardware.
> 
> unichrome is another VIA graphics standalone chip/chipset used for some
> odd video cards and VIA CPUs (x86-based: C7, Nano and so on).
> 
> Add options to legacy as well. Fixes:
> 
> http://autobuild.buildroot.net/results/ab9/ab9a6dd044b5f3e8e42629a2aaf598fd0e0357ed/
> 
> Signed-off-by: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
> ---
>  Config.in.legacy             | 16 ++++++++++++++++
>  package/directfb/Config.in   | 10 ----------
>  package/directfb/directfb.mk |  2 --
>  3 files changed, 16 insertions(+), 12 deletions(-)
> 
> diff --git a/Config.in.legacy b/Config.in.legacy
> index 4d22527..c22e35e 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -145,6 +145,22 @@ endif
>  ###############################################################################
>  comment "Legacy options removed in 2016.02"
>  
> +config BR2_PACKAGE_DIRECTFB_CLE266
> +	bool "cle266 driver for directfb"

We usually make the prompt explain what was done, like:

    bool "cle266 driver for directfb was removed"

> +	select BR2_LEGACY
> +	help
> +	  The cle266 directfb driver support has been removed.
> +	  It doesn't build in the latest version and it's unlikely
> +	  anyone has any use for it.
> +
> +config BR2_PACKAGE_DIRECTFB_UNICHROME
> +	bool "unichrome driver for directfb"

Ditto.

Otherwise, OK for me. Wehn you fix, you can add my:

    Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> +	select BR2_LEGACY
> +	help
> +	  The unichrome directfb driver support has been removed.
> +	  It doesn't build in the latest version and it's unlikely
> +	  anyone has any use for it.
> +
>  config BR2_PACKAGE_LIBEINA
>  	bool "libeina package has been removed"
>  	select BR2_LEGACY
> diff --git a/package/directfb/Config.in b/package/directfb/Config.in
> index 2d09460..73425d3 100644
> --- a/package/directfb/Config.in
> +++ b/package/directfb/Config.in
> @@ -61,11 +61,6 @@ config BR2_PACKAGE_DIRECTFB_ATI128
>  	bool "compile ati128 graphics driver"
>  	depends on BR2_i386 || BR2_x86_64
>  
> -config BR2_PACKAGE_DIRECTFB_CLE266
> -	bool "compile cle266 graphics driver"
> -	default y
> -	depends on BR2_i386 || BR2_x86_64
> -
>  config BR2_PACKAGE_DIRECTFB_MATROX
>  	bool "compile matrox graphics driver"
>  	depends on BR2_i386 || BR2_x86_64
> @@ -89,11 +84,6 @@ config BR2_PACKAGE_DIRECTFB_EP9X
>  
>  	  http://cirrus.com/en/products/arm9.html
>  
> -config BR2_PACKAGE_DIRECTFB_UNICHROME
> -	bool "compile unichrome graphics driver"
> -	default y
> -	depends on BR2_i386 || BR2_x86_64
> -
>  config BR2_PACKAGE_DIRECTFB_I830
>  	bool "compile i830 graphics driver"
>  	depends on BR2_i386 || BR2_x86_64
> diff --git a/package/directfb/directfb.mk b/package/directfb/directfb.mk
> index 5e68b7b..d51094f 100644
> --- a/package/directfb/directfb.mk
> +++ b/package/directfb/directfb.mk
> @@ -67,11 +67,9 @@ endif
>  
>  DIRECTFB_GFX = \
>  	$(if $(BR2_PACKAGE_DIRECTFB_ATI128),ati128) \
> -	$(if $(BR2_PACKAGE_DIRECTFB_CLE266),cle266) \
>  	$(if $(BR2_PACKAGE_DIRECTFB_CYBER5K),cyber5k) \
>  	$(if $(BR2_PACKAGE_DIRECTFB_MATROX),matrox) \
>  	$(if $(BR2_PACKAGE_DIRECTFB_PXA3XX),pxa3xx) \
> -	$(if $(BR2_PACKAGE_DIRECTFB_UNICHROME),unichrome) \
>  	$(if $(BR2_PACKAGE_DIRECTFB_I830),i830)	\
>  	$(if $(BR2_PACKAGE_DIRECTFB_EP9X),ep9x)
>  
> -- 
> 2.4.10
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'