All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] RFC: Patch series for Kodi 16-Jarvis
Date: Sun, 20 Dec 2015 14:00:54 +0100	[thread overview]
Message-ID: <20151220130054.GC3677@free.fr> (raw)
In-Reply-To: <20151220135412.652a8344@free-electrons.com>

Thomas, Bernd, All,

On 2015-12-20 13:54 +0100, Thomas Petazzoni spake thusly:
> On Sun, 20 Dec 2015 13:13:19 +0100, Bernd Kuhls wrote:
> > after a first review by Thomas I just updated the branch.
> 
> Thanks. I don't know if others will agree, but I believe it might make
> things easier to review if all the very simple "bump version" patches
> for all kodi add-ons were merged into a single patch. I know we
> normally don't do that, but it would make the series a lot shorter, and
> would emphasize the few updates for which it's not just a mechanical
> bump. So, this "big" commit would only contain the version bumps for
> the packages that don't require anything but a change to the version.
> If you need to do more than that, then it should be in a separate
> commit per package.

Well, I'm not too fond of that. But indeed, it's a pain to review either
way.

Maybe a middle-ground solution would be to bump all the screensavers in
one patch, all the audiocoders in a second one and so on?

Also, I'm not too fond of doing reviews on a github repository. I'd
largely prefer we have a complete RFC series on the list, otherwise the
reviews are lost. For example, I now can't see what Thomas as said,
since the branch has been rebased and previous comments are lost.

So, if the bumps are grouped by catregories, the series will
machanically be shorter, and will be easier to handle on the list.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2015-12-20 13:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-19 18:05 [Buildroot] RFC: Patch series for Kodi 16-Jarvis Bernd Kuhls
2015-12-20 12:13 ` Bernd Kuhls
2015-12-20 12:54   ` Thomas Petazzoni
2015-12-20 13:00     ` Yann E. MORIN [this message]
2015-12-20 13:16       ` Thomas Petazzoni
2015-12-20 13:48         ` Bernd Kuhls
2015-12-20 14:51           ` Yann E. MORIN
2015-12-20 20:37             ` Bernd Kuhls
2016-01-24 13:44               ` Bernd Kuhls
2016-01-24 14:56                 ` Thomas Petazzoni
2016-01-24 15:18                   ` Bernd Kuhls
2016-01-31 16:38                 ` Bernd Kuhls
2016-02-04 20:39                   ` Bernd Kuhls
2016-02-07 13:41                     ` Bernd Kuhls
2016-02-07 13:58                       ` Thomas Petazzoni
2016-02-13 15:41                         ` Bernd Kuhls
2015-12-20 20:41             ` Bernd Kuhls
2015-12-20 14:47         ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151220130054.GC3677@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.