From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933449AbbLTQoJ (ORCPT ); Sun, 20 Dec 2015 11:44:09 -0500 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:34812 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754190AbbLTQoG (ORCPT ); Sun, 20 Dec 2015 11:44:06 -0500 Date: Sun, 20 Dec 2015 16:43:53 +0000 From: One Thousand Gnomes To: Sudip Mukherjee Cc: Greg Kroah-Hartman , Jiri Slaby , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v3] serial: 8250: add gpio support to exar Message-ID: <20151220164353.6ef29f77@lxorguk.ukuu.org.uk> In-Reply-To: <1450617891-26167-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1450617891-26167-1-git-send-email-sudipm.mukherjee@gmail.com> Organization: Intel Corporation X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > v3: Alan commented on v2, few things like NULL check, name of the gpio chip, > moving some more code into the gpio code. He also commented on it being > a separate module, but since this will not be needed by someone who is not > using Exar chip, and even those who are using, some of them may not need it. > This is optional for only those who wants to use the gpio capability of that > chip. So kept it as a separate module. Waiting for your comments on that. That doesn't work because you reference the methods in it so it will always be dragged in. You would have to make the exar driver an MFD that provided a serial and a gpio binding to fix that up I think, or instead of having the serial driver call into your gpio driver (thus forcing the module into memory) you would have the serial driver create a platform device or similar that the GPIO device bound to. Alan