From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754482AbbLTRmr (ORCPT ); Sun, 20 Dec 2015 12:42:47 -0500 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:34996 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933334AbbLTRmW (ORCPT ); Sun, 20 Dec 2015 12:42:22 -0500 Date: Sun, 20 Dec 2015 17:42:08 +0000 From: One Thousand Gnomes To: Sudip Mukherjee Cc: Greg Kroah-Hartman , Jiri Slaby , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v3] serial: 8250: add gpio support to exar Message-ID: <20151220174208.1447d2f3@lxorguk.ukuu.org.uk> In-Reply-To: <20151220172841.GB8471@sudip-laptop> References: <1450617891-26167-1-git-send-email-sudipm.mukherjee@gmail.com> <20151220164353.6ef29f77@lxorguk.ukuu.org.uk> <20151220172841.GB8471@sudip-laptop> Organization: Intel Corporation X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > So then should I rewrite it as MFD or should it be like the way you > suggested in the other mail to have it as bool in the Kconfig and combine > the file with 8250_pci.c when the symbol is selected? Yes although I'm really not sure which is the best approach of the two. Alan