From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751741AbbLUDTq (ORCPT ); Sun, 20 Dec 2015 22:19:46 -0500 Received: from mail-pf0-f171.google.com ([209.85.192.171]:35091 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751305AbbLUDTo (ORCPT ); Sun, 20 Dec 2015 22:19:44 -0500 Date: Mon, 21 Dec 2015 08:49:40 +0530 From: Viresh Kumar To: Javi Merino Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Amit Daniel Kachhap , Zhang Rui , Eduardo Valentin Subject: Re: [PATCH] thermal: cpu_cooling: fix out of bounds access in time_in_idle Message-ID: <20151221031940.GB5532@ubuntu> References: <1450529677-23426-1-git-send-email-javi.merino@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450529677-23426-1-git-send-email-javi.merino@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19-12-15, 12:54, Javi Merino wrote: > In __cpufreq_cooling_register() we allocate the arrays for time_in_idle > and time_in_idle_timestamp to be as big as the number of cpus in this > cpufreq device. However, in get_load() we access this array using the > cpu number as index, which can result in an out of bound access. > > Index time_in_idle{,_timestamp} using the index in the cpufreq_device's > allowed_cpus mask, as we do for the load_cpu array in > cpufreq_get_requested_power() > > Reported-by: Nicolas Boichat > Cc: Amit Daniel Kachhap > Cc: Viresh Kumar > Cc: Zhang Rui > Cc: Eduardo Valentin > Signed-off-by: Javi Merino > --- > drivers/thermal/cpu_cooling.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) Acked-by: Viresh Kumar -- viresh