From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751408AbbLUJxO (ORCPT ); Mon, 21 Dec 2015 04:53:14 -0500 Received: from mail-pf0-f181.google.com ([209.85.192.181]:36742 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751030AbbLUJxM (ORCPT ); Mon, 21 Dec 2015 04:53:12 -0500 Date: Mon, 21 Dec 2015 15:23:08 +0530 From: Viresh Kumar To: SF Markus Elfring Cc: LKML , linux-pm@vger.kernel.org, "Rafael J. Wysocki" , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: blackfin-cpufreq: How to mark cpu_set_cclk() as static? Message-ID: <20151221095308.GE5532@ubuntu> References: <5674598B.6020000@users.sourceforge.net> <20151219015926.GJ3946@ubuntu> <5675141F.2090803@users.sourceforge.net> <20151221031757.GA5532@ubuntu> <5677C452.8040307@users.sourceforge.net> <20151221092805.GD5532@ubuntu> <5677CB72.8090504@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5677CB72.8090504@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21-12-15, 10:50, SF Markus Elfring wrote: > In which order would you prefer that the properties of the > function "cpu_set_cclk" will be improved? > * Should the linkage specifier be added on a separate source code line? No, it can be there in the same line. > * Can this fix be combined with my previous update suggestion for > the return type? I think the first patch is already Acked now and can be applied as it is. Just send the next patch based on the previous one. -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Date: Mon, 21 Dec 2015 09:53:29 +0000 Subject: Re: blackfin-cpufreq: How to mark cpu_set_cclk() as static? Message-Id: <20151221095308.GE5532@ubuntu> List-Id: References: <5674598B.6020000@users.sourceforge.net> <20151219015926.GJ3946@ubuntu> <5675141F.2090803@users.sourceforge.net> <20151221031757.GA5532@ubuntu> <5677C452.8040307@users.sourceforge.net> <20151221092805.GD5532@ubuntu> <5677CB72.8090504@users.sourceforge.net> In-Reply-To: <5677CB72.8090504@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: LKML , linux-pm@vger.kernel.org, "Rafael J. Wysocki" , kernel-janitors@vger.kernel.org, Julia Lawall On 21-12-15, 10:50, SF Markus Elfring wrote: > In which order would you prefer that the properties of the > function "cpu_set_cclk" will be improved? > * Should the linkage specifier be added on a separate source code line? No, it can be there in the same line. > * Can this fix be combined with my previous update suggestion for > the return type? I think the first patch is already Acked now and can be applied as it is. Just send the next patch based on the previous one. -- viresh