All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: "ira.weiny" <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	Leon Romanovsky <leon-2ukJVAZIZ/Y@public.gmane.org>,
	Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH V1 1/3] IB/core: Align coding style of ib_device_cap_flags structure
Date: Mon, 21 Dec 2015 12:20:57 -0800	[thread overview]
Message-ID: <20151221202057.GA6403@infradead.org> (raw)
In-Reply-To: <20151221163603.GF3860-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>

On Mon, Dec 21, 2015 at 11:36:03AM -0500, ira.weiny wrote:
> It would be nice if we were not having to do this for staging then.  Also
> perhaps it should be removed from checkpatch --strict?

Don't use checkpatch --strict ever.  It's full of weird items that
defintively don't apply to the majority of the kernel code base.

> Where are the guidelines for when one can ignore checkpatch and when they can
> not?  It would be nice to know when we can "be developers" vs "being robots to
> some tool".

I think checkpatch is generally useful, and the errors without
--strict are something we I haven't found any false positives.

The warnings are about 90% useful but something are just weird.  For
--strict all bets are off.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-12-21 20:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-20 10:16 [PATCH V1 0/3] Add cross-channel support Leon Romanovsky
     [not found] ` <1450606571-15877-1-git-send-email-leon-2ukJVAZIZ/Y@public.gmane.org>
2015-12-20 10:16   ` [PATCH V1 1/3] IB/core: Align coding style of ib_device_cap_flags structure Leon Romanovsky
     [not found]     ` <1450606571-15877-2-git-send-email-leon-2ukJVAZIZ/Y@public.gmane.org>
2015-12-21  6:22       ` ira.weiny
     [not found]         ` <20151221062252.GE3860-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2015-12-21  6:37           ` Leon Romanovsky
     [not found]             ` <CALq1K=J2e=aw1QuJHGhFFcKkY391myz11r7tG-H+fYbQEyr+Gw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-21  6:52               ` Or Gerlitz
     [not found]                 ` <CAJ3xEMjcusZHb5PRT3ziv-sSYM70U+QtNbjhEYNhvL853Q57Qw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-21  7:27                   ` Leon Romanovsky
     [not found]                     ` <CALq1K=J-Zmb1zwh-ak+wYxo-xooGGYhCjiCOC_Z-4dYVGgkVsA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-21  7:40                       ` Or Gerlitz
     [not found]                         ` <CAJ3xEMjioX_fFZptJSLLC_yv1NszPwJET3zWj8+1x5fajXfBCQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-21  7:53                           ` Leon Romanovsky
     [not found]                             ` <567A70C9.9090801@mellanox.com>
     [not found]                               ` <567A70C9.9090801-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-23 10:23                                 ` Leon Romanovsky
2015-12-21  8:03               ` Christoph Hellwig
     [not found]                 ` <20151221080346.GA21779-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-12-21 16:36                   ` ira.weiny
     [not found]                     ` <20151221163603.GF3860-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2015-12-21 20:20                       ` Christoph Hellwig [this message]
2015-12-24  3:31                       ` Doug Ledford
2015-12-20 10:16   ` [PATCH V1 2/3] IB/core: Add cross-channel support Leon Romanovsky
2015-12-20 10:16   ` [PATCH V1 3/3] IB/mlx5: Add driver " Leon Romanovsky
2015-12-24  4:42   ` [PATCH V1 0/3] Add " Doug Ledford
2015-12-24  8:02   ` Or Gerlitz
     [not found]     ` <567BA695.8050403-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-24 10:00       ` Christoph Hellwig
     [not found]         ` <20151224100001.GA21387-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-12-24 10:41           ` Or Gerlitz
     [not found]             ` <567BCBD1.708-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-24 16:55               ` Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151221202057.GA6403@infradead.org \
    --to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=leon-2ukJVAZIZ/Y@public.gmane.org \
    --cc=leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.